Skip to content

[Due for payment 2026-02-19] [$1,500] R2 Bring Personal Rules into New Expensify #75903

Closed

Description

@JmillsExpensify

Expensify Classic contains an Expense rules feature that we're migrating to New Expensify. The functionality is being migrated "like-for-like," which means that mostly everything you can do on Classic, you'll be able to do on New Expensify. The project scope looks like this:

Expense rules live in Account

If no rules are present, then we'll show an empty state. New rule will also appear in the top right. Expense rules appears below Wallet and above Preferences.
Image

Expense rule creation

We'll use a single step flow in the right-hand pane, which allows a user to enter a merchant, and at least one change.
Image

If a user doesn't enter a merchant or a change, we'll show an error in-line, and also confirm what's required via a standard form error above the Save button (e.g. enter merchant and one change).
Image

If a user enters a merchant but no corresponding change, then we'll only show a standard form error
Image

Field screens

Merchant and rename merchant feature a text input
Image

Update category is a single-select list
Image

Note: From this thread, clicking an option should auto-select & close the RHP for that option

Change description is a text input
Image

Reimbursable is a single select list and consistent with our existing filters on the Reports page
Image
Note: From this thread, clicking an option should auto-select & close the RHP for that option

Same goes for billable
Image
Note: From this thread, clicking an option should auto-select & close the RHP for that option

Add to a report named is a text input (note: if a workspace has default naming enabled, then this report name is overridden on creation).
Image

Rule summary table

Upon successfully saving a rule, it'll appear in a table, which has three columns: checkbox, Merchant, and Change. Consistent with other tables, we'll truncate whatever changes don't fit within the fixed width column.

  • If an individual row is checked then a green [X] selected appears in the top right of the screen, with values for Update and Delete. Update is the same as clicking on the row. Delete shows a standard delete confirmation modal before actually deleting (e.g. title: Delete rule, text: Are you sure you want to delete this rule? with a red Delete button and a grey/button color for Cancel.
  • Change contains a comma separated list of the changes, such as:
    • Rename merchant to [value]
    • Update category to [value]
    • Change description to [value]
    • Reimbursable, Non-reimbursable
    • Billable, Non-billable
    • Add a report named [value]
Image

Editing post creation

If a user wants to edit a rule by clicking that row in the table, the values for that rule will open in the right-hand pane.
Image

Other notes

  • We will not previous matching historical expenses, like we do on Expensify Classic. That can be added in a follow-up issue pending customer demand.
  • The mocks above show categories, since those exist by default in the policy. Though if a policy has tags, then they will appear as an option in a Update tags row. Tags are single-select, just like categories. Equally, policies can have multi-tags so we've got to support that case as well.
Issue OwnerCurrent Issue Owner: @JmillsExpensify

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    NewFeatureSomething to build that is a new item.
    on Nov 24, 2025
  2. melvin-bot commented on Nov 24, 2025

    @melvin-bot

    Current assignee @JmillsExpensify is eligible for the NewFeature assigner, not assigning anyone new.

  3. melvin-bot commented on Nov 24, 2025

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

  4. 99 remaining items

  5. situchan commented on Mar 4, 2026

    @situchan
    Contributor

    @JmillsExpensify can you please sort payment based on summary?

  6. JmillsExpensify commented on Mar 4, 2026

    @JmillsExpensify
    ContributorAuthor

    Just sent you an offer.

  7. aimane-chnaif commented on Mar 4, 2026

    @aimane-chnaif
    Contributor

    Please send me offer as well

  8. JmillsExpensify commented on Mar 4, 2026

    @JmillsExpensify
    ContributorAuthor

    For extra clarity on the main remaining payments:

  9. JmillsExpensify commented on Mar 4, 2026

    @JmillsExpensify
    ContributorAuthor

    Let me know if that's not right for the remaining contributors.

  10. mkhutornyi commented on Mar 4, 2026

    @mkhutornyi
    Contributor

    I am using New Expensify

  11. JmillsExpensify commented on Mar 4, 2026

    @JmillsExpensify
    ContributorAuthor

    Fixed, I actually meant to reflect Upwork payment for @aimane-chnaif. Is that right? Checking our internal records that seems to be the case.

  12. aimane-chnaif commented on Mar 4, 2026

    @aimane-chnaif
    Contributor

    yes right

  13. JmillsExpensify commented on Mar 4, 2026

    @JmillsExpensify
    ContributorAuthor

    Sent you an offer.

  14. aimane-chnaif commented on Mar 4, 2026

    @aimane-chnaif
    Contributor

    Thanks. Accepted, though it should be 500

  15. JmillsExpensify commented on Mar 4, 2026

    @JmillsExpensify
    ContributorAuthor

    Agreed, handled that via a bonus in the payment. All set here!

  16. quinthar commented on Mar 28, 2026

    @quinthar
    Contributor

    Approved $250 to @mkhutornyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2InternalRequires API changes or must be handled by Expensify staffNewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions