You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-03-03][$250] Long tap on the app icon shows the participant selector even though my workspace is domain controlled #76179
Version Number: Reproducible in staging?: Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers):jenna@expensify.com Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@heyjennahay Slack conversation (hyperlinked to channel name): #quality
Action Performed:
As an Admin, go to Domains > [domain] > Domain Members
Search for the submitter and see what Domain Group they are a member of
Go to Groups and set a Preferred workspace for the group and Save
As the submitter, on mobile, long tap the Expensify app icon and select SmartScan
Tap the green button to take a photo
Expected Result:
I should go directly to the expense details page as my workspace is domain controlled thus locked
Actual Result:
I am taken to the the participant selector page
Workaround:
N/A
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App - Pixel 6
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
Please re-state the problem that we are trying to solve in this issue.
Long tap on the app icon shows the participant selector even though my workspace is domain controlled
What is the root cause of that problem?
When a user with a domain-controlled workspace use the long-tap app icon to access SmartScan, the appis not checking if they are restricted to a preferred policy. It would always show the participant selector, requiring users to manually select the workspace again.
What changes do you think we should make in order to solve the problem?
We should add logic to both the native and web versions of IOURequestStepScan to detect when a user is restricted to a preferred policy and automatically skip the participant selection step, going directly to the confirmation page with the preferred workspace pre-assigned.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Long tap on the app icon shows the participant selector even though my workspace is domain controlled[/-][+][$250] Long tap on the app icon shows the participant selector even though my workspace is domain controlled[/+]on Nov 26, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-11-27 00:20:20 UTC.
🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.
Not duplicated: The condition in 2 proposals are different and also my proposal handles in 2 places
Proposal
Please re-state the problem that we are trying to solve in this issue.
Long tap on the app icon shows the participant selector even though my workspace is domain controlled
What is the root cause of that problem?
The navigateToConfirmationStep function in both the mobile and web versions of IOURequestStepScan only checked for a default expense policy (via useDefaultExpensePolicy hook) when determining whether to skip the participant selector.
However, it did not check for domain-controlled preferred policies (via usePreferredPolicy hook), which are set through security group settings in Expensify Classic when admins configure preferred workspaces for domain groups.
What changes do you think we should make in order to solve the problem?
We can get restricted status and preferred policy by using usePreferredPolicy hook
Then we check if user is restricted to a preferred policy (domain-controlled workspace), If so, skip the participant selector and go directly to confirmation with the preferred policy here
Important: We should check condition separately like this to instead of elsehere to prevent wrong priority - default expense policy takes precedence over domain-controlled preferred policy
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
⚠️@lorretheboy Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Could not found offending PR, the bug is a missed case in existing stable code that has been in production for a long time on both Hybrid & NewDot so i think this is a feature gap
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Nov 26, 2025
Triggered auto assignment to @lydiabarclay (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.samranahm commentedon Nov 26, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Long tap on the app icon shows the participant selector even though my workspace is domain controlled
What is the root cause of that problem?
When a user with a domain-controlled workspace use the long-tap app icon to access
SmartScan, the appis not checking if they are restricted to a preferred policy. It would always show the participant selector, requiring users to manually select the workspace again.What changes do you think we should make in order to solve the problem?
We should add logic to both the native and web versions of
IOURequestStepScanto detect when a user is restricted to a preferred policy and automatically skip the participant selection step, going directly to the confirmation page with the preferred workspace pre-assigned.here
App/src/pages/iou/request/step/IOURequestStepScan/index.tsx
Lines 569 to 571 in 48dfc00
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
lydiabarclay commentedon Nov 26, 2025
Confirmed: When you have a policy forced in domain control, you should not see the option to select another workspace when scanning
[-]Long tap on the app icon shows the participant selector even though my workspace is domain controlled[/-][+][$250] Long tap on the app icon shows the participant selector even though my workspace is domain controlled[/+]melvin-bot commentedon Nov 26, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021993805518764612013
melvin-bot commentedon Nov 26, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (
External)lorretheboy commentedon Nov 27, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-11-27 00:20:20 UTC.
🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.
Not duplicated: The condition in 2 proposals are different and also my proposal handles in 2 places
Proposal
Please re-state the problem that we are trying to solve in this issue.
Long tap on the app icon shows the participant selector even though my workspace is domain controlled
What is the root cause of that problem?
The
navigateToConfirmationStepfunction in both the mobile and web versions ofIOURequestStepScanonly checked for a default expense policy (via useDefaultExpensePolicy hook) when determining whether to skip the participant selector.App/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx
Lines 370 to 511 in d0a86f2
App/src/pages/iou/request/step/IOURequestStepScan/index.tsx
Lines 431 to 571 in d0a86f2
However, it did not check for domain-controlled preferred policies (via usePreferredPolicy hook), which are set through security group settings in Expensify Classic when admins configure preferred workspaces for domain groups.
What changes do you think we should make in order to solve the problem?
usePreferredPolicyhookImportant: We should check condition separately like this to instead of
elsehere to prevent wrong priority - default expense policy takes precedence over domain-controlled preferred policyApp/src/pages/iou/request/step/IOURequestStepScan/index.tsx
Line 526 in d0a86f2
We should do similarly with native file to make sure it works on native platform as well
App/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx
Line 91 in d0a86f2
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
github-actions commentedon Nov 27, 2025
21 remaining items
lydiabarclay commentedon Mar 3, 2026
@luacmartins who needs payment here? @nkdengineer and @suneox, or just @suneox ?
luacmartins commentedon Mar 3, 2026
Both
lydiabarclay commentedon Mar 4, 2026
@suneox can you please fill out a BZ checklist?
lydiabarclay commentedon Mar 4, 2026
Payment Summary
Contributor: @nkdengineer due $250 via NewDot
Contributor+: @suneox due $250 via NewDot
✅ Regression test filed
suneox commentedon Mar 6, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Could not found offending PR, the bug is a missed case in existing stable code that has been in production for a long time on both Hybrid & NewDot so i think this is a feature gap
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/608910
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-6877-a076-bcc9-c17290967a94trjExpensify commentedon Mar 6, 2026
approved $250 for @suneox
twisterdotcom commentedon Mar 11, 2026
@nkdengineer has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-9dcd-a80c-88a1-b01fa47a6c74