Skip to content

[Due for payment 2025-12-08] SAML-"Require SAML login" toggle is not greyed out when toggling it in offline mode #76243

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.65-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #74973
Email or phone of affected tester (no customers): applausetester+agadmin@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Windows 11/ Chrome, Samsung S23FE/ Chrome, iPhone 13 Mini/ iOS 26.1
App Component: Other

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. Log in with an account that is a domain admin
  3. Go to the “Workspaces” tab
  4. Tap on the three-dot menu in the domain applause.expensifail.com > Go to domain > SAML
  5. Go Offline
  6. Tap on the "Require SAML login" toggle

Expected Result:

The "Require SAML login" toggle is greyed out when toggling it.

Actual Result:

The "Require SAML login" toggle is not greyed out when toggling it.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug7014925_1764253789760.require_SAML_toggle.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @JmillsExpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 27, 2025
  2. melvin-bot commented on Nov 27, 2025

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. github-actions commented on Nov 27, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Nov 27, 2025

    @melvin-bot

    Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Nov 27, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. lakchote commented on Nov 27, 2025

    @lakchote
    Contributor

    @mhawryluk will take a look at the issue. I don't think this should be a blocker given this is offline, and a minor bug.

  7. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 27, 2025
  8. m-natarajan commented on Nov 27, 2025

    @m-natarajan

    Not repro MacOS Monterey / Chrome Web v9.2.65-4

    Screen.Recording.2025-11-27.at.22.47.02.1.mp4
  9. mountiny commented on Nov 28, 2025

    @mountiny
    Contributor

    Fixed

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Dec 1, 2025
  11. changed the title [-]SAML-"Require SAML login" toggle is not greyed out when toggling it in offline mode[/-] [+][Due for payment 2025-12-08] SAML-"Require SAML login" toggle is not greyed out when toggling it in offline mode[/+] on Dec 1, 2025
  12. melvin-bot commented on Dec 1, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.66-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-12-08. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mhawryluk does not require payment (Contractor)
  13. melvin-bot commented on Dec 1, 2025

    @melvin-bot

    @lakchote @JmillsExpensify @mhawryluk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. JmillsExpensify commented on Dec 3, 2025

    @JmillsExpensify
    Contributor

    Payment summary: $250 @ZhenjaHorbach for PR review and testing. Related do we have a regression test already created for this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions