Skip to content

[Due for payment 2025-12-12] SAML Settings - No confirm modal when disabling "Require SAML login" #76390

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.66-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #74973
Email or phone of affected tester (no customers): applausetester@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 26.1 / Chrome
App Component: Other

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in to applausetester@applause.expensifail.com
  3. Go to Workspaces tab.
  4. Open applause.expensifail.com under Domains section.
  5. Enable SAML login.
  6. Enable "Require SAML login".
  7. Disable "Require SAML login".
  8. Repeat Step 4 to 7 on Old Dot.

Expected Result:

In Step 7, when disabling "Require SAML login", a confirm modal asking "Turning this off will also disable Okta SCIM. Are you sure you wish to proceed?" should appear, similar to Old Dot.

Actual Result:

In Step 7, when disabling "Require SAML login", there is no confirm modal asking "Turning this off will also disable Okta SCIM. Are you sure you wish to proceed?".

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4
Image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 1, 2025
  2. melvin-bot commented on Dec 1, 2025

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. mkzie2 commented on Dec 1, 2025

    @mkzie2
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    In Step 7, when disabling "Require SAML login", there is no confirm modal asking "Turning this off will also disable Okta SCIM. Are you sure you wish to proceed?".

    What is the root cause of that problem?

    In here we didn't implement ConfirmModal when toggling off Require SAML login

    onToggle={() => setSamlRequired(!isSamlRequired, accountID, domainName ?? '')}

    What changes do you think we should make in order to solve the problem?

    We should add a ConfirmModal and show it when user disables Require SAML login

        const [isModalVisible, setIsModalVisible] = useState(false);
    // ....
    
                <ConfirmModal
                    isVisible={isModalVisible}
                    title="Turn off SAML Required"
                    prompt="Turning this off will also disable Okta SCIM. Are you sure you wish to proceed?"
                    confirmText="OK"
                    cancelText="Cancel"
                    onConfirm={() => {
                        setIsModalVisible(false);
                        setSamlRequired(false, accountID, domainName ?? '');
                    }}
                    onCancel={() => setIsModalVisible(false)}
                />

    And update here

                                    onToggle={() => {
                                        if (isSamlRequired) {
                                            setIsModalVisible(true);
                                            return;
                                        }
                                        setSamlRequired(true, accountID, domainName ?? '');
                                    }}

    onToggle={() => setSamlRequired(!isSamlRequired, accountID, domainName ?? '')}

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. mhawryluk commented on Dec 2, 2025

    @mhawryluk
    Member

    yeah, we talked about this during the implementation of SAML settings page and decided to move it to a follow-up. I guess this is the follow up then ^^

  5. mhawryluk commented on Dec 2, 2025

    @mhawryluk
    Member

    could I get a confirmation for this modals's design and English texts, please? @dubielzyk-expensify @jamesdeanexpensify

    Image
  6. 13 remaining items

  7. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Dec 3, 2025
  8. changed the title [-]SAML Settings - No confirm modal when disabling "Require SAML login"[/-] [+][Due for payment 2025-12-12] SAML Settings - No confirm modal when disabling "Require SAML login"[/+] on Dec 5, 2025
  9. melvin-bot commented on Dec 5, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Dec 5, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.72-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-12-12. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mhawryluk does not require payment (Contractor)
  11. melvin-bot commented on Dec 5, 2025

    @melvin-bot

    @NikkiWines / @mountiny @mallenexpensify @mhawryluk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  12. mountiny commented on Dec 6, 2025

    @mountiny
    Contributor

    Part of a project, we can close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DesignWaiting for copyUser facing verbiage needs polishingWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions