You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-12-12] SAML Settings - No confirm modal when disabling "Require SAML login" #76390
Version Number: 9.2.66-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#74973 Email or phone of affected tester (no customers):applausetester@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 26.1 / Chrome App Component: Other
Open applause.expensifail.com under Domains section.
Enable SAML login.
Enable "Require SAML login".
Disable "Require SAML login".
Repeat Step 4 to 7 on Old Dot.
Expected Result:
In Step 7, when disabling "Require SAML login", a confirm modal asking "Turning this off will also disable Okta SCIM. Are you sure you wish to proceed?" should appear, similar to Old Dot.
Actual Result:
In Step 7, when disabling "Require SAML login", there is no confirm modal asking "Turning this off will also disable Okta SCIM. Are you sure you wish to proceed?".
Please re-state the problem that we are trying to solve in this issue.
In Step 7, when disabling "Require SAML login", there is no confirm modal asking "Turning this off will also disable Okta SCIM. Are you sure you wish to proceed?".
What is the root cause of that problem?
In here we didn't implement ConfirmModal when toggling off Require SAML login
What changes do you think we should make in order to solve the problem?
We should add a ConfirmModal and show it when user disables Require SAML login
const[isModalVisible,setIsModalVisible]=useState(false);// ....<ConfirmModalisVisible={isModalVisible}title="Turn off SAML Required"prompt="Turning this off will also disable Okta SCIM. Are you sure you wish to proceed?"confirmText="OK"cancelText="Cancel"onConfirm={()=>{setIsModalVisible(false);setSamlRequired(false,accountID,domainName??'');}}onCancel={()=>setIsModalVisible(false)}/>
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
yeah, we talked about this during the implementation of SAML settings page and decided to move it to a follow-up. I guess this is the follow up then ^^
changed the title [-]SAML Settings - No confirm modal when disabling "Require SAML login"[/-][+][Due for payment 2025-12-12] SAML Settings - No confirm modal when disabling "Require SAML login"[/+]on Dec 5, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.72-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@NikkiWines / @mountiny@mallenexpensify@mhawryluk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Dec 1, 2025
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.mkzie2 commentedon Dec 1, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
In Step 7, when disabling "Require SAML login", there is no confirm modal asking "Turning this off will also disable Okta SCIM. Are you sure you wish to proceed?".
What is the root cause of that problem?
In here we didn't implement ConfirmModal when toggling off
Require SAML loginApp/src/pages/domain/Saml/SamlLoginSectionContent.tsx
Line 74 in 9d37220
What changes do you think we should make in order to solve the problem?
We should add a
ConfirmModaland show it when user disablesRequire SAML loginAnd update here
App/src/pages/domain/Saml/SamlLoginSectionContent.tsx
Line 74 in 9d37220
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
mhawryluk commentedon Dec 2, 2025
yeah, we talked about this during the implementation of SAML settings page and decided to move it to a follow-up. I guess this is the follow up then ^^
mhawryluk commentedon Dec 2, 2025
could I get a confirmation for this modals's design and English texts, please? @dubielzyk-expensify @jamesdeanexpensify
13 remaining items
[-]SAML Settings - No confirm modal when disabling "Require SAML login"[/-][+][Due for payment 2025-12-12] SAML Settings - No confirm modal when disabling "Require SAML login"[/+]melvin-bot commentedon Dec 5, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 5, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.72-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-12-12. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 5, 2025
@NikkiWines / @mountiny @mallenexpensify @mhawryluk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
mountiny commentedon Dec 6, 2025
Part of a project, we can close