Skip to content

[Due for payment 2026-01-27] [Due for payment 2026-01-09] Remove Onyx.connect() for the key: ONYXKEYS.SESSION in src/libs/ReportNameUtils.ts #76424

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @laurenreidexpensify

Activity

  1. self-assigned this
    on Dec 1, 2025
  2. tgolen commented on Dec 1, 2025

    @tgolen
    ContributorAuthor

    Warning

    DO NOT POST PROPOSALS ON THIS ISSUE!!

    Bug-Zero Instructions

    • This issue is CLOSED for proposals
    • It is a special issue and part of a bigger project
    • A contributor will be manually assigned to work on this issue and they do not need to submit a proposal
    • The bug-zero person only needs to take care of payments to the contributor for the PR and the C+ for reviews
    • There do not need to be any regression tests added or updated since this is only refactoring and shouldn't change any existing functionality
  3. added
    ImprovementItem broken or needs improvement.
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 1, 2025
  4. melvin-bot commented on Dec 1, 2025

    @melvin-bot

    Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. 44 remaining items

  6. mountiny commented on Jan 14, 2026

    @mountiny
    Contributor

    Honestly, @shubham1206agra asked in the project group chat to reopen so I assume there is still some work to do in this module. @shubham1206agra can you please clarify?

  7. shubham1206agra commented on Jan 14, 2026

    @shubham1206agra
    Contributor

    @mountiny One PR is remaining #78605 to merge

  8. changed the title [-][Due for payment 2026-01-09] Remove `Onyx.connect()` for the key: `ONYXKEYS.SESSION` in `src/libs/ReportNameUtils.ts`[/-] [+][Due for payment 2026-01-27] [Due for payment 2026-01-09] Remove `Onyx.connect()` for the key: `ONYXKEYS.SESSION` in `src/libs/ReportNameUtils.ts`[/+] on Jan 20, 2026
  9. melvin-bot commented on Jan 20, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Jan 20, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.4-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-01-27. 🎊

    For reference, here are some details about the assignees on this issue:

  11. melvin-bot commented on Jan 20, 2026

    @melvin-bot

    @ShridharGoel / @shubham1206agra @laurenreidexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  12. melvin-bot commented on Jan 27, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@laurenreidexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  13. laurenreidexpensify commented on Jan 28, 2026

    @laurenreidexpensify
    Contributor

    I think all payments have already been approved here ? Is there anything further to action or can this be closed cc @mountiny

  14. mountiny commented on Jan 28, 2026

    @mountiny
    Contributor

    Seems like PR is merged and deployed so we can close then

  15. garrettmknight commented on Apr 2, 2026

    @garrettmknight
    Contributor

    $250 approved for @shubham1206agra

  16. added
    Skip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.
    on Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringImprovementItem broken or needs improvement.Skip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions