Skip to content

Expense - Confirm modal is not shown when creating new empty report from confirm page #76730

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.72-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: #76023
Email or phone of affected tester (no customers): ijsidjsoidjdsoiji@gmail.com

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Create two empty reports
  4. Click + > Create expense > Manual
  5. Enter amount > Next
  6. On confirm page, click Report field
  7. Click Create report

Expected Result:

Confirm modal should display because there are already two empty reports

Actual Result:

Confirm modal is not shown when creating new empty report from confirm page

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug7020735_1764863753819.1.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 4, 2025
  2. melvin-bot commented on Dec 4, 2025

    @melvin-bot

    Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. github-actions commented on Dec 4, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Dec 4, 2025

    @melvin-bot

    Triggered auto assignment to @mollfpr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Dec 4, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. samranahm commented on Dec 4, 2025

    @samranahm
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Confirm modal is not shown when creating new empty report from confirm page

    What is the root cause of that problem?

    We explicitly bypass the Confirmation here that lead to create the report directly and didn't show the confirmation modal

    const {handleCreateReport, CreateReportConfirmationModal} = useConditionalCreateEmptyReportConfirmation({
    policyID: policyForMovingExpensesID,
    policyName: policyForMovingExpenses?.name ?? '',
    onCreateReport: createReportForPolicy,
    shouldBypassConfirmation: true,
    });

    What changes do you think we should make in order to solve the problem?

    We should remove the

    shouldBypassConfirmation: true,

    here

    const {handleCreateReport, CreateReportConfirmationModal} = useConditionalCreateEmptyReportConfirmation({
    policyID: policyForMovingExpensesID,
    policyName: policyForMovingExpenses?.name ?? '',
    onCreateReport: createReportForPolicy,
    shouldBypassConfirmation: true,
    });

    We can implement the same in IOURequestEditReport.tsx

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. jasperhuangg commented on Dec 4, 2025

    @jasperhuangg
    Contributor

    Yeah this seems to be expected looking at the code.. gonna demote. @mollfpr can you work on creating an issue to update the QA steps so this doesn't get reported again?

  8. mollfpr commented on Dec 5, 2025

    @mollfpr
    Contributor
  9. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Dec 5, 2025
  10. mollfpr commented on Dec 8, 2025

    @mollfpr
    Contributor
  11. heyjennahay commented on Dec 8, 2025

    @heyjennahay
    Contributor

    @mollfpr shall we close this out then?

  12. melvin-bot commented on Dec 12, 2025

    @melvin-bot

    @heyjennahay, @mollfpr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  13. mollfpr commented on Dec 12, 2025

    @mollfpr
    Contributor

    Testrail is updated. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions