Skip to content

[Due for payment 2026-03-30] [$250] [Due for payment 2026-01-30] [A11y] Screen Reader: Track Distance: The button 'x' is announced non-descriptively #76952

Closed

Description

@nbhardwaj-del

Action Performed:

Prerequisites:

  • The user is signed in
  • The start and stop points have been selected on the track distance page
  1. Using Chrome + JAWS, open the URL - https://new.expensify.com/
  2. Navigate to the "+" icon and press Enter
  3. Tab to the "Track distance" menu item and press Enter to open the Pop-up
  4. After selecting the "Start/stop" points, Tab to the "Next" button and press Enter
  5. Tab to the "Expensify.org / Teachers Unite" and press Enter to open
  6. Tab to the close "X" button
  7. Observe the screen reader announcement

Expected Result:

The screen reader should clearly and descriptively announce the purpose of the button, e.g.:

  • 'dismiss 'submit an expense banner' or similar

Actual Result:

The button 'x' is announced non-descriptively:

  • 'close'
    The screen reader user will not understand what will be closed.

HTML:

<svg xmlns="http://www.w3.org/2000/svg" xml:space="preserve" viewBox="0 0 20 20" width="20" height="20" hovered="false" pressed="false" fill="#8B9C8F">

Area issue was found in:

Track Distance

Failed WCAG checkpoints

WCAG 2.4.6 Headings and Labels
https://www.w3.org/WAI/WCAG22/Understanding/headings-and-labels

User impact:

Descriptive headings are necessary for users who have disabilities that make reading slow and for people with limited short-term memory. These users benefit when section titles make it possible to predict what each section contains. Form input controls with labels that clearly describe the content that is expected to be entered helps users know how to successfully complete the form.

Suggested resolution:

Update the aria-label to announce the button, e.g.:

Environment(s)

Windows Windows 11 Home - Chrome

Screenshots/Videos

Image
Bug6997322_1762540811559.The_button__x__is_announced_non-descriptively.mp4

Version Number: NA
Reproducible in staging?: NA
Reproducible in production?: Yes
Email or phone of affected tester (no customers): NA
Logs: https://stackoverflow.com/c/expensify/questions/4856 NA
Notes/Photos/Videos: Any additional supporting documentation Yes
Expensify/Expensify Issue URL: https://platform.applause.com/company/12102/products/36605/community-issues/6997322
Issue reported by: NA
Slack conversation: NA

Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022030838426724567825
  • Upwork Job ID: 2030838426724567825
  • Last Price Increase: 2026-03-09
  • Automatic offers:
    • FitseTLT | Contributor | 110741646

Activity

  1. melvin-bot commented on Jan 1, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  2. added a commit that references this issue on Jan 8, 2026
    abf2c59
  3. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 23, 2026
  4. 44 remaining items

  5. melvin-bot commented on Mar 23, 2026

    @melvin-bot

    @FitseTLT @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  6. FitseTLT commented on Mar 27, 2026

    @FitseTLT

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Open the app in a browser with a screen reader enabled (e.g., VoiceOver on Mac, NVDA on Windows)
    2. Tab on the main FAB "+" icon and press Enter
    3. Tab to the "Track distance" menu item and press Enter
    4. After selecting the "Start/stop" points or entering manual distance if it is manual distance, Tab to the "Next" button and press Enter to go to the participants page (If it navigates directly to the confirmation page press the To field to open participants page)
    5. Tab to the Submit an expense banner, then Tab to the close "X" button of the banner
    6. Verify the screen reader clearly and descriptively announces it as 'Close, submit an expense, refer your team, banner button'

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-4176-adfa-261d-818a23639f94
  7. mallenexpensify commented on Mar 30, 2026

    @mallenexpensify

    Payment Summary

    Contributor+: @FitseTLT paid $250 via Upwork

    Thx!

  8. FitseTLT commented on Mar 30, 2026

    @FitseTLT

    Payment Summary

    Contributor+: @FitseTLT due $250 via NewDot

    Thx!

    @mallenexpensify U sent me an upwork offer on another issue few minutes ago. Looks like U keep on forgetting I am paid via upwork 😄 U must be overloadddded

  9. m-natarajan commented on Mar 30, 2026

    @m-natarajan

    @mallenexpensify @FitseTLT
    This is regarding the regression test proposal:
    This QA test steps can't be properly tested by the Applause functional team. There's an ongoing thread on how to treat Accessibility PRs/Issues here
    Didn't create test case or add to monthly retest for this.

  10. mallenexpensify commented on Mar 30, 2026

    @mallenexpensify
  11. m-natarajan commented on Mar 30, 2026

    @m-natarajan

    Going to treat this one as an edge case since I think this is a specific flow to reproduce the problem. I'll add this to our issue list that will be tested on a monthly basis.
    For more context on edge cases, please check this thread.
    Closing the issue - please reopen if needed.

  12. FitseTLT commented on Mar 31, 2026

    @FitseTLT
  13. mallenexpensify commented on Apr 1, 2026

    @mallenexpensify

    @FitseTLT paid, summary updated above. Thx. (one of these days I'll remember... )

  14. changed the title [-][Due for payment 2026-03-30] [$250] [Due for payment 2026-01-30] Screen Reader: Track Distance: The button 'x' is announced non-descriptively[/-] [+][Due for payment 2026-03-30] [$250] [Due for payment 2026-01-30] [A11y] Screen Reader: Track Distance: The button 'x' is announced non-descriptively[/+] on Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

AccessibilityIssues affecting WACG accessibility on any platform.Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions