You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-03-30] [$250] [Due for payment 2026-01-30] [A11y] Screen Reader: Track Distance: The button 'x' is announced non-descriptively #76952
Descriptive headings are necessary for users who have disabilities that make reading slow and for people with limited short-term memory. These users benefit when section titles make it possible to predict what each section contains. Form input controls with labels that clearly describe the content that is expected to be entered helps users know how to successfully complete the form.
Suggested resolution:
Update the aria-label to announce the button, e.g.:
This issue has not been updated in over 15 days. eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
@FitseTLT@mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Open the app in a browser with a screen reader enabled (e.g., VoiceOver on Mac, NVDA on Windows)
Tab on the main FAB "+" icon and press Enter
Tab to the "Track distance" menu item and press Enter
After selecting the "Start/stop" points or entering manual distance if it is manual distance, Tab to the "Next" button and press Enter to go to the participants page (If it navigates directly to the confirmation page press the To field to open participants page)
Tab to the Submit an expense banner, then Tab to the close "X" button of the banner
Verify the screen reader clearly and descriptively announces it as 'Close, submit an expense, refer your team, banner button'
@mallenexpensify U sent me an upwork offer on another issue few minutes ago. Looks like U keep on forgetting I am paid via upwork 😄 U must be overloadddded
@mallenexpensify@FitseTLT
This is regarding the regression test proposal:
This QA test steps can't be properly tested by the Applause functional team. There's an ongoing thread on how to treat Accessibility PRs/Issues here
Didn't create test case or add to monthly retest for this.
Going to treat this one as an edge case since I think this is a specific flow to reproduce the problem. I'll add this to our issue list that will be tested on a monthly basis.
For more context on edge cases, please check this thread.
Closing the issue - please reopen if needed.
changed the title [-][Due for payment 2026-03-30] [$250] [Due for payment 2026-01-30] Screen Reader: Track Distance: The button 'x' is announced non-descriptively[/-][+][Due for payment 2026-03-30] [$250] [Due for payment 2026-01-30] [A11y] Screen Reader: Track Distance: The button 'x' is announced non-descriptively[/+]on Apr 2, 2026
Activity
melvin-bot commentedon Jan 1, 2026
This issue has not been updated in over 15 days. eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Fix Expensify#76952: Add context to banner close button label
44 remaining items
melvin-bot commentedon Mar 23, 2026
@FitseTLT @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
FitseTLT commentedon Mar 27, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-4176-adfa-261d-818a23639f94mallenexpensify commentedon Mar 30, 2026
Payment Summary
Contributor+: @FitseTLT paid $250 via Upwork
Thx!
FitseTLT commentedon Mar 30, 2026
@mallenexpensify U sent me an upwork offer on another issue few minutes ago. Looks like U keep on forgetting I am paid via upwork 😄 U must be overloadddded
m-natarajan commentedon Mar 30, 2026
@mallenexpensify @FitseTLT
This is regarding the regression test proposal:
This QA test steps can't be properly tested by the Applause functional team. There's an ongoing thread on how to treat Accessibility PRs/Issues here
Didn't create test case or add to monthly retest for this.
mallenexpensify commentedon Mar 30, 2026
Thanks @m-natarajan commented on the thread and tagged ya.
m-natarajan commentedon Mar 30, 2026
Going to treat this one as an edge case since I think this is a specific flow to reproduce the problem. I'll add this to our issue list that will be tested on a monthly basis.
For more context on edge cases, please check this thread.
Closing the issue - please reopen if needed.
FitseTLT commentedon Mar 31, 2026
@mallenexpensify bump on #76952 (comment)
mallenexpensify commentedon Apr 1, 2026
@FitseTLT paid, summary updated above. Thx. (one of these days I'll remember... )
[-][Due for payment 2026-03-30] [$250] [Due for payment 2026-01-30] Screen Reader: Track Distance: The button 'x' is announced non-descriptively[/-][+][Due for payment 2026-03-30] [$250] [Due for payment 2026-01-30] [A11y] Screen Reader: Track Distance: The button 'x' is announced non-descriptively[/+]