Skip to content

[Due for payment 2026-01-06] [$250] Accounting - Reconciliation account is not greyed when enable Card reconciliation offline #77340

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.75-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #74064
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Windows 11 / Chrome, Android 13 / Xiaomi Poco F5, iOS 15.8.3 / iPhone 7 Plus
App Component: Workspace Settings

Action Performed:

Preconditions:

  • Have one workspace with the Expensify card and Accounting features enabled
  • The Expensify card has set up a business bank account
  • An accounting software has been set up in the workspace (e.g. Sage Intacct)
  • Make sure the Continuous Reconciliation still disable
  1. Go to staging.new.expensify.com
  2. Go to Workspace settings > Accounting > Card reconciliation
  3. Go to offline mode
  4. Enable the Continuous Reconciliation toggle
  5. Select the Reconciliation account

Expected Result:

Reconciliation account should be greyed when enable Card reconciliation offline

Actual Result:

Reconciliation account is not greyed when enable Card reconciliation offline

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug7026334_1765419863552.77285_-_PR74064_-_Reconciliation_account_is_not_greyed_when_enable_Card_reconciliation_offline.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022000925225740859509
  • Upwork Job ID: 2000925225740859509
  • Last Price Increase: 2025-12-16
Issue OwnerCurrent Issue Owner: @hoangzinh

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 11, 2025
  2. melvin-bot commented on Dec 11, 2025

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nkdengineer commented on Dec 11, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Reconciliation account is not greyed when enable Card reconciliation offline

    What is the root cause of that problem?

    There's no OfflineWithFeedback here

    {!!paymentBankAccountID && !!continuousReconciliation?.value && (

    What changes do you think we should make in order to solve the problem?

    Wrap OfflineWithFeedback here with pending action is continuousReconciliation?.pendingAction

    <OfflineWithFeedback pendingAction={continuousReconciliation?.pendingAction}>
                            {!!paymentBankAccountID && !!continuousReconciliation?.value && (
                                <MenuItemWithTopDescription
                                    style={styles.mt5}
                                    title={bankAccountTitle}
                                    description={translate('workspace.accounting.reconciliationAccount')}
                                    shouldShowRightIcon
                                    onPress={() => Navigation.navigate(ROUTES.WORKSPACE_ACCOUNTING_RECONCILIATION_ACCOUNT_SETTINGS.getRoute(policyID, connection))}
                                />
                            )}
                        </OfflineWithFeedback>
    

    {!!paymentBankAccountID && !!continuousReconciliation?.value && (

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 16, 2025
  5. melvin-bot commented on Dec 16, 2025

    @melvin-bot
  6. changed the title [-]Accounting - Reconciliation account is not greyed when enable Card reconciliation offline[/-] [+][$250] Accounting - Reconciliation account is not greyed when enable Card reconciliation offline[/+] on Dec 16, 2025
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 16, 2025
  8. melvin-bot commented on Dec 16, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

  9. allroundexperts commented on Dec 16, 2025

    @allroundexperts
    Contributor

    @nkdengineer's proposal looks good to me.

    🎀 👀 🎀 C+ reviewed

  10. 19 remaining items

  11. changed the title [-][$250] Accounting - Reconciliation account is not greyed when enable Card reconciliation offline[/-] [+][Due for payment 2026-01-06] [$250] Accounting - Reconciliation account is not greyed when enable Card reconciliation offline[/+] on Dec 30, 2025
  12. melvin-bot commented on Dec 30, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Dec 30, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.88-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-01-06. 🎊

    For reference, here are some details about the assignees on this issue:

    • @hoangzinh requires payment through NewDot Manual Requests
    • @nkdengineer requires payment through NewDot Manual Requests
  14. melvin-bot commented on Dec 30, 2025

    @melvin-bot

    @hoangzinh @sonialiap The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. sonialiap commented on Jan 6, 2026

    @sonialiap
    Contributor

    Payment summary:
    @hoangzinh $250 please request in NewDot and complete the checklist
    @nkdengineer $250 please request in NewDot

  16. hoangzinh commented on Jan 6, 2026

    @hoangzinh
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/47406/files#r2668542856

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

      I think we don't need a regression test for this offline case.

  17. sonialiap commented on Jan 9, 2026

    @sonialiap
    Contributor

    Thanks for the checklist 👍

  18. twisterdotcom commented on Jan 12, 2026

    @twisterdotcom
    Contributor

    @nkdengineer has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-a685-a1d2-80e9-a1e3afd2bd64
  19. garrettmknight commented on Jan 14, 2026

    @garrettmknight
    Contributor

    $250 approved for @hoangzinh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions