You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Android 16 only - "Add" is displayed instead of "Add approver" on Change approver page #77357
Version Number: 9.2.75-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#75729 Email or phone of affected tester (no customers):isjdsoijsojnsiojisndj@gmail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Samsung Galaxy S25 FE / Android 16 App Component: Money Requests
Action Performed:
Precondition:
Android 16 only.
Device font size is minimum.
Launch Expensify app.
Go to workspace chat.
Create an expense.
Tap Submit.
Go to Reports > Menu > Reports.
Select the report by long tapping > Select.
Tap dropdown button > Change approver.
Expected Result:
"Add approver" will be displayed.
Actual Result:
"Add" is displayed instead of "Add approver" on Change approver page.
This issue only happens when "Change approver" page is opened from Reports.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
Android 16 only - "Add" is displayed instead of "Add approver" on Change approver page
What is the root cause of that problem?
The RadioListItem component in SelectionListWithSections applies styles.sidebarLinkTextBold which uses a bold font EXP_NEUE_BOLD. Bold fonts require more width than regular fonts.
What changes do you think we should make in order to solve the problem?
It will ensure the text container takes full available width to display the full title.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
This is reproducible in production. After setting the system font and display size to the minimum, if you create a category called Add approver, it only shows Add when you try to set the category on an expense. Same thing happens if you change Add to App (case-sensitive) or change approver to breakfast.
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: The root cause is in upstream
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Dec 11, 2025
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Dec 11, 2025
Triggered auto assignment to @JS00001 (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Dec 11, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Dec 11, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
samranahm commentedon Dec 11, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Android 16 only - "Add" is displayed instead of "Add approver" on Change approver page
What is the root cause of that problem?
The
RadioListItemcomponent inSelectionListWithSectionsappliesstyles.sidebarLinkTextBoldwhich uses a bold fontEXP_NEUE_BOLD. Bold fonts require more width than regular fonts.What changes do you think we should make in order to solve the problem?
We should add
styles.mnw100hereApp/src/components/SelectionListWithSections/RadioListItem.tsx
Lines 61 to 70 in 4c774c6
It will ensure the text container takes full available width to display the full title.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Nodebrute commentedon Dec 11, 2025
@samranahm I’m unable to reproduce this issue on Android 16 with the small font setting. Am I missing something?
QichenZhu commentedon Dec 11, 2025
This is reproducible in production. After setting the system font and display size to the minimum, if you create a category called
Add approver, it only showsAddwhen you try to set the category on an expense. Same thing happens if you changeAddtoApp(case-sensitive) or changeapprovertobreakfast.pixel-6.webm
53 remaining items
melvin-bot commentedon Feb 19, 2026
@JS00001 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
JS00001 commentedon Feb 19, 2026
Waiting on @kadiealexander , will make them the issue owner
kadiealexander commentedon Feb 23, 2026
Payment Summary
@situchan please complete the checklist!
situchan commentedon Feb 23, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: The root cause is in upstream
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/602907
Regression Test Proposal
Precondition:
Test 1:
Test 2:
Do the same test for tag.
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-31bd-a9d3-99b8-800785c52b04