Skip to content

[$250] Android 16 only - "Add" is displayed instead of "Add approver" on Change approver page #77357

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.75-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #75729
Email or phone of affected tester (no customers): isjdsoijsojnsiojisndj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Money Requests

Action Performed:

Precondition:

  • Android 16 only.
  • Device font size is minimum.
  1. Launch Expensify app.
  2. Go to workspace chat.
  3. Create an expense.
  4. Tap Submit.
  5. Go to Reports > Menu > Reports.
  6. Select the report by long tapping > Select.
  7. Tap dropdown button > Change approver.

Expected Result:

"Add approver" will be displayed.

Actual Result:

"Add" is displayed instead of "Add approver" on Change approver page.

This issue only happens when "Change approver" page is opened from Reports.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4
Image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021999132738674419346
  • Upwork Job ID: 1999132738674419346
  • Last Price Increase: 2025-12-11
  • Automatic offers:
    • situchan | Reviewer | 109820139
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @kadiealexander

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 11, 2025
  2. melvin-bot commented on Dec 11, 2025

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Dec 11, 2025

    @melvin-bot

    Triggered auto assignment to @JS00001 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Dec 11, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Dec 11, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. samranahm commented on Dec 11, 2025

    @samranahm
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Android 16 only - "Add" is displayed instead of "Add approver" on Change approver page

    What is the root cause of that problem?

    The RadioListItem component in SelectionListWithSections applies styles.sidebarLinkTextBold which uses a bold font EXP_NEUE_BOLD. Bold fonts require more width than regular fonts.

    What changes do you think we should make in order to solve the problem?

    We should add styles.mnw100 here

    style={[
    styles.optionDisplayName,
    isFocused ? styles.sidebarLinkActiveText : styles.sidebarLinkText,
    styles.sidebarLinkTextBold,
    isMultilineSupported ? styles.preWrap : styles.pre,
    item.alternateText ? styles.mb1 : null,
    isDisabled && styles.colorMuted,
    isMultilineSupported ? {paddingLeft} : null,
    titleStyles,
    ]}

    It will ensure the text container takes full available width to display the full title.

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. Nodebrute commented on Dec 11, 2025

    @Nodebrute
    Contributor

    @samranahm I’m unable to reproduce this issue on Android 16 with the small font setting. Am I missing something?

  8. QichenZhu commented on Dec 11, 2025

    @QichenZhu
    Contributor

    This is reproducible in production. After setting the system font and display size to the minimum, if you create a category called Add approver, it only shows Add when you try to set the category on an expense. Same thing happens if you change Add to App (case-sensitive) or change approver to breakfast.

    pixel-6.webm
  9. 53 remaining items

  10. melvin-bot commented on Feb 19, 2026

    @melvin-bot

    @JS00001 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  11. JS00001 commented on Feb 19, 2026

    @JS00001
    Contributor

    Waiting on @kadiealexander , will make them the issue owner

  12. kadiealexander commented on Feb 23, 2026

    @kadiealexander
    Contributor

    Payment Summary

    @situchan please complete the checklist!

  13. situchan commented on Feb 23, 2026

    @situchan
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: The root cause is in upstream

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/602907

    Regression Test Proposal

    Precondition:

    • Android 16.
    • Device font size is minimum.

    Test 1:

    1. Go to workspace -> categories -> add category "Add approver" -> save
    2. Go to global create menu (+) -> create expense -> category
    3. Verify "Add approver" is shown instead of just Add

    Test 2:

    1. Go to workspace -> tags -> add tag "Add approver" -> save
    2. Go to global create menu (+) -> create expense -> tag
    3. Verify "Add approver" is shown instead of just Add

    Do the same test for tag.

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-31bd-a9d3-99b8-800785c52b04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions