Skip to content

[Due for payment 2026-01-06] [$250] Search - The search [type:expense status:all merchant:"Expensify, Inc"] displayed briefly #77537

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.75-13
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2374/41535419/1072752857?status_id=1014145&issue_type=jira&sort=%2Bidentifier
Email or phone of affected tester (no customers): applauseexpensifyteam@gmail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Windows 11 / Chrome
App Component: Search

Action Performed:

preconditions: log out if already logged in

  1. Login to the account "applauseexpensifyteam@gmail.com" (Credentials in 1Password)
  2. Navigate to Profile > Subscription
  3. Click on "view payment history"

Expected Result:

the search [type:expense status:all merchant:"Expensify, Inc."] should be remains displayed without only appears briefly then changes to "type:expense-report action:approve to:me"

Actual Result:

the search [type:expense status:all merchant:"Expensify, Inc."] displayed briefly then changes to "type:expense-report action:approve to:me"

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022000735305723218513
  • Upwork Job ID: 2000735305723218513
  • Last Price Increase: 2025-12-16
  • Automatic offers:
    • samranahm | Contributor | 109845710
Issue OwnerCurrent Issue Owner: @RachCHopkins

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 12, 2025
  2. melvin-bot commented on Dec 12, 2025

    @melvin-bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. daledah commented on Dec 12, 2025

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    the search [type:expense status:all merchant:"Expensify, Inc."] displayed briefly then changes to "type:expense-report action:approve to:me"

    What is the root cause of that problem?

    The useSuggestedSearchDefaultNavigation hook automatically navigated to the default "Approve" search after the skeleton finished loading, even when the user had navigated to a specific query (e.g., payment history with a merchant filter).

    Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query: defaultMenuItem.searchQuery}));

    What changes do you think we should make in order to solve the problem?

    We should update the logic in both useSearchTypeMenu.tsx and SearchTypeMenu.tsx to skip automatic navigation when:

    • The query has a rawFilterList (user-typed query), OR
    • The query has explicit filters (not a canned query)
        const shouldSkipSuggestedSearchNavigation = !!queryJSON.rawFilterList || !isCannedSearchQuery(queryJSON);
    

    const shouldSkipSuggestedSearchNavigation = !!queryJSON.rawFilterList;

        const shouldSkipSuggestedSearchNavigation = !!queryJSON?.rawFilterList || (queryJSON ? !isCannedSearchQuery(queryJSON) : false);
    

    const shouldSkipSuggestedSearchNavigation = !!queryJSON?.rawFilterList;

    What alternative solutions did you explore? (Optional)

    Or we can add the rawQuery when navigating here

        const viewPurchases = useCallback(() => {
            const query = buildQueryStringFromFilterFormValues({merchant: CONST.EXPENSIFY_MERCHANT});
            Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query, rawQuery: query}));
        }, []);
    

    const viewPurchases = useCallback(() => {
    const query = buildQueryStringFromFilterFormValues({merchant: CONST.EXPENSIFY_MERCHANT});
    Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query}));
    }, []);

    However, this problem occurs in all places where we navigate to the ROUTES.SEARCH_ROOT route, so we also need to add rawQuery to places like here...

    Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query: buildCannedSearchQuery({type: CONST.SEARCH.DATA_TYPES.EXPENSE_REPORT})}));

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. samranahm commented on Dec 12, 2025

    @samranahm
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When clicking "view payment history" from Profile > Subscription, the search query type:expense status:all merchant:"Expensify, Inc." briefly displays then changes to type:expense-report action:approve to:me.

    What is the root cause of that problem?

    The useSuggestedSearchDefaultNavigation hook automatically redirects to actionable searches like "Approve" when landing on the search page. This auto-navigation is skipped only if the query has a rawFilterList property. Currently, we're not providing the rawQuery parameter needed to populate rawFilterList, so the hook treats it as a generic navigation and redirects to "Approve" search.

    What changes do you think we should make in order to solve the problem?

    Pass both query and rawQuery parameters when navigating to ensure rawFilterList is populated and auto-navigation is suppressed.

    Update the viewPurchases function in CardSection.tsx:

    const query = buildQueryStringFromFilterFormValues({
        type: CONST.SEARCH.DATA_TYPES.EXPENSE,
        status: CONST.SEARCH.STATUS.EXPENSE.ALL,
        merchant: CONST.EXPENSIFY_MERCHANT,
    });
    Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query, rawQuery: query}));

    const viewPurchases = useCallback(() => {
    const query = buildQueryStringFromFilterFormValues({merchant: CONST.EXPENSIFY_MERCHANT});
    Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query}));
    }, []);

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  5. melvin-bot commented on Dec 16, 2025

    @melvin-bot

    @RachCHopkins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Dec 16, 2025
  7. changed the title [-]Search - The search [type:expense status:all merchant:"Expensify, Inc"] displayed briefly[/-] [+][$250] Search - The search [type:expense status:all merchant:"Expensify, Inc"] displayed briefly[/+] on Dec 16, 2025
  8. melvin-bot commented on Dec 16, 2025

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 16, 2025
  10. melvin-bot commented on Dec 16, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

  11. 17 remaining items

  12. changed the title [-][$250] Search - The search [type:expense status:all merchant:"Expensify, Inc"] displayed briefly[/-] [+][Due for payment 2026-01-06] [$250] Search - The search [type:expense status:all merchant:"Expensify, Inc"] displayed briefly[/+] on Dec 30, 2025
  13. melvin-bot commented on Dec 30, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Dec 30, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.88-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-01-06. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Dec 30, 2025

    @melvin-bot

    @eVoloshchak @RachCHopkins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. RachCHopkins commented on Jan 6, 2026

    @RachCHopkins
    Contributor

    Can we get a checklist please @eVoloshchak?

  17. eVoloshchak commented on Jan 8, 2026

    @eVoloshchak
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: there isn't a PR that has caused this, this is due to how the page was implemented initially

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: regression wasn't critical

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template

    Regression Test Proposal

    Precondition:

    • Log in with an account that has an active Expensify subscription or
      Set the account as having purchases by running the following in the terminal: Onyx.merge('account', {hasPurchases: true});

    Test:

    1. Open the Subscription page
    2. Click View payment history
    3. Verify that app navigates to the Reports page and search bar is empty
    4. Press filters button and verify Type Expense and Merchant Expensify filter is applied

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-ae5f-aaca-93ae-72998d4c9ad4
  18. RachCHopkins commented on Jan 9, 2026

    @RachCHopkins
    Contributor

    Payment Summary:

    • Contributor: @samranahm to be paid $250 via Upwork
    • Contributor+: @eVoloshchak to be paid $250 via NewDot Manual Request

    Upwork job here

  19. RachCHopkins commented on Jan 9, 2026

    @RachCHopkins
    Contributor

    Contributor has been paid, the contract has been completed, and the Upwork post has been closed.

    🟢 to @eVoloshchak to request payment.

  20. trjExpensify commented on Jan 31, 2026

    @trjExpensify
    Contributor

    approved $250 for @eVoloshchak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions