You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-01-06] [$250] Search - The search [type:expense status:all merchant:"Expensify, Inc"] displayed briefly #77537
the search [type:expense status:all merchant:"Expensify, Inc."] should be remains displayed without only appears briefly then changes to "type:expense-report action:approve to:me"
Actual Result:
the search [type:expense status:all merchant:"Expensify, Inc."] displayed briefly then changes to "type:expense-report action:approve to:me"
Please re-state the problem that we are trying to solve in this issue.
the search [type:expense status:all merchant:"Expensify, Inc."] displayed briefly then changes to "type:expense-report action:approve to:me"
What is the root cause of that problem?
The useSuggestedSearchDefaultNavigation hook automatically navigated to the default "Approve" search after the skeleton finished loading, even when the user had navigated to a specific query (e.g., payment history with a merchant filter).
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Please re-state the problem that we are trying to solve in this issue.
When clicking "view payment history" from Profile > Subscription, the search query type:expense status:all merchant:"Expensify, Inc." briefly displays then changes to type:expense-report action:approve to:me.
What is the root cause of that problem?
The useSuggestedSearchDefaultNavigation hook automatically redirects to actionable searches like "Approve" when landing on the search page. This auto-navigation is skipped only if the query has a rawFilterList property. Currently, we're not providing the rawQuery parameter needed to populate rawFilterList, so the hook treats it as a generic navigation and redirects to "Approve" search.
What changes do you think we should make in order to solve the problem?
Pass both query and rawQuery parameters when navigating to ensure rawFilterList is populated and auto-navigation is suppressed.
Update the viewPurchases function in CardSection.tsx:
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.88-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@eVoloshchak@RachCHopkins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: there isn't a PR that has caused this, this is due to how the page was implemented initially
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: regression wasn't critical
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Log in with an account that has an active Expensify subscription or
Set the account as having purchases by running the following in the terminal: Onyx.merge('account', {hasPurchases: true});
Test:
Open the Subscription page
Click View payment history
Verify that app navigates to the Reports page and search bar is empty
Press filters button and verify Type Expense and Merchant Expensify filter is applied
Activity
melvin-bot commentedon Dec 12, 2025
Triggered auto assignment to @RachCHopkins (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.daledah commentedon Dec 12, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
the search [type:expense status:all merchant:"Expensify, Inc."] displayed briefly then changes to "type:expense-report action:approve to:me"
What is the root cause of that problem?
The
useSuggestedSearchDefaultNavigationhook automatically navigated to the default "Approve" search after the skeleton finished loading, even when the user had navigated to a specific query (e.g., payment history with a merchant filter).App/src/hooks/useSuggestedSearchDefaultNavigation.ts
Line 49 in 851ef4d
What changes do you think we should make in order to solve the problem?
We should update the logic in both useSearchTypeMenu.tsx and SearchTypeMenu.tsx to skip automatic navigation when:
App/src/hooks/useSearchTypeMenu.tsx
Line 35 in 851ef4d
App/src/pages/Search/SearchTypeMenu.tsx
Line 46 in 851ef4d
What alternative solutions did you explore? (Optional)
Or we can add the
rawQuerywhen navigating hereApp/src/pages/settings/Subscription/CardSection/CardSection.tsx
Lines 82 to 85 in 8777af1
However, this problem occurs in all places where we navigate to the
ROUTES.SEARCH_ROOTroute, so we also need to addrawQueryto places like here...App/src/hooks/useCreateEmptyReportConfirmation.tsx
Line 77 in 9f196c5
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
samranahm commentedon Dec 12, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
When clicking "view payment history" from Profile > Subscription, the search query
type:expense status:all merchant:"Expensify, Inc."briefly displays then changes totype:expense-report action:approve to:me.What is the root cause of that problem?
The
useSuggestedSearchDefaultNavigationhook automatically redirects to actionable searches like "Approve" when landing on the search page. This auto-navigation is skipped only if the query has arawFilterListproperty. Currently, we're not providing therawQueryparameter needed to populaterawFilterList, so the hook treats it as a generic navigation and redirects to "Approve" search.What changes do you think we should make in order to solve the problem?
Pass both
queryandrawQueryparameters when navigating to ensurerawFilterListis populated and auto-navigation is suppressed.Update the
viewPurchasesfunction inCardSection.tsx:App/src/pages/settings/Subscription/CardSection/CardSection.tsx
Lines 82 to 85 in 8777af1
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Dec 16, 2025
@RachCHopkins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
[-]Search - The search [type:expense status:all merchant:"Expensify, Inc"] displayed briefly[/-][+][$250] Search - The search [type:expense status:all merchant:"Expensify, Inc"] displayed briefly[/+]melvin-bot commentedon Dec 16, 2025
Job added to Upwork: https://www.upwork.com/jobs/~022000735305723218513
melvin-bot commentedon Dec 16, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)17 remaining items
[-][$250] Search - The search [type:expense status:all merchant:"Expensify, Inc"] displayed briefly[/-][+][Due for payment 2026-01-06] [$250] Search - The search [type:expense status:all merchant:"Expensify, Inc"] displayed briefly[/+]melvin-bot commentedon Dec 30, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 30, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.88-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-01-06. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Dec 30, 2025
@eVoloshchak @RachCHopkins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
RachCHopkins commentedon Jan 6, 2026
Can we get a checklist please @eVoloshchak?
eVoloshchak commentedon Jan 8, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: there isn't a PR that has caused this, this is due to how the page was implemented initially
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: regression wasn't critical
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/586642
Regression Test Proposal
Precondition:
Set the account as having purchases by running the following in the terminal:
Onyx.merge('account', {hasPurchases: true});Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-ae5f-aaca-93ae-72998d4c9ad4RachCHopkins commentedon Jan 9, 2026
Payment Summary:
Upwork job here
RachCHopkins commentedon Jan 9, 2026
Contributor has been paid, the contract has been completed, and the Upwork post has been closed.
🟢 to @eVoloshchak to request payment.
trjExpensify commentedon Jan 31, 2026
approved $250 for @eVoloshchak.