You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$125] Add bank account - Existing bank account not displayed after workspace currency matches account currency #77626
Version Number: 9.2.78-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#71659 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Windows 11, Chrome | iPhone SE 3rd generation, Tahoe 26.1 Chrome | Samsung A15, Android 16, Chrome App Component: Workspace Settings
Open the workspace and navigate to Workflows > Add bank account.
Complete the flow to add a business bank account.
Create a new workspace with ARS currency, then go to the workspace chat.
Create an expense, submit it, approve it, and try to pay it using 'Pay with business bank account'.
Change the currency of the workspace from ARS to USD.
Return to the expense and pay it again using 'Pay with business bank account'.
Expected Result:
Bank accounts with mismatched currencies should be hidden, but once the workspace currency matches an existing bank account’s currency, those accounts must appear as payment options.
Actual Result:
Even after changing the workspace currency to match an existing bank account’s currency, the accounts do not appear as payment options.
changed the title [-]Add bank account - Existing bank account not displayed after workspace currency matches account currency[/-][+][$250] Add bank account - Existing bank account not displayed after workspace currency matches account currency[/+]on Dec 16, 2025
Please re-state the problem that we are trying to solve in this issue.
When a user changes their workspace currency to match an existing business bank account's currency, the bank account does not appear as a payment option. Users expect matching bank accounts to become available automatically.
What is the root cause of that problem?
The updateGeneralSettings function in src/libs/actions/Policy/Policy.ts updates outputCurrency but does not update policy.achAccount. The SettlementButton component relies on policy.achAccount.bankAccountID to show business bank account payment options - without it being set, no VBBA option appears.
// src/components/SettlementButton/index.tsx - getLatestBankAccountItem()functiongetLatestBankAccountItem(){if(!policy?.achAccount?.bankAccountID){return;// No bank account shown if achAccount is not set}// ...}
The currency filtering logic in getEligibleExistingBusinessBankAccounts works correctly, but it's only used when manually connecting a bank account via the workflows page, not when currency changes.
What changes do you think we should make in order to solve the problem?
Modify updateGeneralSettings in src/libs/actions/Policy/Policy.ts to automatically link an eligible bank account when currency changes:
When currency changes, call getEligibleExistingBusinessBankAccounts to find matching accounts
If one matching account exists → auto-set achAccount.bankAccountID to that account
If multiple matching accounts exist → navigate user to the existing bank account selection page (WORKSPACE_WORKFLOWS_CONNECT_EXISTING_BANK_ACCOUNT)
If no matching accounts and current achAccount currency is now mismatched → clear achAccount
// In updateGeneralSettings - add logic when currency changes:if(isCurrencyChanging){consteligibleBankAccounts=getEligibleExistingBusinessBankAccounts(bankAccountList,currency,false);if(eligibleBankAccounts.length===1){// Auto-connect the single matching accountachAccountUpdate={bankAccountID: eligibleBankAccounts[0].accountData?.bankAccountID,reimburser: policy?.achAccount?.reimburser??policy?.owner,};}elseif(eligibleBankAccounts.length>1){// Flag for caller to navigate to selection pageshouldNavigateToSelectBankAccount=true;}// Include achAccountUpdate in optimisticData}
The caller (WorkspaceOverviewCurrencyPage) would handle navigation when multiple accounts are available:
// In WorkspaceOverviewCurrencyPage - onSelectCurrency:constresult=updateGeneralSettings(policy.id,policy?.name??'',item.currencyCode,bankAccountList);if(result?.shouldNavigateToSelectBankAccount){Navigation.navigate(ROUTES.WORKSPACE_WORKFLOWS_CONNECT_EXISTING_BANK_ACCOUNT.getRoute(policy.id));return;}
What alternative solutions did you explore? (Optional)
Navigate to selection page after every currency change: Always route users to WORKSPACE_WORKFLOWS_CONNECT_EXISTING_BANK_ACCOUNT when eligible accounts exist. Simpler but requires an extra step even when only one account matches.
📣 @etCoderDysto 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
given that you were already hired and @truph01 reviewed your proposal when the other PR was already in motion, the payment for this GH will be $125 instead of $250 (based on the C+ Process Doc: see Step 17b)
If we decide to close the job before it is successfully completed:
50% payment to contributor and C+ if the contributor was hired/assigned.
changed the title [-][$250] Add bank account - Existing bank account not displayed after workspace currency matches account currency[/-][+][$125] Add bank account - Existing bank account not displayed after workspace currency matches account currency[/+]on Feb 10, 2026
Activity
melvin-bot commentedon Dec 13, 2025
Triggered auto assignment to @brianlee-expensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.M00rish commentedon Dec 14, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-12-30 05:09:30 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Add bank account - Existing bank account not displayed after workspace currency matches account currency
What is the root cause of that problem?
current logic does not consider if there are existing bank accounts:
App/src/components/SettlementButton/index.tsx
Line 598 in 8cd91dc
App/src/components/KYCWall/BaseKYCWall.tsx
Lines 187 to 188 in 8cd91dc
What changes do you think we should make in order to solve the problem?
we should do like
WorkspaceWorkflowsPage.tsxand updateSettlmentButtonto check if there existing banks :and add to
SIDEBAR_TO_RHP.tsto make sure we don;t navigate back to workflow page :and in add to
WorkspaceWorkflowsConnectExistingBankAccountPage, so we don't navigate back to worfkflow page :all details will be discussed in PR.
PRo.webm
What alternative solutions did you explore? (Optional)
if using
WorkspaceWorkflowsConnectExistingBankAccountPageis not ideal.Option 2:
create a new compoenent for selection either a popup or RHP modal for user to select the bank account.
Option 3:
Navigate to workflow page for bank selection.
[-]Add bank account - Existing bank account not displayed after workspace currency matches account currency[/-][+][$250] Add bank account - Existing bank account not displayed after workspace currency matches account currency[/+]melvin-bot commentedon Dec 16, 2025
Job added to Upwork: https://www.upwork.com/jobs/~022000957949561471417
melvin-bot commentedon Dec 16, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @truph01 (
External)cosmicvulpes commentedon Dec 17, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user changes their workspace currency to match an existing business bank account's currency, the bank account does not appear as a payment option. Users expect matching bank accounts to become available automatically.
What is the root cause of that problem?
The
updateGeneralSettingsfunction insrc/libs/actions/Policy/Policy.tsupdatesoutputCurrencybut does not updatepolicy.achAccount. TheSettlementButtoncomponent relies onpolicy.achAccount.bankAccountIDto show business bank account payment options - without it being set, no VBBA option appears.The currency filtering logic in
getEligibleExistingBusinessBankAccountsworks correctly, but it's only used when manually connecting a bank account via the workflows page, not when currency changes.What changes do you think we should make in order to solve the problem?
Modify
updateGeneralSettingsinsrc/libs/actions/Policy/Policy.tsto automatically link an eligible bank account when currency changes:getEligibleExistingBusinessBankAccountsto find matching accountsachAccount.bankAccountIDto that accountWORKSPACE_WORKFLOWS_CONNECT_EXISTING_BANK_ACCOUNT)achAccountcurrency is now mismatched → clearachAccountThe caller (
WorkspaceOverviewCurrencyPage) would handle navigation when multiple accounts are available:What alternative solutions did you explore? (Optional)
Navigate to selection page after every currency change: Always route users to
WORKSPACE_WORKFLOWS_CONNECT_EXISTING_BANK_ACCOUNTwhen eligible accounts exist. Simpler but requires an extra step even when only one account matches.melvin-bot commentedon Dec 20, 2025
@truph01 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
52 remaining items
melvin-bot commentedon Feb 2, 2026
📣 @etCoderDysto 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
etCoderDysto commentedon Feb 7, 2026
@truph01 the issue is fixed by this PR #79343. Can you please ask for retest?
App/src/components/KYCWall/BaseKYCWall.tsx
Line 125 in 3af5636
brianlee-expensify commentedon Feb 10, 2026
@etCoderDysto requesting a retest now
m-natarajan commentedon Feb 10, 2026
Issue is not reproducible on Windows 11 / Chrome, Xiaomi Poco F5 / Android 13, iPhone 7 Plus / iOS 15.8.3 in v9.3.15-10
bandicam.2026-02-10.11-07-07-165.mp4
77626_Android-Not.repro.mp4
77626_Not.repro.mp4
brianlee-expensify commentedon Feb 10, 2026
@etCoderDysto appreciate the callout for the other PR.
given that you were already hired and @truph01 reviewed your proposal when the other PR was already in motion, the payment for this GH will be $125 instead of $250 (based on the C+ Process Doc: see Step 17b)
[-][$250] Add bank account - Existing bank account not displayed after workspace currency matches account currency[/-][+][$125] Add bank account - Existing bank account not displayed after workspace currency matches account currency[/+]melvin-bot commentedon Feb 10, 2026
Upwork job price has been updated to $125
brianlee-expensify commentedon Feb 10, 2026
Payment Summary
Contributor: @etCoderDysto paid $125 via Upwork
Contributor+: @truph01 due $125 via NewDot
garrettmknight commentedon May 10, 2026
$125 approved for @truph01