Skip to content

Send Money - "Delete comment" appears instead of sent $ money in LHN after refresh the page #7773

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Log in with any account
  3. Open a chat with any user
  4. Click the "+" button and then "Send money"
    Screen Shot 2022-02-16 at 7 36 44 PM
  5. Enter any amount, then click "Next"
  6. Use the option "I'll settle up elsewhere" on drop down menu.
  7. Refresh the page

Expected Result:

Message displayed in LHN - "Sent $amount elsewhere

Actual Result:

"[Delete comment]" appears instead of sent $ money in LHN after refresh the page

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.39-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.226.mp4
Bug5455431_Screen_Recording_20220215-215650_New_Expensify.mp4
Bug5455431_Image_from_iOS__15_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

Issue was found when executing: #7552

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Feb 16, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. aldo-expensify commented on Feb 17, 2022

    @aldo-expensify
    Contributor

    The report prop had the following value in my case:

    {.  // report
        "hasIOUAction": true,
        "isPinned": false,
        "reportActionCount": 2,
        "lastActionActorEmail": "aldo+test-plaid-2@expensifail.com",
        "lastActionCreated": "2022-02-16 23:58:32",
        "lastActionMessage": {
            "IOUDetails": {
                "amount": 12300,
                "comment": "",
                "currency": "CAD"
            },
            "IOUReportID": 9090,
            "paymentType": "Elsewhere",
            "type": "pay"
        },
        "lastActionType": "IOU",
        ...
    }

    Since there is no report.lastActionMessage.html, the variable lastActionMessage gets initialized to '' here, then here, lastMessageText gets assigned [${Localize.translateLocal('common.deletedCommentMessage')}]

  3. aldo-expensify commented on Feb 17, 2022

    @aldo-expensify
    Contributor

    Updated instructions with simpler steps

  4. aldo-expensify commented on Feb 17, 2022

    @aldo-expensify
    Contributor

    Oh, it broke because of change in Web-E

  5. added
    InternalRequires API changes or must be handled by Expensify staff
    on Feb 17, 2022
  6. MelvinBot commented on Feb 17, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @jliexpensify (Internal) because issue was reported by a contributor who needs to be compensated if this issue is fixed

  7. aldo-expensify commented on Feb 17, 2022

    @aldo-expensify
    Contributor

    was it reported by a contributor?

  8. mvtglobally commented on Feb 17, 2022

    @mvtglobally

    @aldo-expensify NOT reported by a Contributor. Our team noticed it and @joekaufmanexpensify raised it as well in Slack

  9. jliexpensify commented on Feb 17, 2022

    @jliexpensify
    Contributor

    @aldo-expensify - no need to create a job in Upworks right? Is this being handled internally?

  10. aldo-expensify commented on Feb 17, 2022

    @aldo-expensify
    Contributor

    @jliexpensify nop, no need to create job in Upworks.

  11. removed their assignment
    on Feb 21, 2022
  12. jliexpensify commented on Feb 21, 2022

    @jliexpensify
    Contributor

    Cheers Aldo, going to unassign myself!

  13. aldo-expensify commented on Feb 24, 2022

    @aldo-expensify
    Contributor

    No overdue, PR merged, but not deployed yet

  14. aldo-expensify commented on Feb 28, 2022

    @aldo-expensify
    Contributor

    No overdue, PR will be tested in Production

  15. aldo-expensify commented on Mar 4, 2022

    @aldo-expensify
    Contributor

    This was fixed in this PR, but a similar issue remains...

    The last message [Comment deleted] only goes away after refresh, which is somewhat inconsistent.

    Screen.Recording.2022-03-03.at.10.25.12.PM.mov

    I think this has to be fixed in the front end, so I created new GH issue for it: #8001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions