Skip to content

[HOLD for payment 2022-03-22] Reimburse expenses - Currency rate under track distance have been changed only after closing the app  #7780

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log in with expensifail account
  2. Go to any Workspace
  3. Click Reimburse expenses
  4. Check your rate (UAH)
  5. In the section "General settings" change on another currency - USD
  6. Back to "Reimburse expenses" and verify that the rate is displayed in USD

Expected Result:

Currency rate under Truck distance must be changed without closed app.

Actual Result:

Currency rate under Truck distance have been changed only after closing the app

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.39.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5456131_Currency_1602.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Feb 16, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. MelvinBot commented on Feb 21, 2022

    @MelvinBot
    Contributor

    @johnmlee101 Huh... This is 4 days overdue. Who can take care of this?

  3. johnmlee101 commented on Feb 22, 2022

    @johnmlee101
    Contributor

    Seems like an easy fix! Opening up

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 22, 2022
  5. MelvinBot commented on Feb 22, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  6. removed their assignment
    on Feb 22, 2022
  7. mateusbra commented on Feb 23, 2022

    @mateusbra
    Contributor

    PROPOSAL

    We have to change our props within reimburse expenses page(WorkspaceReimburseNoVBAView.js):

    policy: PropTypes.shape({
    customUnit: PropTypes.shape({
    id: PropTypes.string,
    name: PropTypes.string,
    value: PropTypes.string,
    rate: PropTypes.shape({
    id: PropTypes.string,
    name: PropTypes.string,
    value: PropTypes.number,
    currency: PropTypes.string,
    }),
    }),
    }).isRequired,

    removing line 38 adding:

        /** Policy values needed in the component */
        policy: PropTypes.shape({
            customUnit: PropTypes.shape({
                id: PropTypes.string,
                name: PropTypes.string,
                value: PropTypes.string,
                rate: PropTypes.shape({
                    id: PropTypes.string,
                    name: PropTypes.string,
                    value: PropTypes.number,
                }),
            }),
            outputCurrency: PropTypes.string,
        }).isRequired,

    we should also change:

    rateCurrency: lodashGet(props, 'policy.customUnit.rate.currency', ''),

    to:

    rateCurrency: lodashGet(props, 'policy.outputCurrency', ''),

    in order to get currency correctly from outputCurrency.
    optional: Maybe we should also change the name of the state rateCurrency to outputCurreny

    once we don't want customUnit.rate.currency anymore we should also get rid of it within getSimplifiedPolicyObject(),removing line 71:

    function getSimplifiedPolicyObject(fullPolicyOrPolicySummary, isFromFullPolicy) {
    const customUnit = lodashGet(fullPolicyOrPolicySummary, 'value.customUnits[0]', undefined);
    const customUnitValue = lodashGet(customUnit, 'attributes.unit', 'mi');
    const customUnitRate = lodashGet(customUnit, 'rates[0]', {});
    const customUnitSimplified = customUnit && {
    id: customUnit.customUnitID,
    name: customUnit.name,
    value: customUnitValue,
    rate: {
    id: customUnitRate.customUnitRateID,
    name: customUnitRate.name,
    currency: customUnitRate.currency,
    value: Number(customUnitRate.rate),
    },
    };

    SCREEN RECORDING

    2022-02-24.15-45-14.mp4
  8. changed the title [-]Reimburse expenses - Currency rate under Truck distance have been changed only after closing the app [/-] [+]Reimburse expenses - Currency rate under track distance have been changed only after closing the app [/+] on Feb 23, 2022
  9. puneetlath commented on Feb 24, 2022

    @puneetlath
    Contributor
  10. 29 remaining items

  11. mvtglobally commented on Mar 15, 2022

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  12. trjExpensify commented on Mar 15, 2022

    @trjExpensify
    Contributor

    Waiting for the PR to hit prod, Melvin.

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 15, 2022
  14. botify commented on Mar 15, 2022

    @botify

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.42-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-03-22. 🎊

  15. changed the title [-]Reimburse expenses - Currency rate under track distance have been changed only after closing the app [/-] [+][HOLD for payment 2022-03-22] Reimburse expenses - Currency rate under track distance have been changed only after closing the app [/+] on Mar 15, 2022
  16. Christinadobrzyn commented on Mar 25, 2022

    @Christinadobrzyn
    Contributor

    Issued payment for this job in Upwork! Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions