You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2022-03-22] Reimburse expenses - Currency rate under track distance have been changed only after closing the app #7780
changed the title [-]Reimburse expenses - Currency rate under Truck distance have been changed only after closing the app [/-][+]Reimburse expenses - Currency rate under track distance have been changed only after closing the app [/+]on Feb 23, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.42-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
changed the title [-]Reimburse expenses - Currency rate under track distance have been changed only after closing the app [/-][+][HOLD for payment 2022-03-22] Reimburse expenses - Currency rate under track distance have been changed only after closing the app [/+]on Mar 15, 2022
Activity
MelvinBot commentedon Feb 16, 2022
Triggered auto assignment to @johnmlee101 (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.MelvinBot commentedon Feb 21, 2022
@johnmlee101 Huh... This is 4 days overdue. Who can take care of this?
johnmlee101 commentedon Feb 22, 2022
Seems like an easy fix! Opening up
MelvinBot commentedon Feb 22, 2022
Triggered auto assignment to @puneetlath (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.mateusbra commentedon Feb 23, 2022
PROPOSAL
We have to change our props within reimburse expenses page(WorkspaceReimburseNoVBAView.js):
App/src/pages/workspace/reimburse/WorkspaceReimburseNoVBAView.js
Lines 29 to 41 in f45b134
removing line 38 adding:
we should also change:
App/src/pages/workspace/reimburse/WorkspaceReimburseNoVBAView.js
Line 80 in f45b134
to:
in order to get currency correctly from outputCurrency.
optional: Maybe we should also change the name of the state
rateCurrencytooutputCurrenyonce we don't want
customUnit.rate.currencyanymore we should also get rid of it withingetSimplifiedPolicyObject(),removing line 71:App/src/libs/actions/Policy.js
Lines 60 to 74 in 0368dad
SCREEN RECORDING
2022-02-24.15-45-14.mp4
[-]Reimburse expenses - Currency rate under Truck distance have been changed only after closing the app [/-][+]Reimburse expenses - Currency rate under track distance have been changed only after closing the app [/+]puneetlath commentedon Feb 24, 2022
Upwork: https://www.upwork.com/jobs/~01fbea7b6f6b7403b7
29 remaining items
mvtglobally commentedon Mar 15, 2022
Issue not reproducible during KI retests. (First week)
trjExpensify commentedon Mar 15, 2022
Waiting for the PR to hit prod, Melvin.
botify commentedon Mar 15, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.42-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-03-22. 🎊
[-]Reimburse expenses - Currency rate under track distance have been changed only after closing the app [/-][+][HOLD for payment 2022-03-22] Reimburse expenses - Currency rate under track distance have been changed only after closing the app [/+]Christinadobrzyn commentedon Mar 25, 2022
Issued payment for this job in Upwork! Closing this issue.