Skip to content

[Due for payment 2026-01-15] [$250] Hybrid - Scan - App backs to expense detail page when admin rotate receipt and tap on replace icon #77848

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.2.79-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Explore #76037
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 16 pro/ 26.1
App Component: Money Requests

Action Performed:

Precondition:

  • Admin invite an employee to workspace
  • Employee create a scanned expense to workspace
  1. Open app login as admin
  2. Admin tap on employee report
  3. Tap on receipt
  4. Tap on Rotate icon
  5. Tap on Replace icon

Expected Result:

Upload receipt page should display

Actual Result:

App backs to expense detail page

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @stephanieelliott

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 17, 2025
  2. melvin-bot commented on Dec 17, 2025

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Dec 17, 2025

    @melvin-bot

    Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Dec 17, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Dec 17, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. nkdengineer commented on Dec 17, 2025

    @nkdengineer
    Contributor

    After the image is rotated, the receipt becomes a local image, and then the download option isn't available. Because only replace option is availabe, it's displayed instead of the threedot icon. When it's pressed, we call dismissModal with the callback to navigate to the replace page. But the callback is only triggered when a close modal event is fired and in this case no modal is closed then the callback isn't called and we stay on the report page.

    Navigation.dismissModal({
    callback: () =>
    Navigation.navigate(
    ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute(
    action ?? CONST.IOU.ACTION.EDIT,
    iouType,
    draftTransactionID ?? transaction?.transactionID,
    report?.reportID,
    Navigation.getActiveRoute(),
    ),
    ),
    });
    },

  7. nkdengineer commented on Dec 17, 2025

    @nkdengineer
    Contributor

    We can also reproduce the same bug on production if the admin is offline and opens the receipt like this.

    Screen.Recording.2025-12-17.at.15.18.22.mov
  8. nkdengineer commented on Dec 17, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    App backs to expense detail page

    What is the root cause of that problem?

    When the three-dot icon only has one button, it's minimized with this prop and only display this button without the modal.

    When it's pressed, we call dismissModal with the callback to navigate to the replace page. But the callback is only triggered when a close modal event is fired and in this case no modal is closed then the callback isn't called and we stay on the report page.

    Navigation.dismissModal({
    callback: () =>
    Navigation.navigate(
    ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute(
    action ?? CONST.IOU.ACTION.EDIT,
    iouType,
    draftTransactionID ?? transaction?.transactionID,
    report?.reportID,
    Navigation.getActiveRoute(),
    ),
    ),
    });
    },

    const dismissModal = ({ref = navigationRef, callback}: {ref?: NavigationRef; callback?: () => void} = {}) => {
    isNavigationReady().then(() => {
    if (callback) {
    const subscription = DeviceEventEmitter.addListener(CONST.MODAL_EVENTS.CLOSED, () => {
    subscription.remove();
    callback();
    });
    }
    ref.dispatch({type: CONST.NAVIGATION.ACTION_TYPE.DISMISS_MODAL});

    What changes do you think we should make in order to solve the problem?

    We can remove shouldMinimizeMenuButton here so the three-dot is always displayed. Or we can create a prop to control this and pass it as false in TransactionReceiptModalContent

    What alternative solutions did you explore? (Optional)

    We can move the navigation to scan page logic into setNavigationActionToMicrotaskQueue instead

    Navigation.dismissModal();
                            Navigation.setNavigationActionToMicrotaskQueue(() => {
                                Navigation.navigate(
                                    ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute(
                                        action ?? CONST.IOU.ACTION.EDIT,
                                        iouType,
                                        draftTransactionID ?? transaction?.transactionID,
                                        report?.reportID,
                                        Navigation.getActiveRoute(),
                            });
    

    Navigation.dismissModal({
    callback: () =>
    Navigation.navigate(
    ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute(
    action ?? CONST.IOU.ACTION.EDIT,
    iouType,
    draftTransactionID ?? transaction?.transactionID,
    report?.reportID,
    Navigation.getActiveRoute(),
    ),
    ),
    });
    },

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  9. 40 remaining items

  10. changed the title [-][$250] Hybrid - Scan - App backs to expense detail page when admin rotate receipt and tap on replace icon[/-] [+][Due for payment 2026-01-15] [$250] Hybrid - Scan - App backs to expense detail page when admin rotate receipt and tap on replace icon[/+] on Jan 8, 2026
  11. melvin-bot commented on Jan 8, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.95-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-01-15. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Jan 8, 2026

    @melvin-bot

    @aimane-chnaif @stephanieelliott The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. aimane-chnaif commented on Jan 13, 2026

    @aimane-chnaif
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: Not able to find offending PR. The root cause existed for long time.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Admin invite an employee to workspace
    • Employee create a scanned expense to workspace

    Test:

    1. Open app login as admin
    2. Admin tap on employee report
    3. Go offline
    4. Tap on receipt
    5. Verify that the three-dot icon is still shown even if we only have the replace icon
    6. Click on three-dot > Replace
    7. Verify that the replace receipt page is opened

    Do we agree 👍 or 👎

  14. melvin-bot commented on Jan 19, 2026

    @melvin-bot

    @stephanieelliott Eep! 4 days overdue now. Issues have feelings too...

  15. stephanieelliott commented on Jan 21, 2026

    @stephanieelliott
    Contributor

    Payment Summary

    Contributor: @aimane-chnaif paid $250 via Upwork
    Contributor+: @nkdengineer due $250 via NewDot

  16. stephanieelliott commented on Jan 22, 2026

    @stephanieelliott
    Contributor

    All paid!

  17. twisterdotcom commented on Jan 29, 2026

    @twisterdotcom
    Contributor

    @nkdengineer has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-025f-a929-4cd1-c9eb519d5e94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions