You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-01-15] [$250] Hybrid - Scan - App backs to expense detail page when admin rotate receipt and tap on replace icon #77848
Version Number: v9.2.79-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack: Explore #76037 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: iPhone 16 pro/ 26.1 App Component: Money Requests
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
After the image is rotated, the receipt becomes a local image, and then the download option isn't available. Because only replace option is availabe, it's displayed instead of the threedot icon. When it's pressed, we call dismissModal with the callback to navigate to the replace page. But the callback is only triggered when a close modal event is fired and in this case no modal is closed then the callback isn't called and we stay on the report page.
When it's pressed, we call dismissModal with the callback to navigate to the replace page. But the callback is only triggered when a close modal event is fired and in this case no modal is closed then the callback isn't called and we stay on the report page.
What changes do you think we should make in order to solve the problem?
We can remove shouldMinimizeMenuButton here so the three-dot is always displayed. Or we can create a prop to control this and pass it as false in TransactionReceiptModalContent
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-][$250] Hybrid - Scan - App backs to expense detail page when admin rotate receipt and tap on replace icon[/-][+][Due for payment 2026-01-15] [$250] Hybrid - Scan - App backs to expense detail page when admin rotate receipt and tap on replace icon[/+]on Jan 8, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.95-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@aimane-chnaif@stephanieelliott The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Not able to find offending PR. The root cause existed for long time.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Admin invite an employee to workspace
Employee create a scanned expense to workspace
Test:
Open app login as admin
Admin tap on employee report
Go offline
Tap on receipt
Verify that the three-dot icon is still shown even if we only have the replace icon
Activity
melvin-bot commentedon Dec 17, 2025
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Dec 17, 2025
Triggered auto assignment to @blimpich (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Dec 17, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Dec 17, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
nkdengineer commentedon Dec 17, 2025
After the image is rotated, the receipt becomes a local image, and then the download option isn't available. Because only replace option is availabe, it's displayed instead of the threedot icon. When it's pressed, we call
dismissModalwith the callback to navigate to the replace page. But the callback is only triggered when a close modal event is fired and in this case no modal is closed then the callback isn't called and we stay on the report page.App/src/pages/media/AttachmentModalScreen/routes/TransactionReceiptModalContent.tsx
Lines 257 to 269 in c4d51cf
nkdengineer commentedon Dec 17, 2025
We can also reproduce the same bug on production if the admin is offline and opens the receipt like this.
Screen.Recording.2025-12-17.at.15.18.22.mov
nkdengineer commentedon Dec 17, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
App backs to expense detail page
What is the root cause of that problem?
When the three-dot icon only has one button, it's minimized with this prop and only display this button without the modal.
App/src/pages/media/AttachmentModalScreen/AttachmentModalBaseContent/index.tsx
Line 292 in c4d51cf
When it's pressed, we call dismissModal with the callback to navigate to the replace page. But the callback is only triggered when a close modal event is fired and in this case no modal is closed then the callback isn't called and we stay on the report page.
App/src/pages/media/AttachmentModalScreen/routes/TransactionReceiptModalContent.tsx
Lines 257 to 269 in c4d51cf
App/src/libs/Navigation/Navigation.ts
Lines 581 to 590 in c4d51cf
What changes do you think we should make in order to solve the problem?
We can remove
shouldMinimizeMenuButtonhere so the three-dot is always displayed. Or we can create a prop to control this and pass it asfalseinTransactionReceiptModalContentApp/src/pages/media/AttachmentModalScreen/AttachmentModalBaseContent/index.tsx
Line 292 in c4d51cf
What alternative solutions did you explore? (Optional)
We can move the navigation to scan page logic into
setNavigationActionToMicrotaskQueueinsteadApp/src/pages/media/AttachmentModalScreen/routes/TransactionReceiptModalContent.tsx
Lines 257 to 269 in c4d51cf
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
40 remaining items
[-][$250] Hybrid - Scan - App backs to expense detail page when admin rotate receipt and tap on replace icon[/-][+][Due for payment 2026-01-15] [$250] Hybrid - Scan - App backs to expense detail page when admin rotate receipt and tap on replace icon[/+]melvin-bot commentedon Jan 8, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.95-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-01-15. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 8, 2026
@aimane-chnaif @stephanieelliott The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
aimane-chnaif commentedon Jan 13, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Not able to find offending PR. The root cause existed for long time.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
melvin-bot commentedon Jan 19, 2026
@stephanieelliott Eep! 4 days overdue now. Issues have feelings too...
stephanieelliott commentedon Jan 21, 2026
Regression test created: https://github.com/Expensify/Expensify/issues?q=assignee%3Astephanieelliott%20is%3Aopen%20-label%3A%22Waiting%20for%20customer%22
stephanieelliott commentedon Jan 21, 2026
Payment Summary
Contributor: @aimane-chnaif paid $250 via Upwork
Contributor+: @nkdengineer due $250 via NewDot
stephanieelliott commentedon Jan 22, 2026
All paid!
twisterdotcom commentedon Jan 29, 2026
@nkdengineer has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-025f-a929-4cd1-c9eb519d5e94