Skip to content

[Due for payment 2026-01-05] Approval-RHP back button returns to approval limit page when it is skipped, repeated navigation #78316

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.86-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #76032
Email or phone of affected tester (no customers): sndoijsoinjdiisjdiosj@gmail.co
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • User has invited a member to the workspace.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Workflows.
  3. Click Add approval workflow.
  4. Select the invited member in Expenses from.
  5. Select the invited member in Approver page.
  6. Click Skip.
  7. Click RHP back button.
  8. Click back button two more times.
  9. Click back button again.

Expected Result:

In Step 7, RHP will not return to approval limit page since it is skipped.
In Step 8, RHP will return to Expenses from page.
In Step 9, RHP will close.

Actual Result:

In Step 7, RHP back button returns to approval limit page when it is skipped.
In Step 8, RHP reopens approval limit page.
In Step 9, RHP navigation is repeated.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7035654_1766452067840.3.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Dec 23, 2025
  2. melvin-bot commented on Dec 23, 2025

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #76032

  3. melvin-bot commented on Dec 23, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Dec 23, 2025

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Dec 23, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. removed
    DeployBlockerIndicates it should block deploying the API
    on Dec 23, 2025
  7. IuliiaHerets commented on Dec 23, 2025

    @IuliiaHerets

    MacOS Monterey / Chrome
    Web 9.2.86-1
    Old UI. Not reproduce

    Screen.Recording.2025-12-23.at.16.12.07.mp4
  8. JS00001 commented on Dec 23, 2025

    @JS00001
    Contributor

    Fixed by CP revert

  9. changed the title [-]Approval-RHP back button returns to approval limit page when it is skipped, repeated navigation[/-] [+][Due for payment 2026-01-05] Approval-RHP back button returns to approval limit page when it is skipped, repeated navigation[/+] on Dec 29, 2025
  10. melvin-bot commented on Dec 29, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.87-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-01-05. 🎊

  11. melvin-bot commented on Dec 29, 2025

    @melvin-bot

    @JS00001 @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions