Skip to content

Default workflow is strikethrough after removing additional approver in another workflow #78327

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.86-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #76032
Email or phone of affected tester (no customers): applausetester+sdj0mssjsdidnsod1@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Mac 26.1 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Invite User B and C to the workspace.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Workflows.
  3. Click Add approval workflow.
  4. Select User B as submitter.
  5. Select User B as approver.
  6. Enter limit and select User C as additional approver.
  7. Tap Next
  8. Tap Add workflow
  9. Go offline.
  10. Go to Members and remove User C.
  11. Go back to Workflows tab.## Expected Result:efault workflow will not be strikethrough.

Actual Result:

Default workflow is strikethrough after removing additional approver in another workflow.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7035685_1766456933920.7.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 23, 2025
  2. melvin-bot commented on Dec 23, 2025

    @melvin-bot

    Triggered auto assignment to @brianlee-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Dec 23, 2025
  4. melvin-bot commented on Dec 23, 2025

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #76032

  5. melvin-bot commented on Dec 23, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. github-actions commented on Dec 23, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. abzokhattab commented on Dec 23, 2025

    @abzokhattab
    Contributor

    Default workflow is strikethrough because the approver you removed was the main approvel in the default approval

    i think this is the same as #78342

    cc @JS00001

  8. removed
    DeployBlockerIndicates it should block deploying the API
    on Dec 23, 2025
  9. IuliiaHerets commented on Dec 23, 2025

    @IuliiaHerets

    MacOS Monterey / Chrome
    Web 9.2.86-1
    No Limit field.
    Reproduced with strikethrough

    Screen.Recording.2025-12-23.at.15.52.05.mp4
  10. aimane-chnaif commented on Dec 23, 2025

    @aimane-chnaif
    Contributor

    Reproduced with strikethrough

    @IuliiaHerets can you please check in production?

  11. IuliiaHerets commented on Dec 23, 2025

    @IuliiaHerets

    @aimane-chnaif The same result on prod 9.2.85-7

    Screen.Recording.2025-12-23.at.16.38.35.mp4
  12. aimane-chnaif commented on Dec 23, 2025

    @aimane-chnaif
    Contributor

    Thanks. So this is not blocker as happening on production.

  13. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Dec 23, 2025
  14. melvin-bot commented on Dec 27, 2025

    @melvin-bot

    @JS00001, @brianlee-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  15. JS00001 commented on Dec 29, 2025

    @JS00001
    Contributor

    Looks like this was fixed by the revert, so going to close out

  16. added
    ReviewingHas a PR in review
    and removed on Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions