Skip to content

Workflows - No system message for changing approval limit and additional approver #78341

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.86-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #76032
Email or phone of affected tester (no customers): jsdjnosijosijsoijdo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Mac 26.1 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Invite a member to the workspace.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Workflows.
  3. Click on the default approval workflow.
  4. Click Approver.
  5. Enter limit.
  6. Click Additional approver.
  7. Select workspace member
  8. Click Save.
  9. Click Save.
  10. Go to #admins room.

Expected Result:

#admins room will show system message for changing approval limit and additional approver.

Actual Result:

#admins room does not show system message for changing approval limit and additional approver.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 23, 2025
  2. melvin-bot commented on Dec 23, 2025

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #76032

  3. melvin-bot commented on Dec 23, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Dec 23, 2025

    @melvin-bot

    Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Dec 23, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. abzokhattab commented on Dec 23, 2025

    @abzokhattab
    Contributor

    This was not a part of the requirements

  7. IuliiaHerets commented on Dec 23, 2025

    @IuliiaHerets

    MacOS Monterey / Chrome
    Web 9.2.86-1
    No Limit field

    Screen.Recording.2025-12-23.at.15.42.24.mp4
  8. abzokhattab commented on Dec 23, 2025

    @abzokhattab
    Contributor

    thanks @IuliiaHerets ,, we reverted the changes thats why the amount is not shown now

  9. JS00001 commented on Dec 23, 2025

    @JS00001
    Contributor

    Fixed by CP revert, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions