Skip to content

[Due for payment 2026-01-07] [$250] Categories - Error message cant be dismissed in WS member invite via CSV #78345

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.86-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2467/folder/13177080/41237946/1086559287
Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: iPhone 15 Pro / 18.6.2
App Component: Workspace Settings

Action Performed:

  1. Sign into a Beta enabled user
  2. Go to WS > Members > Import spreadsheet
  3. Import the CSV that is in this report
  4. Tap on "Submits to" and change it to "Email" to toggle an error message
  5. Tap on the X button when the error is shown

Expected Result:

Error message should be closed

Actual Result:

Error message can't be closed via X button

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

Bug7035787_1766470966509!CSV.csv

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022003534638134492050
  • Upwork Job ID: 2003534638134492050
  • Last Price Increase: 2025-12-23
  • Automatic offers:
    • aimane-chnaif | Reviewer | 109905422
    • NJ-2020 | Contributor | 109905423
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 23, 2025
  2. melvin-bot commented on Dec 23, 2025

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Dec 23, 2025

    @melvin-bot

    Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Dec 23, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Dec 23, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. NJ-2020 commented on Dec 23, 2025

    @NJ-2020
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Categories - Error message cant be dismissed in WS member invite via CSV

    What is the root cause of that problem?

    It happens after this PR #78062 where it only shows the X close/dismiss icon if onDismiss is set.

    1. Workspace members page
      <ImportSpreadsheetColumns
      spreadsheetColumns={spreadsheetColumns}
      columnNames={columnNames}
      importFunction={importMembers}
      errors={isValidationEnabled ? validate() : undefined}
      columnRoles={columnRoles}
      isButtonLoading={isImporting}
      learnMoreLink={CONST.IMPORT_SPREADSHEET.MEMBERS_ARTICLE_LINK}
      />
    2. Import spreadsheet modal
      <FixedFooter addBottomSafeAreaPadding>
      <OfflineWithFeedback
      shouldDisplayErrorAbove
      errors={errors}
      errorRowStyles={styles.mv2}
      >
    3. Error footer (display error message)
      {shouldShowErrorMessages && !shouldDisplayErrorAbove && (
      <ErrorMessageRow
      errors={errors}
      errorRowStyles={errorRowStyles}
      errorRowTextStyles={errorRowTextStyles}
      onDismiss={onDismiss}
      dismissError={dismissError}
      />
      )}
    4. Right here, we show the X close/dismiss icon based on this condition
      const showDismissButton = !!onDismiss;

      {showDismissButton && (
      <Tooltip text={dismissText}>
      <PressableWithoutFeedback
      onPress={onDismiss}
      role={CONST.ROLE.BUTTON}
      accessibilityLabel={dismissText}
      >
      <Icon
      fill={theme.icon}
      src={icons.Close}
      />
      </PressableWithoutFeedback>
      </Tooltip>
      )}

      But showDismissButton will always be true, because we set an empty function as default value for onDismiss function, so () => {} will always return true causing to always to show the X close icon even if we pass undefined to onDismiss
      function MessagesRow({messages = {}, type, onDismiss = () => {}, containerStyles, dismissError = () => {}, errorTextStyles}: MessagesRowProps) {

    What changes do you think we should make in order to solve the problem?

    We should not set default value here

    function MessagesRow({messages = {}, type, onDismiss, containerStyles, dismissError = () => {}, errorTextStyles}: MessagesRowProps) {
    Image

    What alternative solutions did you explore? (Optional)

  7. neil-marcellini commented on Dec 23, 2025

    @neil-marcellini
    Contributor

    @jponikarchuk If the first step of an issue is to sign into an account on a beta, then by definition it is not a deploy blocker because it is under a beta.

  8. 30 remaining items

  9. melvin-bot commented on Jan 9, 2026

    @melvin-bot

    @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  10. mallenexpensify commented on Jan 10, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @NJ-2020 paid $250 via Upwork
    #contributor-plus: @aimane-chnaif paid $250 via Upwork
    @aimane-chnaif did you review the offending PR? I didn't see a ✅ next to your name. Asking cuz, if you reviewed that PR and it caused this regression, you wouldn't get paid (unless it was outside of the regression time)

    ^ Test case created

  11. aimane-chnaif commented on Jan 10, 2026

    @aimane-chnaif
    Contributor

    @mallenexpensify It looks as if I reviewed #78062 (offending PR) just because I commented on the offending line for BZ Checklist. Not involved at all.

    You can see timeline:

    Image
  12. melvin-bot commented on Jan 13, 2026

    @melvin-bot

    @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  13. mallenexpensify commented on Jan 14, 2026

    @mallenexpensify
    Contributor

    Thanks @aimane-chnaif , we sh ould be good to close then

  14. aimane-chnaif commented on Jan 14, 2026

    @aimane-chnaif
    Contributor

    @mallenexpensify I haven't received payment yet.

  15. mallenexpensify commented on Jan 15, 2026

    @mallenexpensify
    Contributor

    @aimane-chnaif , updated payment summary.
    I was confused cuz I missed 'offending PR' in your comment and was thinking of the PR from this issue, sorry.

  16. aimane-chnaif commented on Jan 27, 2026

    @aimane-chnaif
    Contributor

    @mallenexpensify can you please reopen? I am using upwork and payment still pending

  17. mallenexpensify commented on Jan 27, 2026

    @mallenexpensify
    Contributor

    Sorry @aimane-chnaif , paid, summary updated above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions