You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-01-07] [$250] Categories - Error message cant be dismissed in WS member invite via CSV #78345
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
But showDismissButton will always be true, because we set an empty function as default value for onDismiss function, so () => {} will always return true causing to always to show the X close icon even if we pass undefined to onDismiss
@jponikarchuk If the first step of an issue is to sign into an account on a beta, then by definition it is not a deploy blocker because it is under a beta.
Contributor: @NJ-2020 paid $250 via Upwork
#contributor-plus: @aimane-chnaif paid $250 via Upwork @aimane-chnaif did you review the offending PR? I didn't see a ✅ next to your name. Asking cuz, if you reviewed that PR and it caused this regression, you wouldn't get paid (unless it was outside of the regression time)
@aimane-chnaif , updated payment summary.
I was confused cuz I missed 'offending PR' in your comment and was thinking of the PR from this issue, sorry.
Activity
melvin-bot commentedon Dec 23, 2025
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Dec 23, 2025
Triggered auto assignment to @neil-marcellini (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Dec 23, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 23, 2025
💬 A slack conversation has been started in #expensify-open-source
NJ-2020 commentedon Dec 23, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Categories - Error message cant be dismissed in WS member invite via CSV
What is the root cause of that problem?
It happens after this PR #78062 where it only shows the
Xclose/dismiss icon ifonDismissis set.App/src/pages/workspace/members/ImportedMembersPage.tsx
Lines 190 to 198 in 589574c
App/src/components/ImportSpreadsheetColumns.tsx
Lines 106 to 111 in 589574c
App/src/components/OfflineWithFeedback.tsx
Lines 155 to 163 in 589574c
Xclose/dismiss icon based on this conditionApp/src/components/MessagesRow.tsx
Line 43 in 589574c
App/src/components/MessagesRow.tsx
Lines 60 to 73 in 589574c
But
showDismissButtonwill always be true, because we set an empty function as default value foronDismissfunction, so() => {}will always returntruecausing to always to show theXclose icon even if we pass undefined toonDismissApp/src/components/MessagesRow.tsx
Line 37 in 589574c
What changes do you think we should make in order to solve the problem?
We should not set default value here
What alternative solutions did you explore? (Optional)
neil-marcellini commentedon Dec 23, 2025
@jponikarchuk If the first step of an issue is to sign into an account on a beta, then by definition it is not a deploy blocker because it is under a beta.
30 remaining items
melvin-bot commentedon Jan 9, 2026
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
mallenexpensify commentedon Jan 10, 2026
Payment Summary
Contributor: @NJ-2020 paid $250 via Upwork
#contributor-plus: @aimane-chnaif paid $250 via Upwork
@aimane-chnaif did you review the offending PR? I didn't see a ✅ next to your name. Asking cuz, if you reviewed that PR and it caused this regression, you wouldn't get paid (unless it was outside of the regression time)
^ Test case created
aimane-chnaif commentedon Jan 10, 2026
@mallenexpensify It looks as if I reviewed #78062 (offending PR) just because I commented on the offending line for BZ Checklist. Not involved at all.
You can see timeline:
melvin-bot commentedon Jan 13, 2026
@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
mallenexpensify commentedon Jan 14, 2026
Thanks @aimane-chnaif , we sh ould be good to close then
aimane-chnaif commentedon Jan 14, 2026
@mallenexpensify I haven't received payment yet.
mallenexpensify commentedon Jan 15, 2026
@aimane-chnaif , updated payment summary.
I was confused cuz I missed 'offending PR' in your comment and was thinking of the PR from this issue, sorry.
aimane-chnaif commentedon Jan 27, 2026
@mallenexpensify can you please reopen? I am using upwork and payment still pending
mallenexpensify commentedon Jan 27, 2026
Sorry @aimane-chnaif , paid, summary updated above.