You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-01-05] Wallet - When sharing bank account, selected user is not marked as selected in the search result #78366
Version Number: 9.2.86-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#73427 Email or phone of affected tester (no customers):applausetester+sdj0mssjsdidnd1@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Mac 26.1 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Workspace is set up with bank account.
Workspace has at least 13 admins.
Perform the action below as workspace owner:
Go to staging.new.expensify.com
Go to Profile > Wallet.
Click 3-dot menu on the bank account > Share.
Search for a user and select the user.
Search for the same user.
Expected Result:
The selected user will be marked as selected in the search result.
Actual Result:
The selected user is not marked as selected in the search result.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
What changes do you think we should make in order to solve the problem?
We should pass isSelected as isSelected: selectedOptions.some((selectedOption) => selectedOption.login === admin.login)
// Apply search filter if there's a search termif(debouncedSearchTerm){constsearchValue=getSearchValueForPhoneOrEmail(debouncedSearchTerm,countryCode).toLowerCase();adminsToDisplay=tokenizedSearch(admins,searchValue,(option)=>[option.text??'',option.alternateText??'']).map((admin)=>({
...admin,isSelected: selectedOptions.some((selectedOption)=>selectedOption.login===admin.login),}));}
What alternative solutions did you explore? (Optional)
n/A
Result
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Wallet - When sharing bank account, selected user is not marked as selected in the search result[/-][+][Due for payment 2026-01-05] Wallet - When sharing bank account, selected user is not marked as selected in the search result[/+]on Dec 29, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.87-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@NikkiWines@bfitzexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Dec 23, 2025
You have been assigned to this deploy blocker because you recently merged this PR: #73427
melvin-bot commentedon Dec 23, 2025
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Dec 23, 2025
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Dec 23, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
situchan commentedon Dec 23, 2025
joekaufmanexpensify commentedon Dec 23, 2025
discussing
PiyushChandra17 commentedon Dec 23, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Wallet - When sharing bank account, selected user is not marked as selected in the search result
What is the root cause of that problem?
We are not checking
isSelectedhereWhat changes do you think we should make in order to solve the problem?
isSelectedasisSelected: selectedOptions.some((selectedOption) => selectedOption.login === admin.login)What alternative solutions did you explore? (Optional)
n/A
Result
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
NikkiWines commentedon Dec 23, 2025
I think we can simply pass
adminsToDisplayinstead ofadminshere so the search filter preserves theisSelectedstate.m-natarajan commentedon Dec 23, 2025
Issue is not reproducible on Windows 11/ Chrome in v9.2.86-2
78366.mp4
NikkiWines commentedon Dec 23, 2025
Great, thank you! Closing this
[-]Wallet - When sharing bank account, selected user is not marked as selected in the search result[/-][+][Due for payment 2026-01-05] Wallet - When sharing bank account, selected user is not marked as selected in the search result[/+]melvin-bot commentedon Dec 29, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Dec 29, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.87-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-01-05. 🎊
melvin-bot commentedon Dec 29, 2025
@NikkiWines @bfitzexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]