Skip to content

[Due for payment 2026-01-05] Wallet - When sharing bank account, selected user is not marked as selected in the search result #78366

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.86-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #73427
Email or phone of affected tester (no customers): applausetester+sdj0mssjsdidnd1@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Mac 26.1 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Workspace is set up with bank account.
  • Workspace has at least 13 admins.
  • Perform the action below as workspace owner:
  1. Go to staging.new.expensify.com
  2. Go to Profile > Wallet.
  3. Click 3-dot menu on the bank account > Share.
  4. Search for a user and select the user.
  5. Search for the same user.

Expected Result:

The selected user will be marked as selected in the search result.

Actual Result:

The selected user is not marked as selected in the search result.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @bfitzexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 23, 2025
  2. melvin-bot commented on Dec 23, 2025

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #73427

  3. melvin-bot commented on Dec 23, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Dec 23, 2025

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Dec 23, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. situchan commented on Dec 23, 2025

    @situchan
  7. joekaufmanexpensify commented on Dec 23, 2025

    @joekaufmanexpensify
    Contributor
  8. PiyushChandra17 commented on Dec 23, 2025

    @PiyushChandra17
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Wallet - When sharing bank account, selected user is not marked as selected in the search result

    What is the root cause of that problem?

    We are not checking isSelected here

    What changes do you think we should make in order to solve the problem?

    1. We should pass isSelected as isSelected: selectedOptions.some((selectedOption) => selectedOption.login === admin.login)
    // Apply search filter if there's a search term
    if (debouncedSearchTerm) {
        const searchValue = getSearchValueForPhoneOrEmail(debouncedSearchTerm, countryCode).toLowerCase();
        adminsToDisplay = tokenizedSearch(admins, searchValue, (option) => [option.text ?? '', option.alternateText ?? '']).map((admin) => ({
            ...admin,
            isSelected: selectedOptions.some((selectedOption) => selectedOption.login === admin.login),
        }));
    }

    What alternative solutions did you explore? (Optional)

    n/A

    Result

    Image

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  9. NikkiWines commented on Dec 23, 2025

    @NikkiWines
    Contributor

    I think we can simply pass adminsToDisplay instead of admins here so the search filter preserves the isSelected state.

  10. m-natarajan commented on Dec 23, 2025

    @m-natarajan

    Issue is not reproducible on Windows 11/ Chrome in v9.2.86-2

    78366.mp4
  11. NikkiWines commented on Dec 23, 2025

    @NikkiWines
    Contributor

    Great, thank you! Closing this

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Dec 29, 2025
  13. changed the title [-]Wallet - When sharing bank account, selected user is not marked as selected in the search result[/-] [+][Due for payment 2026-01-05] Wallet - When sharing bank account, selected user is not marked as selected in the search result[/+] on Dec 29, 2025
  14. melvin-bot commented on Dec 29, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Dec 29, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.2.87-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-01-05. 🎊

  16. melvin-bot commented on Dec 29, 2025

    @melvin-bot

    @NikkiWines @bfitzexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions