Skip to content

The margin between ToS checkbox and its error message is way more than the other fields - reported by @adeel0202 #7838

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to Settings > Payments > Add Payment method > Debit card
  2. Press Save without filling the form

Expected Result:

The ToS checkbox and its error message should have the same margin as other fields and their error messages

Actual Result:

The margin between ToS checkbox and its error message is way more than the other fields and their error messages

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.39-1
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Simulator Screen Shot - iPhone 13 - 2022-02-07 at 12 58 21

Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1644254987542729

View all open jobs on GitHub

view this job

Activity

  1. MelvinBot commented on Feb 20, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @CortneyOfstad (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Feb 20, 2022
  3. adeel0202 commented on Feb 20, 2022

    @adeel0202
    Contributor

    Proposal (If considered external)

    We can remove the margin below the checkbox by removing styles.mb4 on line 307

    style={[styles.mt4, styles.mb4]}

    Result
    Simulator Screen Shot - iPhone 13 - 2022-02-14 at 16 24 03

  4. CortneyOfstad commented on Feb 21, 2022

    @CortneyOfstad
    Contributor

    Sorry, was out last week sick — updating now!

  5. removed their assignment
    on Feb 21, 2022
  6. MelvinBot commented on Feb 21, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @PauloGasparSv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 22, 2022
  8. MelvinBot commented on Feb 22, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  9. 30 remaining items

  10. adeel0202 commented on Mar 4, 2022

    @adeel0202
    Contributor

    @parasharrajat, just checked that we don't need to make any changes in ACHContractStep. There is bottom margin in the top two checkboxes of that component and those are necessary margins so can't remove those.

    Screenshot 2022-03-04 at 1 04 10 PM

    Also, can you please let me the know the url to access TermsStep directly?
    cc: @luacmartins

  11. parasharrajat commented on Mar 4, 2022

    @parasharrajat
    Member

    try any of these keyboards in the URL based on the step you are looking.

            case 'new':
                    return CONST.BANK_ACCOUNT.STEP.BANK_ACCOUNT;
                case 'company':
                    return CONST.BANK_ACCOUNT.STEP.COMPANY;
                case 'personal-information':
                    return CONST.BANK_ACCOUNT.STEP.REQUESTOR;
                case 'contract':
                    return CONST.BANK_ACCOUNT.STEP.ACH_CONTRACT;
                case 'validate':
                    return CONST.BANK_ACCOUNT.STEP.VALIDATION;
                case 'enable':
                    return CONST.BANK_ACCOUNT.STEP.ENABLE;
                default:
                    return '';
            }
  12. adeel0202 commented on Mar 4, 2022

    @adeel0202
    Contributor

    Thanks @parasharrajat, I have already tried all those in the URL but no luck. I have also managed to add a test bank account on staging (thanks to this slack thread), went through all the steps but still couldn't access TermsStep component 😐

  13. luacmartins commented on Mar 4, 2022

    @luacmartins
    Contributor

    I'd hard-code currentStep here to show termsStep for testing purposes and navigate to /settings/payments/enable-payments. You can find these routes in linkingConfig.js.

    The other alternative is to go through the Onfido flow, which might be problematic.

  14. adeel0202 commented on Mar 7, 2022

    @adeel0202
    Contributor

    I have raised the PR, but just to inform, I'm still not hired on Upwork for this job 😄

  15. adeel0202 commented on Mar 24, 2022

    @adeel0202
    Contributor

    The PR was deployed on production 8 days ago so this should be paid by now but I'm not even hired on Upwork yet. What is going on here? 👀😄
    cc: @luacmartins

  16. luacmartins commented on Mar 24, 2022

    @luacmartins
    Contributor

    Pinging @jboniface for payment.

  17. jboniface commented on Mar 24, 2022

    @jboniface

    @adeel0202 sorry, it looks like the original post expired. can you apply here?

  18. adeel0202 commented on Mar 24, 2022

    @adeel0202
    Contributor

    Thanks @jboniface, I have applied on Upwork.

  19. jboniface commented on Mar 24, 2022

    @jboniface

    paid with bonus

  20. parasharrajat commented on Mar 24, 2022

    @parasharrajat
    Member

    @jboniface I have also applied for C+.

  21. jboniface commented on Mar 24, 2022

    @jboniface

    yeah, i saw, i've been trying to pay it but upwork is erroring for some reason @parasharrajat

  22. jboniface commented on Mar 24, 2022

    @jboniface

    ok, should be all set now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions