You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
The margin between ToS checkbox and its error message is way more than the other fields - reported by @adeel0202 #7838
@parasharrajat, just checked that we don't need to make any changes in ACHContractStep. There is bottom margin in the top two checkboxes of that component and those are necessary margins so can't remove those.
Also, can you please let me the know the url to access TermsStep directly?
cc: @luacmartins
Thanks @parasharrajat, I have already tried all those in the URL but no luck. I have also managed to add a test bank account on staging (thanks to this slack thread), went through all the steps but still couldn't access TermsStep component 😐
I'd hard-code currentStephere to show termsStep for testing purposes and navigate to /settings/payments/enable-payments. You can find these routes in linkingConfig.js.
The other alternative is to go through the Onfido flow, which might be problematic.
The PR was deployed on production 8 days ago so this should be paid by now but I'm not even hired on Upwork yet. What is going on here? 👀😄
cc: @luacmartins
Activity
MelvinBot commentedon Feb 20, 2022
Triggered auto assignment to @CortneyOfstad (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.adeel0202 commentedon Feb 20, 2022
Proposal (If considered external)
We can remove the margin below the checkbox by removing
styles.mb4online 307App/src/pages/settings/Payments/AddDebitCardPage.js
Line 307 in d9355db
Result

CortneyOfstad commentedon Feb 21, 2022
Sorry, was out last week sick — updating now!
MelvinBot commentedon Feb 21, 2022
Triggered auto assignment to @PauloGasparSv (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.MelvinBot commentedon Feb 22, 2022
Triggered auto assignment to @jliexpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.30 remaining items
adeel0202 commentedon Mar 4, 2022
@parasharrajat, just checked that we don't need to make any changes in
ACHContractStep. There is bottom margin in the top two checkboxes of that component and those are necessary margins so can't remove those.Also, can you please let me the know the url to access
TermsStepdirectly?cc: @luacmartins
parasharrajat commentedon Mar 4, 2022
try any of these keyboards in the URL based on the step you are looking.
adeel0202 commentedon Mar 4, 2022
Thanks @parasharrajat, I have already tried all those in the URL but no luck. I have also managed to add a test bank account on staging (thanks to this slack thread), went through all the steps but still couldn't access
TermsStepcomponent 😐luacmartins commentedon Mar 4, 2022
I'd hard-code
currentStephere to showtermsStepfor testing purposes and navigate to/settings/payments/enable-payments. You can find these routes in linkingConfig.js.The other alternative is to go through the Onfido flow, which might be problematic.
adeel0202 commentedon Mar 7, 2022
I have raised the PR, but just to inform, I'm still not hired on Upwork for this job 😄
adeel0202 commentedon Mar 24, 2022
The PR was deployed on production 8 days ago so this should be paid by now but I'm not even hired on Upwork yet. What is going on here? 👀😄
cc: @luacmartins
luacmartins commentedon Mar 24, 2022
Pinging @jboniface for payment.
jboniface commentedon Mar 24, 2022
@adeel0202 sorry, it looks like the original post expired. can you apply here?
adeel0202 commentedon Mar 24, 2022
Thanks @jboniface, I have applied on Upwork.
jboniface commentedon Mar 24, 2022
paid with bonus
parasharrajat commentedon Mar 24, 2022
@jboniface I have also applied for C+.
jboniface commentedon Mar 24, 2022
yeah, i saw, i've been trying to pay it but upwork is erroring for some reason @parasharrajat
jboniface commentedon Mar 24, 2022
ok, should be all set now