Skip to content

[HOLD for payment 2022-03-24] Feature Request: Add workspace name as subtitle in individual modal screens - reported by @mananjadhav #7840

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Create workspace
  2. Navigate to Settings and click through different screens (such as "Reimburse receipts", "Pay bills", "Manage members", etc.)

Expected Result:

Add workspace name in the subtitle on settings.

Actual Result:

No workspace name currently shows.
To verify if the user is on the correct workspace, he/she will have to go back to the previous screen to see the workspace name. It'll be better if we show the workspace name in the header of the modal itself.

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.39-1
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
without-workspace-name
with-workspace-name
Expensify/Expensify Issue URL:
Issue reported by: @mananjadhav
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1644267323975329

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Feb 20, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @SofiedeVreese (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Feb 20, 2022
  3. mananjadhav commented on Feb 20, 2022

    @mananjadhav
    Collaborator

    Writing a quick proposal as I posted this feature request.

    In WorkspacePageWithSections, we pass workspace name to the subtitle Prop of HeaderWithCloseButton here

    https://github.com/stardev115/Expensify/blob/9d6e07a0d3bb298d7edba16824efb95afc94f280/src/pages/workspace/WorkspacePageWithSections.js#L75

  4. MelvinBot commented on Feb 20, 2022

    @MelvinBot
    Contributor

    Triggered auto assignment to @Luke9389 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  5. SofiedeVreese commented on Feb 20, 2022

    @SofiedeVreese
    Contributor

    Issue LGTM, adding Engineering.

  6. SofiedeVreese commented on Feb 20, 2022

    @SofiedeVreese
    Contributor

    Whoops, adding Luke back in, Melvinbot accidentally removed us both when I only wanted to remove my assignment.

  7. 32 remaining items

  8. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 11, 2022
  9. dylanexpensify commented on Mar 11, 2022

    @dylanexpensify
    Contributor

    @rushatgabhane @mollfpr @mananjadhav sent you each an offer in Upwork!

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 17, 2022
  11. changed the title [-]Feature Request: Add workspace name as subtitle in individual modal screens - reported by @mananjadhav[/-] [+][HOLD for payment 2022-03-24] Feature Request: Add workspace name as subtitle in individual modal screens - reported by @mananjadhav[/+] on Mar 17, 2022
  12. botify commented on Mar 17, 2022

    @botify

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.43-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-03-24. 🎊

  13. dylanexpensify commented on Mar 24, 2022

    @dylanexpensify
    Contributor

    Payments sent, contracts ended, posting closed! Thanks for playing y'all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions