You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-09] [$250] Expense-Rejected expense moved to original report shows rejected expense violation #78578
// Remove AUTO_REPORTED_REJECTED_EXPENSE violation when the submitter edits the expense or when the transaction is moved to a different report
if (shouldRemoveRejectedExpenseViolation || (iouReport && isFromExpenseReport && isCurrentUserSubmitter(iouReport))) {
, we could remove all autoReportedRejectedExpense violations associated with the relevant transactionIDs.
This removal could be done either unconditionally, or conditionally only when the transaction is being moved to a processing (or otherwise non-draft) report.
The removal logic could be implemented either inside or outside of getViolationsOnyxData.
The code changes themselves would be relatively simple: use hasTransactionBeenRejected to check whether the transaction has already been rejected, and isProcessingReport to determine whether the target report is in a processing state.
changed the title [-]Expense-Rejected expense moved to original report shows rejected expense violation[/-][+][$250] Expense-Rejected expense moved to original report shows rejected expense violation[/+]on Jan 1, 2026
Activity
melvin-bot commentedon Dec 30, 2025
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.truph01 commentedon Dec 30, 2025
🚨 Edited by proposal-police: This proposal was edited at 2026-02-18 11:06:46 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
App/src/libs/ReportUtils.ts
Line 12713 in 6aacf44
What changes do you think we should make in order to solve the problem?
App/src/libs/Violations/ViolationsUtils.ts
Line 287 in c835e8d
then use it in
App/src/libs/Violations/ViolationsUtils.ts
Line 313 in c835e8d
Finally, in here
App/src/libs/actions/Transaction.ts
Lines 1027 to 1029 in c835e8d
true.This also needs the fix in BE side so that it will always clean up the rejected violation once the transaction is moving to another report.
What alternative solutions did you explore? (Optional)
In the violation calculation step at
App/src/libs/actions/Transaction.ts
Lines 923 to 970 in 6aacf44
autoReportedRejectedExpenseviolations associated with the relevanttransactionIDs.This removal could be done either unconditionally, or conditionally only when the transaction is being moved to a processing (or otherwise non-draft) report.
The removal logic could be implemented either inside or outside of
getViolationsOnyxData.The code changes themselves would be relatively simple: use
hasTransactionBeenRejectedto check whether the transaction has already been rejected, andisProcessingReportto determine whether the target report is in a processing state.[-]Expense-Rejected expense moved to original report shows rejected expense violation[/-][+][$250] Expense-Rejected expense moved to original report shows rejected expense violation[/+]melvin-bot commentedon Jan 1, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022006649158407191442
melvin-bot commentedon Jan 1, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (
External)garrettmknight commentedon Jan 8, 2026
This is expected behavior, the user hasn't changed any details of the expense or marked the rejection as resolved.
garrettmknight commentedon Jan 8, 2026
Just checked the linked test case and it doesn't describe this flow, closing.
119 remaining items
melvin-bot commentedon Jun 8, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Jun 8, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
melvin-bot commentedon Jun 11, 2026
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Jun 15, 2026
@mallenexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
huult commentedon Jun 16, 2026
cc @mallenexpensify
mallenexpensify commentedon Jun 16, 2026
Payment Summary
Contributor: @truph01 due $250 via NewDot
Contributor+: @huult due $250 via NewDot
^ Test case created. Thx
Apologies for the delay.
JmillsExpensify commentedon Jun 29, 2026
$250 approved for @huult
garrettmknight commentedon Jul 28, 2026
$250 approved for @truph01