You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-01-23] [$250] Travel - User without verification can trigger “Request Sent” state on Travel page #78750
Version Number: v9.2.90-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/test-runs/TR-2597/folder/13177079/41237920/1101375175 Email or phone of affected tester (no customers):luongvu92@private.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Windows 10/Chrome App Component: Workspace Settings
Action Performed:
Sign up for a new account in NewDot with a private domain account (Don't validate the account)
Finish the onboarding with 1-10 members
Navigate to the Workspace features
Toggle on the Travel
Click on the Travel -> Let's Go button
Click back on the RHP without entering the magic code
Expected Result:
The Let's go button is in the same status because the account isn't verified yet
Actual Result:
The Let's go button changed status to Request sent
Please re-state the problem that we are trying to solve in this issue.
When a user without account verification clicks "Let's Go" on the Travel page, navigates to the verification page, then clicks back without entering the magic code, the button state incorrectly changes to "Request Sent".
What is the root cause of that problem?
The handleClose callback in VerifyAccountPage.tsx unconditionally calls requestTravelAccess() when the page closes, regardless of whether the user actually completed verification.
Root Cause Flow Analysis
User clicks "Let's Go" button which triggers bookATrip():
The problem is that handleClose is called both when user dismisses/goes back AND when they successfully validate, but it doesn't distinguish between these two cases.
What changes do you think we should make in order to solve the problem?
Add an onValidationSuccess callback prop to VerifyAccountPageBase that is called ONLY when the user successfully validates their account. This separates the success path from the dismiss/back path.
Solution
Add onValidationSuccess prop to VerifyAccountPageBase:
Please re-state the problem that we are trying to solve in this issue.
Travel - User without verification can trigger “Request Sent” state on Travel page.
What is the root cause of that problem?
The Travel verify account page always calls requestTravelAccess when the user closes the OTP flow, no matter whether the account is validated. That writes lastTravelSignupRequestTime and moves the workspace into the “Reviewing request” state.
What changes do you think we should make in order to solve the problem?
Read the account record inside the Travel verify page and gate the close handler so we only call requestTravelAccess after the account is validated. This keeps the CTA as “Let’s go” until the user finishes OTP.
changed the title [-]Travel - User without verification can trigger “Request Sent” state on Travel page[/-][+][$250] Travel - User without verification can trigger “Request Sent” state on Travel page[/+]on Jan 1, 2026
What changes do you think we should make in order to solve the problem?
Remove the requestTravelAccess call from handleClose. If the user verifies, VerifyAccountPageBase navigates forward (handled by its useEffect). If the user goes back without verifying, we should not set the request time
Then we can add a useEffect that watches for successful verification and sends the request when the user becomes validated (only when the beta is disabled)
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.3-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@situchan@bfitzexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Sign up for a new account in NewDot with a private domain account (Don't validate the account)
Finish the onboarding with 1-10 members
Navigate to the Workspace features
Toggle on the Travel
Click on the Travel -> Let's Go button
Click back on the RHP without entering the magic code
Verify the Let's go button is in the same status because the account isn't verified yet
Activity
melvin-bot commentedon Jan 1, 2026
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.TaduJR commentedon Jan 1, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user without account verification clicks "Let's Go" on the Travel page, navigates to the verification page, then clicks back without entering the magic code, the button state incorrectly changes to "Request Sent".
What is the root cause of that problem?
The
handleClosecallback inVerifyAccountPage.tsxunconditionally callsrequestTravelAccess()when the page closes, regardless of whether the user actually completed verification.Root Cause Flow Analysis
bookATrip():App/src/components/BookTravelButton.tsx
Lines 120 to 124 in 66de3d6
VerifyAccountPage:App/src/pages/Travel/VerifyAccountPage.tsx
Lines 16 to 46 in 66de3d6
handleClosecallback unconditionally callsrequestTravelAccess():App/src/pages/Travel/VerifyAccountPage.tsx
Lines 32 to 35 in 66de3d6
handleCloseWithFallbacktriggers the customhandleClose:App/src/pages/settings/VerifyAccountPageBase.tsx
Lines 44 to 50 in 66de3d6
requestTravelAccess()setslastTravelSignupRequestTimein Onyx:App/src/libs/actions/Travel.ts
Lines 52 to 65 in 66de3d6
getTravelStep()returnsREVIEWING_REQUESTwhenlastTravelSignupRequestTimeexists:App/src/libs/PolicyUtils.ts
Lines 1683 to 1685 in 66de3d6
The problem is that
handleCloseis called both when user dismisses/goes back AND when they successfully validate, but it doesn't distinguish between these two cases.What changes do you think we should make in order to solve the problem?
Add an
onValidationSuccesscallback prop toVerifyAccountPageBasethat is called ONLY when the user successfully validates their account. This separates the success path from the dismiss/back path.Solution
onValidationSuccessprop toVerifyAccountPageBase:App/src/pages/settings/VerifyAccountPageBase.tsx
Line 17 in 66de3d6
onValidationSuccessin the validation useEffect before navigation:App/src/pages/settings/VerifyAccountPageBase.tsx
Lines 53 to 62 in 66de3d6
useEffect(() => { if (!isUserValidated) { return; } + // Call the success callback ONLY when user successfully validates + onValidationSuccess?.(); + if (navigateForwardTo) { Navigation.navigate(navigateForwardTo, {forceReplace: true}); } else { handleCloseWithFallback(); } -}, [isUserValidated, navigateForwardTo, handleCloseWithFallback, handleClose]); +}, [isUserValidated, navigateForwardTo, handleCloseWithFallback, handleClose, onValidationSuccess]);VerifyAccountPage.tsxto useonValidationSuccessand removerequestTravelAccess()fromhandleClose:App/src/pages/Travel/VerifyAccountPage.tsx
Lines 32 to 35 in 66de3d6
This ensures:
handleClose→ navigation only (dismiss/back)onValidationSuccess→ business logic triggered on actual validation successShridharGoel commentedon Jan 1, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
Travel - User without verification can trigger “Request Sent” state on Travel page.
What is the root cause of that problem?
The Travel verify account page always calls
requestTravelAccesswhen the user closes the OTP flow, no matter whether the account is validated. That writeslastTravelSignupRequestTimeand moves the workspace into the “Reviewing request” state.App/src/pages/Travel/VerifyAccountPage.tsx
Lines 16 to 35 in 66de3d6
What changes do you think we should make in order to solve the problem?
requestTravelAccessafter the account is validated. This keeps the CTA as “Let’s go” until the user finishes OTP.Updated code snippet:
[-]Travel - User without verification can trigger “Request Sent” state on Travel page[/-][+][$250] Travel - User without verification can trigger “Request Sent” state on Travel page[/+]melvin-bot commentedon Jan 1, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022006670805403073426
melvin-bot commentedon Jan 1, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (
External)nyomanjyotisa commentedon Jan 1, 2026
🚨 Edited by proposal-police: This proposal was edited at 2026-01-01 11:18:22 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Travel - User without verification can trigger "Request Sent" state on Travel page
What is the root cause of that problem?
handleClosecallsrequestTravelAccesswhen the user navigates backApp/src/pages/Travel/VerifyAccountPage.tsx
Lines 32 to 35 in 66de3d6
This sets
lastTravelSignupRequestTimewhich then causesgetTravelStepto return theREVIEWING_REQUESTstepApp/src/libs/PolicyUtils.ts
Lines 1685 to 1686 in 66de3d6
The request should only be sent when the user is validated and clicks the button, which is already handled in
BookTravelButtonApp/src/components/BookTravelButton.tsx
Lines 128 to 130 in 66de3d6
What changes do you think we should make in order to solve the problem?
Remove the
requestTravelAccesscall fromhandleClose. If the user verifies,VerifyAccountPageBasenavigates forward (handled by itsuseEffect). If the user goes back without verifying, we should not set the request timeApp/src/pages/Travel/VerifyAccountPage.tsx
Lines 32 to 35 in 66de3d6
Then we can add a
useEffectthat watches for successful verification and sends the request when the user becomes validated (only when the beta is disabled)What alternative solutions did you explore? (Optional)
We could check
isUserValidatedinhandleClosebefore callingrequestTravelAccess28 remaining items
melvin-bot commentedon Jan 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.3-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-01-23. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 16, 2026
@situchan @bfitzexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
bfitzexpensify commentedon Jan 20, 2026
Payment on Friday
bfitzexpensify commentedon Jan 26, 2026
Payment summary:
@situchan owed $250 via Upwork - paid ✅
@TaduJR owed $250 via Upwork - paid ✅
bfitzexpensify commentedon Jan 26, 2026
@situchan please complete the BZ checklist
TaduJR commentedon Jan 26, 2026
Offer Accepted @bfitzexpensify
Thanks!
situchan commentedon Jan 26, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/71630/changes#r2726699129
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎