You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-01-29] [$250] Report - Total amount shown as "0,00" when splitting expense offline after currency change #78814
Version Number: 9.2.91-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/test-runs/TR-2626/folder/13176791/41237176/1103226528 Email or phone of affected tester (no customers):ibellicotest+2250@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Motorola MotoG60 / Android 12 / Chrome (Hybrid app) - Windows 11 / Chrome App Component: Money Requests
Action Performed:
Prerequisite: Account has at least one workspace.
Prerequisite 2: Default currency is not USD.
Open the staging.new.expensify.com website.
Open any workspace chat.
Create a manual expense.
Open the just created expense.
Tap on "Amount" field.
Edit the currency to "USD"
Return to report.
Turn off internet connection.
Tap on "More" > "Split"
Save the splits amount
Once redirected to report, note that total amount above expenses is shown as "0,00".
Expected Result:
After splitting an expense, amount on report should still show the correct total of all the expenses.
Actual Result:
After splitting expenses while in offline mode, total amount is displayed as "0,00" if expense currency was previously changed.
When splitting, the original transaction's convertedAmount is completely discarded. This was intentionally done to fix issue #76078 (doubled totals), but it removes crucial currency conversion data needed for subtotal calculations.
2. calculateGroupTotal skips transactions without convertedAmount when currencies differ:
if (isSplitExpense && existingTransaction) {
- const {convertedAmount: omittedConvertedAmount, ...existingTransactionWithoutConvertedAmount} = existingTransaction;+ const {convertedAmount: originalConvertedAmount, ...existingTransactionWithoutConvertedAmount} = existingTransaction;
optimisticTransaction = fastMerge(existingTransactionWithoutConvertedAmount, optimisticTransaction, false);
++ // Calculate proportional convertedAmount for the split based on the original conversion rate+ const originalAmount = existingTransaction.modifiedAmount ?? existingTransaction.amount;+ const splitAmount = optimisticTransaction.modifiedAmount ?? optimisticTransaction.amount;+ if (originalConvertedAmount && originalAmount && splitAmount) {+ optimisticTransaction.convertedAmount = Math.round((originalConvertedAmount * splitAmount) / originalAmount);+ }
}
This preserves the exchange rate from the original transaction and applies it proportionally to each split, ensuring subtotals display correctly in the report currency.
changed the title [-]Report - Total amount shown as "0,00" when splitting expense offline after currency change[/-][+][$250] Report - Total amount shown as "0,00" when splitting expense offline after currency change[/+]on Jan 6, 2026
Please re-state the problem that we are trying to solve in this issue.
When a user edits the currency of an expense and then creates split transactions while offline, the report totals become incorrect. This happens because the conversion from the expense currency to the report currency is not available locally, so the locally-created splits cannot correctly calculate their convertedAmount.
What is the root cause of that problem?
The server-provided report-currency conversion is not cached on the original transaction. When offline split transactions are created, there is no reliable rate to compute convertedAmount, leading to mismatched report totals.
What changes do you think we should make in order to solve the problem?
We propose caching the last known report-currency conversion on the original transaction and reusing it when creating offline split transactions:
Cache conversion metadata on currency/amount edit
In updateMoneyRequestAmountAndCurrency (src/libs/actions/IOU/index.ts):
changed the title [-][$250] Report - Total amount shown as "0,00" when splitting expense offline after currency change[/-][+][Due for payment 2026-01-29] [$250] Report - Total amount shown as "0,00" when splitting expense offline after currency change[/+]on Jan 22, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.6-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@suneox@sonialiap The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
N/A: It isn't an impactful bug since it only affects optimistic data
Activity
melvin-bot commentedon Jan 3, 2026
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.TaduJR commentedon Jan 3, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When splitting an expense offline after changing its currency, the category subtotal displays as "0,00" instead of the correct amount.
What is the root cause of that problem?
The root cause is a two-part issue in the split expense flow:
1.
convertedAmountis omitted when creating split transactions:App/src/libs/actions/IOU/index.ts
Lines 3711 to 3714 in 66de3d6
When splitting, the original transaction's
convertedAmountis completely discarded. This was intentionally done to fix issue #76078 (doubled totals), but it removes crucial currency conversion data needed for subtotal calculations.2.
calculateGroupTotalskips transactions withoutconvertedAmountwhen currencies differ:App/src/libs/ReportLayoutUtils.ts
Lines 37 to 52 in 66de3d6
When
transactionCurrency !== reportCurrencyandconvertedAmountis undefined, the transaction is skipped entirely, resulting in a total of 0.Root Cause Flow:
convertedAmount(USD value in EUR)App/src/libs/actions/IOU/index.ts
Lines 3711 to 3714 in 66de3d6
convertedAmountis omitted, split transactions havecurrency: USD,convertedAmount: undefinedcalculateGroupTotal:App/src/libs/ReportLayoutUtils.ts
Lines 44 to 49 in 66de3d6
transactionCurrency(USD) !==reportCurrency(EUR) - first condition failstransaction.convertedAmountis undefined - second condition failsWhat changes do you think we should make in order to solve the problem?
Instead of completely discarding
convertedAmount, calculate a proportional value for each split transaction based on the original conversion rate.File:
src/libs/actions/IOU/index.tsLocation:
App/src/libs/actions/IOU/index.ts
Lines 3711 to 3714 in 66de3d6
Change:
if (isSplitExpense && existingTransaction) { - const {convertedAmount: omittedConvertedAmount, ...existingTransactionWithoutConvertedAmount} = existingTransaction; + const {convertedAmount: originalConvertedAmount, ...existingTransactionWithoutConvertedAmount} = existingTransaction; optimisticTransaction = fastMerge(existingTransactionWithoutConvertedAmount, optimisticTransaction, false); + + // Calculate proportional convertedAmount for the split based on the original conversion rate + const originalAmount = existingTransaction.modifiedAmount ?? existingTransaction.amount; + const splitAmount = optimisticTransaction.modifiedAmount ?? optimisticTransaction.amount; + if (originalConvertedAmount && originalAmount && splitAmount) { + optimisticTransaction.convertedAmount = Math.round((originalConvertedAmount * splitAmount) / originalAmount); + } }This preserves the exchange rate from the original transaction and applies it proportionally to each split, ensuring subtotals display correctly in the report currency.
[-]Report - Total amount shown as "0,00" when splitting expense offline after currency change[/-][+][$250] Report - Total amount shown as "0,00" when splitting expense offline after currency change[/+]melvin-bot commentedon Jan 6, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022008463684077245289
melvin-bot commentedon Jan 6, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (
External)twinkle-react commentedon Jan 6, 2026
**Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user edits the currency of an expense and then creates split transactions while offline, the report totals become incorrect. This happens because the conversion from the expense currency to the report currency is not available locally, so the locally-created splits cannot correctly calculate their
convertedAmount.What is the root cause of that problem?
The server-provided report-currency conversion is not cached on the original transaction. When offline split transactions are created, there is no reliable rate to compute
convertedAmount, leading to mismatched report totals.What changes do you think we should make in order to solve the problem?
We propose caching the last known report-currency conversion on the original transaction and reusing it when creating offline split transactions:
Cache conversion metadata on currency/amount edit
In
updateMoneyRequestAmountAndCurrency(src/libs/actions/IOU/index.ts):Merge these fields into the transaction Onyx entry so they persist offline.
Apply cached conversion to optimistic split transactions
In
updateSplitTransactions(src/libs/actions/IOU/index.ts):Add typed fields and helper
Extend the
Transactiontype insrc/types/onyx/Transaction.ts:Optional accessor in
TransactionUtilsorIOU/index.ts:Rationale:
convertedAmountoffline.What alternative solutions did you explore? (Optional)
suneox commentedon Jan 7, 2026
Thank for all proposals! I'll take a look at this one today
18 remaining items
[-][$250] Report - Total amount shown as "0,00" when splitting expense offline after currency change[/-][+][Due for payment 2026-01-29] [$250] Report - Total amount shown as "0,00" when splitting expense offline after currency change[/+]melvin-bot commentedon Jan 22, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 22, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.6-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-01-29. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 22, 2026
@suneox @sonialiap The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
suneox commentedon Jan 28, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/76253/changes#r2737687626
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
N/A: It isn't an impactful bug since it only affects optimistic data
melvin-bot commentedon Jan 29, 2026
Payment Summary
Upwork Job
BugZero Checklist (@sonialiap)
sonialiap commentedon Feb 2, 2026
apologies for the delay! I was OOO
sonialiap commentedon Feb 2, 2026
Payment summary:
@suneox $250 please request in NewDot
@TaduJR $250 paid in upwork
trjExpensify commentedon Feb 3, 2026
approved $250 for @suneox.