You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for Payment 2026-04-09][$250] Cards-'Got it' button modal is not displayed in offline #79022
Version Number: V9.2.95 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#78824 Email or phone of affected tester (no customers):dreamnitethedragon+yydyd373@gmail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Redminote 10S Android 13 App Component: Workspace Settings
Action Performed:
Preconditions: Workspace has issued an Expensify card to the member
Launch app
Go offline
3.Navigate to the Workspace Overview
4.Click on the More button
5.Select the Delete option
6.Click on the Delete button
Expected Result:
Got it' button modal must be displayed in offline.
Actual Result:
'Got it' button modal is not displayed in offline.
Please re-state the problem that we are trying to solve in this issue.
When a user attempts to delete a workspace while offline, the "Got it" modal is not displayed. Instead, the code proceeds with the deletion API call, immediately closes the modal, and navigates back. Users are not informed that the action could not be completed due to connectivity issues, leading to confusion.
What is the root cause of that problem?
The confirmDelete function in WorkspaceOverviewPage.tsx does not handle offline scenarios properly. It calls the deletion API and closes the modal without checking if the user is offline. Unlike card assignment, there is no offline modal displayed before attempting deletion.
What changes do you think we should make in order to solve the problem?
Update confirmDelete to check for offline status before making the deletion API call.
If the user is offline, close the delete confirmation modal and open a dedicated offline modal with a "Got it" button (DecisionModal).
Add the necessary state variable isOfflineModalOpen to control visibility of the offline modal.
Ensure the navigation logic remains unchanged and no deletion API call is triggered while offline.
What changes do you think we should make in order to solve the problem?
We should add the validation before call DeleteWorkspace API in offline mode by using hasCardFeedOrExpensifyCard variable (Or we could create another variable to make it compatible with the logic in the back end.)
<ConfirmModal
title={translate('workspace.common.delete')}
isVisible={isDeleteWorkspaceWithCardsOfflineModalOpen}
onConfirm={() => setIsDeleteWorkspaceWithCardsOfflineModalOpen(false)}
onCancel={() => setIsDeleteWorkspaceWithCardsOfflineModalOpen(false)}
prompt={'Your company still has open Expensify Cards.'}
confirmText={translate('common.buttonConfirm')}
shouldShowCancelButton={false}
success={false}
/>
Note: we should do the same in WorkspaceListPage component
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Cards-'Got it' button modal is not displayed in offline[/-][+][$250] Cards-'Got it' button modal is not displayed in offline[/+]on Jan 11, 2026
Activity
melvin-bot commentedon Jan 7, 2026
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.twinkle-react commentedon Jan 7, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user attempts to delete a workspace while offline, the "Got it" modal is not displayed. Instead, the code proceeds with the deletion API call, immediately closes the modal, and navigates back. Users are not informed that the action could not be completed due to connectivity issues, leading to confusion.
What is the root cause of that problem?
The
confirmDeletefunction inWorkspaceOverviewPage.tsxdoes not handle offline scenarios properly. It calls the deletion API and closes the modal without checking if the user is offline. Unlike card assignment, there is no offline modal displayed before attempting deletion.What changes do you think we should make in order to solve the problem?
confirmDeleteto check for offline status before making the deletion API call.DecisionModal).isOfflineModalOpento control visibility of the offline modal.Code changes:
What alternative solutions did you explore? (Optional)
daledah commentedon Jan 7, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
'Got it' button modal is not displayed in offline.
What is the root cause of that problem?
We don't cover this modal in
WorkspaceOverviewPagein front end and still callDeleteWorkspaceAPI then get the errorApp/src/pages/workspace/WorkspaceOverviewPage.tsx
Lines 514 to 523 in c903674
What changes do you think we should make in order to solve the problem?
We should add the validation before call
DeleteWorkspaceAPI in offline mode by usinghasCardFeedOrExpensifyCardvariable (Or we could create another variable to make it compatible with the logic in the back end.)App/src/pages/workspace/WorkspaceOverviewPage.tsx
Line 290 in c903674
Note: we should do the same in
WorkspaceListPagecomponentWhat alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Cards-'Got it' button modal is not displayed in offline[/-][+][$250] Cards-'Got it' button modal is not displayed in offline[/+]melvin-bot commentedon Jan 11, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022010420267674347485
melvin-bot commentedon Jan 11, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (
External)36 remaining items
melvin-bot commentedon Apr 7, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)Pujan92 commentedon Apr 8, 2026
I would say this is a new change and not a bug so no checklist is needed
Regression Test Proposal
Preconditions: The workspace has issued an Expensify Card to the member.
mallenexpensify commentedon Apr 10, 2026
Payment Summary
Contributor: @huult due $250 via NewDot
Contributor+: @Pujan92 due $250 via NewDot
^ Test case created
Thx
twisterdotcom commentedon Apr 13, 2026
@huult has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-c39e-a9b3-2bd0-d3c3ff8d8ec4garrettmknight commentedon Apr 14, 2026
$250 approved for @Pujan92
JmillsExpensify commentedon Apr 30, 2026
$250 approved for @huult