Skip to content

[$250] Workflow - The removed second approver reappears after navigating back to edit approval page #79151

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.2.96-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #78350
Email or phone of affected tester (no customers): applausetester+bm1021@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Web, mweb, android
App Component: Workspace Settings

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Create a workspace and add three members(employee, approver A, approver B)
  3. Create an approval workflow where the employee submits to approver A, and approver B is the second approver
  4. Open the created workflow
  5. Click on Second Approver > Approver > deselect approver B > Save
  6. Click on Approver field > Save

Expected Result:

the second approver should remain removed

Actual Result:

After clicking Save in the first approver field and returning to the Edit Approval Workflow page, the removed second approver reappears.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7043985_1767904845437.bandicam_2026-01-08_23-26-14-466.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022010706674344890012
  • Upwork Job ID: 2010706674344890012
  • Last Price Increase: 2026-01-21
Issue OwnerCurrent Issue Owner: @

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 8, 2026
  2. melvin-bot commented on Jan 8, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #78350

  3. melvin-bot commented on Jan 8, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Jan 8, 2026

    @melvin-bot

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Jan 8, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. abzokhattab commented on Jan 8, 2026

    @abzokhattab
    Contributor

    I think its not caused by the changes we made. i am able to reproduce the same bug on prod:

    Screen.Recording.2026-01-08.at.22.13.39.mov

    what do u think? @JS00001 is it a blocker?

    that said i dont mind fixing it in a follow up PR

  7. JS00001 commented on Jan 9, 2026

    @JS00001
    Contributor

    @abzokhattab lets fix this, but since its on prod, its NAB right now

  8. removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 9, 2026
  9. 22 remaining items

  10. annaweber830 commented on Jan 19, 2026

    @annaweber830
    Contributor

    Hi @abzokhattab I updated my proposal

  11. abzokhattab commented on Jan 20, 2026

    @abzokhattab
    Contributor

    @annaweber830, This is still the same proposal as @nkdengineer which doesnt allow the auto add for approvers on edit ... we still want to allow that behaviour as mentioned in this comment #79151 (comment)

  12. nkdengineer commented on Jan 20, 2026

    @nkdengineer
    Contributor
  13. blazejkustra commented on Jan 20, 2026

    @blazejkustra
    Contributor

    The reported issue is not an actual bug and we are missing the real problem here. Let me unpack it!

    (I implemented the actual project in NewDot, that's why I know these details)

    1. Backend tracks a list of employees, each employee could have ONE approver and ONE other user that this user forwards all approved reports to
    2. Based on this frontend creates a graph of relations, for example:

    Such configuration:
    All workspace users approves to Default approver
    Default approver approves to Approver B
    Approver B forwards to Approver C

    Result in these workflows:
    ALL employees approver to Default approver
    Default approver approves to Approver B forwards to Approver C

    1. These relations are set in stone, and if you try to add Approver B to another workflow you will see that two approvers are added to the workflow because Approver B already forward to Approver C.
    QuickTime.movie.2.mov

    ☝️✅ THIS IS CORRECT

    1. The reported bug from this issue is not a real bug because Approver A is in relation with Approver B already. When user chooses Approver A in whatever workflow, it should be automatically filled out with the full relation (in this case Approver A -> Approver B, but it could be more approvers B -> C -> D -> and more)
    Image

    That said there is a real bug that was caused by @abzokhattab PR:

    • Go to a workflow with two approvers
    • Remove the second approver
    • Click on first approver
    • Click on approver again
    • DO NOT SAVE AND GO BACK
    • Second approver magically appears, which shouldn't happen as user did nothing (just opened approver and went back)
    QuickTime.movie.5.mov
  14. blazejkustra commented on Jan 20, 2026

    @blazejkustra
    Contributor

    I think we shouldn't fix the OP issue and instead focus on my findings as this is causing real problems for users on production

  15. melvin-bot commented on Jan 21, 2026

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  16. deleted a comment from melvin-bot on Jan 26, 2026
  17. greg-schroeder commented on Jan 26, 2026

    @greg-schroeder
    Contributor

    @JS00001 what do you think about the above?

  18. JS00001 commented on Jan 26, 2026

    @JS00001
    Contributor

    @blazejkustra 's comments make sense, @abzokhattab do you agree?

  19. abzokhattab commented on Jan 26, 2026

    @abzokhattab
    Contributor

    Yes, we fixed the issue @blazejkustra referred to. Given that the team decided the current behaviour is expected, we can close this one

  20. JS00001 commented on Jan 26, 2026

    @JS00001
    Contributor

    Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions