You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Workflow - The removed second approver reappears after navigating back to edit approval page #79151
Version Number: 9.2.96-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#78350 Email or phone of affected tester (no customers):applausetester+bm1021@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Web, mweb, android App Component: Workspace Settings
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@annaweber830, This is still the same proposal as @nkdengineer which doesnt allow the auto add for approvers on edit ... we still want to allow that behaviour as mentioned in this comment #79151 (comment)
The reported issue is not an actual bug and we are missing the real problem here. Let me unpack it!
(I implemented the actual project in NewDot, that's why I know these details)
Backend tracks a list of employees, each employee could have ONE approver and ONE other user that this user forwards all approved reports to
Based on this frontend creates a graph of relations, for example:
Such configuration: All workspace users approves to Default approver Default approver approves to Approver B Approver B forwards to Approver C
Result in these workflows: ALL employees approver to Default approver Default approver approves to Approver B forwards to Approver C
These relations are set in stone, and if you try to add Approver B to another workflow you will see that two approvers are added to the workflow because Approver B already forward to Approver C.
QuickTime.movie.2.mov
☝️✅ THIS IS CORRECT
The reported bug from this issue is not a real bug because Approver A is in relation with Approver B already. When user chooses Approver A in whatever workflow, it should be automatically filled out with the full relation (in this case Approver A -> Approver B, but it could be more approvers B -> C -> D -> and more)
That said there is a real bug that was caused by @abzokhattab PR:
Go to a workflow with two approvers
Remove the second approver
Click on first approver
Click on approver again
DO NOT SAVE AND GO BACK
Second approver magically appears, which shouldn't happen as user did nothing (just opened approver and went back)
Activity
melvin-bot commentedon Jan 8, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #78350
melvin-bot commentedon Jan 8, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Jan 8, 2026
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jan 8, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
abzokhattab commentedon Jan 8, 2026
I think its not caused by the changes we made. i am able to reproduce the same bug on prod:
Screen.Recording.2026-01-08.at.22.13.39.mov
what do u think? @JS00001 is it a blocker?
that said i dont mind fixing it in a follow up PR
JS00001 commentedon Jan 9, 2026
@abzokhattab lets fix this, but since its on prod, its NAB right now
22 remaining items
annaweber830 commentedon Jan 19, 2026
Hi @abzokhattab I updated my proposal
abzokhattab commentedon Jan 20, 2026
@annaweber830, This is still the same proposal as @nkdengineer which doesnt allow the auto add for approvers on edit ... we still want to allow that behaviour as mentioned in this comment #79151 (comment)
nkdengineer commentedon Jan 20, 2026
@abzokhattab Updated proposal.
blazejkustra commentedon Jan 20, 2026
The reported issue is not an actual bug and we are missing the real problem here. Let me unpack it!
(I implemented the actual project in NewDot, that's why I know these details)
Such configuration:
All workspace usersapproves toDefault approverDefault approverapproves toApprover BApprover Bforwards toApprover CResult in these workflows:
ALL employeesapprover toDefault approverDefault approverapproves toApprover Bforwards toApprover CApprover Bto another workflow you will see that two approvers are added to the workflow becauseApprover Balready forward toApprover C.QuickTime.movie.2.mov
☝️✅ THIS IS CORRECT
Approver Ais in relation withApprover Balready. When user choosesApprover Ain whatever workflow, it should be automatically filled out with the full relation (in this case Approver A -> Approver B, but it could be more approvers B -> C -> D -> and more)That said there is a real bug that was caused by @abzokhattab PR:
QuickTime.movie.5.mov
blazejkustra commentedon Jan 20, 2026
I think we shouldn't fix the OP issue and instead focus on my findings as this is causing real problems for users on production
melvin-bot commentedon Jan 21, 2026
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
greg-schroeder commentedon Jan 26, 2026
@JS00001 what do you think about the above?
JS00001 commentedon Jan 26, 2026
@blazejkustra 's comments make sense, @abzokhattab do you agree?
abzokhattab commentedon Jan 26, 2026
Yes, we fixed the issue @blazejkustra referred to. Given that the team decided the current behaviour is expected, we can close this one
JS00001 commentedon Jan 26, 2026
Thanks!