Skip to content

[Awaiting payment 2026-01-23][$250] Prevent unnecessary reauthentication after sign out #79209

Closed

Description

@mountiny

Coming from here

Right now, after a user signs out, some pending network requests still trigger reauthentication. This results in a lot of auth errors in Sentry that will always fail, since the credentials have already been cleared.
By checking credentials earlier and skipping the reauth flow entirely in this case, we can:

  • Avoid unnecessary API calls
  • Reduce Sentry noise (around ~2 errors per sign-out)
  • Slightly speed up the transition to the sign-in screen
  • Slightly reduce backend load by avoiding failed API calls

Example Sentry issue:
https://expensify.sentry.io/issues/7122416301/?environment=production&query=authentica[…]3A%5Breauthenticate%2CAuthenticate%5D&referrer=issue-stream

Issue OwnerCurrent Issue Owner: @JmillsExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 9, 2026
  2. melvin-bot commented on Jan 9, 2026

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. self-assigned this
    on Jan 9, 2026
  4. hungvu193 commented on Jan 13, 2026

    @hungvu193
    Contributor

    @mountiny Could you assign me here since I reviewed the PR?

  5. 7 remaining items

  6. changed the title [-][Awaiting payment 2026-01-23] Prevent unnecessary reauthentication after sign out[/-] [+][Awaiting payment 2026-01-23][250 Prevent unnecessary reauthentication after sign out[/+] on Feb 10, 2026
  7. changed the title [-][Awaiting payment 2026-01-23][250 Prevent unnecessary reauthentication after sign out[/-] [+][Awaiting payment 2026-01-23][$250] Prevent unnecessary reauthentication after sign out[/+] on Feb 10, 2026
  8. melvin-bot commented on Feb 10, 2026

    @melvin-bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  9. rlinoz commented on Feb 10, 2026

    @rlinoz
    Contributor

    Hey @JmillsExpensify @hungvu193 is the only one due payment here.

  10. JmillsExpensify commented on Feb 10, 2026

    @JmillsExpensify
    Contributor

    Payment summary: $250 @hungvu193 for PR review and testing.

  11. JmillsExpensify commented on Feb 10, 2026

    @JmillsExpensify
    Contributor

    Paid via New Expensify, so I'm closing this one out.

  12. twisterdotcom commented on Feb 11, 2026

    @twisterdotcom
    Contributor

    @hungvu193 has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-346d-a6b2-b374-0d69688de0e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions