You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Payment 2/4/26] [$250] Invoice - Partially set up bank account appears in the payment dropdown button #79563
It only checks accountData?.type === requiredAccountType and doesn't verify the account state. This allows partially set up accounts (state SETUP, VERIFYING, or PENDING) to appear in the payment dropdown
What changes do you think we should make in order to solve the problem?
Filter out partially set up accounts in getPaymentSubitems
What alternative solutions did you explore? (Optional)
Since formattedPaymentMethods is used in many places, we can update this variable to filter out the partial bank account
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Restate the problem this issue is trying to solve.
Some bank accounts are not fully set up.
They still appear in invoice and bulk pay screens.
Users can select them.
Payments then fail.
What is the root cause of that problem?
Payment builders only check the bank account type.
They do not check if the account setup is complete.
Partially set up ACH accounts pass the filter.
What changes do you think we should make in order to solve the problem?
Add a shared helper in the existing bank/payment utility file.
The helper returns false for partially set up bank accounts.
Use this helper in all payment option builders.
Remove local filters and rely on the helper.
Add a short comment to explain why the check is required.
// bankAccountsUtils.ts (existing utility file)export function isPaymentEligibleBankAccount(method: FormattedPaymentMethod) { const data = method?.accountData as AccountData; // Partially set up bank accounts must never surface as payment options. return !isBankAccountPartiallySetup(data?.state);}
definitely agree that we should not be showing a partially added bank account as a payment option in product and should only show the error and/or message indicating a payment account needs to be added/completed
changed the title [-]Invoice - Partially set up bank account appears in the payment dropdown button[/-][+][$250] Invoice - Partially set up bank account appears in the payment dropdown button[/+]on Jan 19, 2026
📣 @nyomanjyotisa 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
changed the title [-][$250] Invoice - Partially set up bank account appears in the payment dropdown button[/-][+][Payment 2/4/26] [$250] Invoice - Partially set up bank account appears in the payment dropdown button[/+]on Jan 29, 2026
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Precondition:
User A has a USD workspace with Invoices enabled.
User A has sent an invoice in USD to User B.
Test:
Perform the steps below as User B:
Go to staging.new.expensify.com
Create a USD workspace.
Go to workspace settings > Workflows.
Click Add bank account.
Click Connect manually.
Continue until Date of birth step.
Click outside RHP to close it.
Open the invoice report from User A.
Click Pay dropdown button.
Click Pay as a business.
Verify that there's no partial setup bank account show up (If user has no bank account setup, user should be redirected to connect bank account page).
Do we agree 👍 or 👎
Activity
melvin-bot commentedon Jan 14, 2026
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nyomanjyotisa commentedon Jan 14, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
Invoice - Partially set up bank account appears in the payment dropdown button
What is the root cause of that problem?
In
SettlementButton,getPaymentSubitemsfilters payment methods by account type but doesn't exclude partially set up accountsApp/src/components/SettlementButton/index.tsx
Lines 216 to 243 in 5129860
It only checks
accountData?.type === requiredAccountTypeand doesn't verify the account state. This allows partially set up accounts (stateSETUP,VERIFYING, orPENDING) to appear in the payment dropdownWhat changes do you think we should make in order to solve the problem?
Filter out partially set up accounts in
getPaymentSubitemsApp/src/components/SettlementButton/index.tsx
Lines 216 to 243 in 5129860
What alternative solutions did you explore? (Optional)
None
nkdengineer commentedon Jan 14, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
Partially set up bank account appears in the payment dropdown button.
Error shows up when trying to pay with the partially set up bank account.
What is the root cause of that problem?
The payment items don't filter out the incomplete bank account here
App/src/components/SettlementButton/index.tsx
Line 216 in 0a0c4e0
What changes do you think we should make in order to solve the problem?
We should use the same way we check for pending bank account in the workflow page here to filter out the partial setup bank account
App/src/components/SettlementButton/index.tsx
Line 216 in 0a0c4e0
We should fix the same for search page here
App/src/hooks/useBulkPayOptions.ts
Line 102 in 0a0c4e0
What alternative solutions did you explore? (Optional)
Since
formattedPaymentMethodsis used in many places, we can update this variable to filter out the partial bank accountReminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
yatin-italy commentedon Jan 14, 2026
Proposal
Restate the problem this issue is trying to solve.
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
// bankAccountsUtils.ts (existing utility file)export function isPaymentEligibleBankAccount(method: FormattedPaymentMethod) { const data = method?.accountData as AccountData; // Partially set up bank accounts must never surface as payment options. return !isBankAccountPartiallySetup(data?.state);}// SettlementButton/index.tsxconst getPaymentSubitems = useCallback( (payAsBusiness: boolean) => { const requiredType = payAsBusiness ? CONST.BANK_ACCOUNT.TYPE.BUSINESS : CONST.BANK_ACCOUNT.TYPE.PERSONAL; return formattedPaymentMethods .filter((method) => { const data = method?.accountData as AccountData; return data?.type === requiredType && isPaymentEligibleBankAccount(method); }) .map((formattedPaymentMethod) => ({ text: formattedPaymentMethod?.title ?? '', description: formattedPaymentMethod?.description ?? '', icon: formattedPaymentMethod?.icon, shouldUpdateSelectedIndex: true, onSelected: () => { if (checkForNecessaryAction()) { return; } onPress( CONST.IOU.PAYMENT_TYPE.EXPENSIFY, payAsBusiness, formattedPaymentMethod.methodID, formattedPaymentMethod.accountType, undefined, ); }, iconStyles: formattedPaymentMethod?.iconStyles, iconHeight: formattedPaymentMethod?.iconSize, iconWidth: formattedPaymentMethod?.iconSize, value: CONST.IOU.PAYMENT_TYPE.EXPENSIFY, })); }, [formattedPaymentMethods, onPress, checkForNecessaryAction],);// useBulkPayOptions.tsconst filteredMethods = useMemo( () => formattedPaymentMethods.filter(isPaymentEligibleBankAccount), [formattedPaymentMethods],);CortneyOfstad commentedon Jan 19, 2026
definitely agree that we should not be showing a partially added bank account as a payment option in product and should only show the error and/or message indicating a payment account needs to be added/completed
[-]Invoice - Partially set up bank account appears in the payment dropdown button[/-][+][$250] Invoice - Partially set up bank account appears in the payment dropdown button[/+]melvin-bot commentedon Jan 19, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022013292775376391948
11 remaining items
melvin-bot commentedon Jan 20, 2026
📣 @nyomanjyotisa 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
[-][$250] Invoice - Partially set up bank account appears in the payment dropdown button[/-][+][Payment 2/4/26] [$250] Invoice - Partially set up bank account appears in the payment dropdown button[/+]CortneyOfstad commentedon Feb 4, 2026
@hungvu193 — can you complete the checklist so I can issue payment? Thank you!
hungvu193 commentedon Feb 5, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: [Standardize payment button] Invoice feature #71748
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Precondition:
Test:
Do we agree 👍 or 👎
CortneyOfstad commentedon Feb 5, 2026
Payment Summary
@hungvu193 — to be paid $250 via New Dot
@nyomanjyotisa — to be paid $250 via New Dot
Regression Test
https://github.com/Expensify/Expensify/issues/597301
twisterdotcom commentedon Feb 6, 2026
@hungvu193 has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-7f8d-a2d4-868d-10462a2fa6d4trjExpensify commentedon Feb 10, 2026
approved $250 for @nyomanjyotisa.