Skip to content

[Payment 2/4/26] [$250] Invoice - Partially set up bank account appears in the payment dropdown button #79563

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.1-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2943/folder/13176671/41237471/1123995198
Email or phone of affected tester (no customers): applausetester+sjodijnoindjsio2s2@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • User A has a USD workspace with Invoices enabled.
  • User A has sent an invoice in USD to User B.
  • Perform the steps below as User B:
  1. Go to staging.new.expensify.com
  2. Create a USD workspace.
  3. Go to workspace settings > Workflows.
  4. Click Add bank account.
  5. Click Connect manually.
  6. Continue until Date of birth step.
    7, Click outside RHP to close it.
  7. Open the invoice report from User A.
  8. Click Pay dropdown button.
  9. Click Pay as a business.
  10. Click on the partially set up bank account.

Expected Result:

Partially set up bank account should not appear in the payment dropdown button.

Actual Result:

Partially set up bank account appears in the payment dropdown button.
Error shows up when trying to pay with the partially set up bank account.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022013292775376391948
  • Upwork Job ID: 2013292775376391948
  • Last Price Increase: 2026-01-19
  • Automatic offers:
    • nyomanjyotisa | Contributor | 110173201
Issue OwnerCurrent Issue Owner: @lakchote

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 14, 2026
  2. melvin-bot commented on Jan 14, 2026

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nyomanjyotisa commented on Jan 14, 2026

    @nyomanjyotisa
    Member

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Invoice - Partially set up bank account appears in the payment dropdown button

    What is the root cause of that problem?

    In SettlementButton, getPaymentSubitems filters payment methods by account type but doesn't exclude partially set up accounts

    const getPaymentSubitems = useCallback(
    (payAsBusiness: boolean) => {
    const requiredAccountType = payAsBusiness ? CONST.BANK_ACCOUNT.TYPE.BUSINESS : CONST.BANK_ACCOUNT.TYPE.PERSONAL;
    return formattedPaymentMethods
    .filter((method) => {
    const accountData = method?.accountData as AccountData;
    return accountData?.type === requiredAccountType;
    })
    .map((formattedPaymentMethod) => ({
    text: formattedPaymentMethod?.title ?? '',
    description: formattedPaymentMethod?.description ?? '',
    icon: formattedPaymentMethod?.icon,
    shouldUpdateSelectedIndex: true,
    onSelected: () => {
    if (checkForNecessaryAction()) {
    return;
    }
    onPress(CONST.IOU.PAYMENT_TYPE.EXPENSIFY, payAsBusiness, formattedPaymentMethod.methodID, formattedPaymentMethod.accountType, undefined);
    },
    iconStyles: formattedPaymentMethod?.iconStyles,
    iconHeight: formattedPaymentMethod?.iconSize,
    iconWidth: formattedPaymentMethod?.iconSize,
    value: CONST.IOU.PAYMENT_TYPE.EXPENSIFY,
    }));
    },
    [formattedPaymentMethods, onPress, checkForNecessaryAction],
    );

    It only checks accountData?.type === requiredAccountType and doesn't verify the account state. This allows partially set up accounts (state SETUP, VERIFYING, or PENDING) to appear in the payment dropdown

    What changes do you think we should make in order to solve the problem?

    Filter out partially set up accounts in getPaymentSubitems

        const getPaymentSubitems = useCallback(
            (payAsBusiness: boolean) => {
                const requiredAccountType = payAsBusiness ? CONST.BANK_ACCOUNT.TYPE.BUSINESS : CONST.BANK_ACCOUNT.TYPE.PERSONAL;
    
                return formattedPaymentMethods
                    .filter((method) => {
                        const accountData = method?.accountData as AccountData;
                        const isCorrectType = accountData?.type === requiredAccountType;
                        const isNotPartiallySetup = !isBankAccountPartiallySetup(accountData?.state);
                        return isCorrectType && isNotPartiallySetup;
                    })
                    .map((formattedPaymentMethod) => ({
                        text: formattedPaymentMethod?.title ?? '',
                        description: formattedPaymentMethod?.description ?? '',
                        icon: formattedPaymentMethod?.icon,
                        shouldUpdateSelectedIndex: true,
                        onSelected: () => {
                            if (checkForNecessaryAction()) {
                                return;
                            }
                            onPress(CONST.IOU.PAYMENT_TYPE.EXPENSIFY, payAsBusiness, formattedPaymentMethod.methodID, formattedPaymentMethod.accountType, undefined);
                        },
                        iconStyles: formattedPaymentMethod?.iconStyles,
                        iconHeight: formattedPaymentMethod?.iconSize,
                        iconWidth: formattedPaymentMethod?.iconSize,
                        value: CONST.IOU.PAYMENT_TYPE.EXPENSIFY,
                    }));
            },
            [formattedPaymentMethods, onPress, checkForNecessaryAction],
        );

    const getPaymentSubitems = useCallback(
    (payAsBusiness: boolean) => {
    const requiredAccountType = payAsBusiness ? CONST.BANK_ACCOUNT.TYPE.BUSINESS : CONST.BANK_ACCOUNT.TYPE.PERSONAL;
    return formattedPaymentMethods
    .filter((method) => {
    const accountData = method?.accountData as AccountData;
    return accountData?.type === requiredAccountType;
    })
    .map((formattedPaymentMethod) => ({
    text: formattedPaymentMethod?.title ?? '',
    description: formattedPaymentMethod?.description ?? '',
    icon: formattedPaymentMethod?.icon,
    shouldUpdateSelectedIndex: true,
    onSelected: () => {
    if (checkForNecessaryAction()) {
    return;
    }
    onPress(CONST.IOU.PAYMENT_TYPE.EXPENSIFY, payAsBusiness, formattedPaymentMethod.methodID, formattedPaymentMethod.accountType, undefined);
    },
    iconStyles: formattedPaymentMethod?.iconStyles,
    iconHeight: formattedPaymentMethod?.iconSize,
    iconWidth: formattedPaymentMethod?.iconSize,
    value: CONST.IOU.PAYMENT_TYPE.EXPENSIFY,
    }));
    },
    [formattedPaymentMethods, onPress, checkForNecessaryAction],
    );

    What alternative solutions did you explore? (Optional)

    None

  4. nkdengineer commented on Jan 14, 2026

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Partially set up bank account appears in the payment dropdown button.
    Error shows up when trying to pay with the partially set up bank account.

    What is the root cause of that problem?

    The payment items don't filter out the incomplete bank account here

    const getPaymentSubitems = useCallback(

    What changes do you think we should make in order to solve the problem?

    We should use the same way we check for pending bank account in the workflow page here to filter out the partial setup bank account

    const getPaymentSubitems = useCallback(
            (payAsBusiness: boolean) => {
                const requiredAccountType = payAsBusiness ? CONST.BANK_ACCOUNT.TYPE.BUSINESS : CONST.BANK_ACCOUNT.TYPE.PERSONAL;
    
                return formattedPaymentMethods
                    .filter((method) => {
                        const accountData = method?.accountData as AccountData;
                        const isPartiallySetup = isBankAccountPartiallySetup(accountData?.state);
                        return accountData?.type === requiredAccountType && !isPartiallySetup;
                    })
    

    const getPaymentSubitems = useCallback(

    We should fix the same for search page here

    const getPaymentSubitems = useCallback(

    What alternative solutions did you explore? (Optional)

    Since formattedPaymentMethods is used in many places, we can update this variable to filter out the partial bank account

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  5. yatin-italy commented on Jan 14, 2026

    @yatin-italy

    Proposal

    Restate the problem this issue is trying to solve.

    • Some bank accounts are not fully set up.
    • They still appear in invoice and bulk pay screens.
    • Users can select them.
    • Payments then fail.

    What is the root cause of that problem?

    • Payment builders only check the bank account type.
    • They do not check if the account setup is complete.
    • Partially set up ACH accounts pass the filter.

    What changes do you think we should make in order to solve the problem?

    • Add a shared helper in the existing bank/payment utility file.
    • The helper returns false for partially set up bank accounts.
    • Use this helper in all payment option builders.
    • Remove local filters and rely on the helper.
    • Add a short comment to explain why the check is required.
    // bankAccountsUtils.ts (existing utility file)export function isPaymentEligibleBankAccount(method: FormattedPaymentMethod) {    const data = method?.accountData as AccountData;    // Partially set up bank accounts must never surface as payment options.    return !isBankAccountPartiallySetup(data?.state);}
    // SettlementButton/index.tsxconst getPaymentSubitems = useCallback(    (payAsBusiness: boolean) => {        const requiredType = payAsBusiness ? CONST.BANK_ACCOUNT.TYPE.BUSINESS : CONST.BANK_ACCOUNT.TYPE.PERSONAL;        return formattedPaymentMethods            .filter((method) => {                const data = method?.accountData as AccountData;                return data?.type === requiredType && isPaymentEligibleBankAccount(method);            })            .map((formattedPaymentMethod) => ({                text: formattedPaymentMethod?.title ?? '',                description: formattedPaymentMethod?.description ?? '',                icon: formattedPaymentMethod?.icon,                shouldUpdateSelectedIndex: true,                onSelected: () => {                    if (checkForNecessaryAction()) {                        return;                    }                    onPress(                        CONST.IOU.PAYMENT_TYPE.EXPENSIFY,                        payAsBusiness,                        formattedPaymentMethod.methodID,                        formattedPaymentMethod.accountType,                        undefined,                    );                },                iconStyles: formattedPaymentMethod?.iconStyles,                iconHeight: formattedPaymentMethod?.iconSize,                iconWidth: formattedPaymentMethod?.iconSize,                value: CONST.IOU.PAYMENT_TYPE.EXPENSIFY,            }));    },    [formattedPaymentMethods, onPress, checkForNecessaryAction],);
    // useBulkPayOptions.tsconst filteredMethods = useMemo(    () => formattedPaymentMethods.filter(isPaymentEligibleBankAccount),    [formattedPaymentMethods],);
  6. CortneyOfstad commented on Jan 19, 2026

    @CortneyOfstad
    Contributor

    definitely agree that we should not be showing a partially added bank account as a payment option in product and should only show the error and/or message indicating a payment account needs to be added/completed

  7. changed the title [-]Invoice - Partially set up bank account appears in the payment dropdown button[/-] [+][$250] Invoice - Partially set up bank account appears in the payment dropdown button[/+] on Jan 19, 2026
  8. melvin-bot commented on Jan 19, 2026

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 19, 2026
  10. 11 remaining items

  11. melvin-bot commented on Jan 20, 2026

    @melvin-bot

    📣 @nyomanjyotisa 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on Jan 29, 2026
  13. changed the title [-][$250] Invoice - Partially set up bank account appears in the payment dropdown button[/-] [+][Payment 2/4/26] [$250] Invoice - Partially set up bank account appears in the payment dropdown button[/+] on Jan 29, 2026
  14. CortneyOfstad commented on Feb 4, 2026

    @CortneyOfstad
    Contributor

    @hungvu193 — can you complete the checklist so I can issue payment? Thank you!

  15. hungvu193 commented on Feb 5, 2026

    @hungvu193
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: [Standardize payment button] Invoice feature #71748

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    Precondition:

    • User A has a USD workspace with Invoices enabled.
    • User A has sent an invoice in USD to User B.

    Test:

    • Perform the steps below as User B:
    1. Go to staging.new.expensify.com
    2. Create a USD workspace.
    3. Go to workspace settings > Workflows.
    4. Click Add bank account.
    5. Click Connect manually.
    6. Continue until Date of birth step.
    7. Click outside RHP to close it.
    8. Open the invoice report from User A.
    9. Click Pay dropdown button.
    10. Click Pay as a business.
    11. Verify that there's no partial setup bank account show up (If user has no bank account setup, user should be redirected to connect bank account page).
      Do we agree 👍 or 👎
  16. CortneyOfstad commented on Feb 5, 2026

    @CortneyOfstad
    Contributor

    Payment Summary

    @hungvu193 — to be paid $250 via New Dot
    @nyomanjyotisa — to be paid $250 via New Dot

    Regression Test

    https://github.com/Expensify/Expensify/issues/597301

  17. twisterdotcom commented on Feb 6, 2026

    @twisterdotcom
    Contributor

    @hungvu193 has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-7f8d-a2d4-868d-10462a2fa6d4
  18. trjExpensify commented on Feb 10, 2026

    @trjExpensify
    Contributor

    approved $250 for @nyomanjyotisa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions