You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Workspace - RBR displays after select secondary login account as Additional approver #79637
Version Number: v9.3.2-1 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#78350 Email or phone of affected tester (no customers):leungbratt6+140109@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Windows 10/Chrome App Component: Workspace Settings
Action Performed:
Precondition: User B has a secondary login
User A creates a Workspace and adds the secondary login of user B as a member
Open the NewDot app
Navigate to the Workspace Settings -> Workflows
Change the current approver to User B
Enter any amount in the Report amount
Click on the Additional approver
Select the secondary login of user B
Click on the Workspace tab
Expected Result:
No placeholder avatar account of secondary login in the Additional approver
Actual Result:
After select placeholder avatar account of secondary login, a RBR is displayed in the Workspace tab "402 either a submitsTo or forwardsTo value is not a member of the policy: leungbratt6+140109@gmail.com"
Please re-state the problem that we are trying to solve in this issue.
When configuring Workspace → Workflows → Approvals, selecting a secondary-login “placeholder avatar” account as the Additional approver triggers a red-brick-road error on the Workspace tab: 402 either a submitsTo or forwardsTo value is not a member of the policy.
What is the root cause of that problem?
The over-limit additional approver picker was building its selectable list from policy.employeeList and allowed “duplicate/secondary login” entries that don’t resolve to real personal details / accountIDs (i.e., they aren’t valid selectable members). Selecting one stores that secondary login into overLimitForwardsTo (and/or related workflow fields), and the backend rejects it because that login is not a valid policy member, resulting in the 402 error.
What changes do you think we should make in order to solve the problem?
Update the Additional approver (over-limit) selection list to only show valid workspace members by filtering options through the existing “workspace members → accountIDs” mapping (i.e., only include entries that can be resolved to a real member accountID / personalDetails record). This prevents secondary-login placeholder rows from appearing at all.
Add a defensive check at selection time: if the chosen login is not a valid workspace member, do not persist it as overLimitForwardsTo (and optionally fall back to the mapped primary login when we can infer it).
Keep behavior consistent with the primary approver picker (which already avoids listing non-resolvable members), so both pickers enforce the same “only real members can be selected” rule.
What alternative solutions did you explore? (Optional)
Add the same accountID guard to WorkspaceWorkflowsApprovalsOverLimitApproverPage so we never render/select options that aren’t recognized as real workspace members.
Please re-state the problem that we are trying to solve in this issue.
RBR displays after select secondary login account as Additional approver
What is the root cause of that problem?
When a secondary login account is invited to a workspace, both the primary and secondary emails end up in the policy.employeeList.
On the workspace member page, we already filter out secondary emails by checking for the absence of personal detail data, which is typical for secondary logins.
changed the title [-]Workspace - RBR displays after select secondary login account as Additional approver[/-][+][$250] Workspace - RBR displays after select secondary login account as Additional approver[/+]on Jan 16, 2026
Please re-state the problem that we are trying to solve in this issue.
RBR displays after select secondary login account as Additional approver.
What is the root cause of that problem?
Secondary emails in employee list: When a user's secondary login email is added to a workspace, it appears in policy.employeeList with the secondary email as the key.
Missing validation in some pages: Some pages iterate through employeeList directly without checking if the email resolves to a valid accountID via personalDetails. Secondary login emails don't have corresponding personalDetails entries.
Inconsistent filtering pattern:
WorkspaceWorkflowsApprovalsApproverPage.tsx (lines 83-88) has the check: if (!accountID) return null;
WorkspaceWorkflowsApprovalsOverLimitApproverPage.tsxmissing this check
constaccountID=Number(policyMemberEmailsToAccountIDs[email]??'');// Filter out secondary login emails that don't have valid accountIDsif(!accountID){returnnull;}const{avatar, displayName =email, login}=personalDetails?.[accountID]??{};
constpersonalDetail=getPersonalDetailByEmail(email);// Filter out secondary login emails that don't have valid personal detailsif(!personalDetail?.accountID){continue;}membersList.push({...});
constpersonalDetail=getPersonalDetailByEmail(email);// Filter out secondary login emails that don't have valid personal detailsif(!personalDetail?.accountID){continue;}membersList.push({...});
What alternative solutions did you explore?
N/A
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
melvin-bot commentedon Jan 15, 2026
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.annaweber830 commentedon Jan 15, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When configuring Workspace → Workflows → Approvals, selecting a secondary-login “placeholder avatar” account as the Additional approver triggers a red-brick-road error on the Workspace tab: 402 either a submitsTo or forwardsTo value is not a member of the policy.
What is the root cause of that problem?
The over-limit additional approver picker was building its selectable list from policy.employeeList and allowed “duplicate/secondary login” entries that don’t resolve to real personal details / accountIDs (i.e., they aren’t valid selectable members). Selecting one stores that secondary login into overLimitForwardsTo (and/or related workflow fields), and the backend rejects it because that login is not a valid policy member, resulting in the 402 error.
What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional)
Add the same
accountIDguard toWorkspaceWorkflowsApprovalsOverLimitApproverPageso we never render/select options that aren’t recognized as real workspace members.App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsOverLimitApproverPage.tsx
Lines 54 to 91 in ffca2e2
Current code:
Updated code:
paulnjs commentedon Jan 15, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
policy.employeeList.App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsOverLimitApproverPage.tsx
Lines 56 to 57 in fb1e667
What changes do you think we should make in order to solve the problem?
Here's the proposed hook:
App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsOverLimitApproverPage.tsx
Line 43 in fb1e667
policy.employeeListwith:App/src/pages/workspace/companyCards/assignCard/AssigneeStep.tsx
Line 160 in fb1e667
usePolicyMemberhook for consistent filtering.What alternative solutions did you explore? (Optional)
melvin-bot commentedon Jan 16, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022012183551003502125
[-]Workspace - RBR displays after select secondary login account as Additional approver[/-][+][$250] Workspace - RBR displays after select secondary login account as Additional approver[/+]melvin-bot commentedon Jan 16, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)KocaPepsi commentedon Jan 19, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
RBR displays after select secondary login account as Additional approver.
What is the root cause of that problem?
Secondary emails in employee list: When a user's secondary login email is added to a workspace, it appears in
policy.employeeListwith the secondary email as the key.Missing validation in some pages: Some pages iterate through
employeeListdirectly without checking if the email resolves to a validaccountIDviapersonalDetails. Secondary login emails don't have correspondingpersonalDetailsentries.Inconsistent filtering pattern:
WorkspaceWorkflowsApprovalsApproverPage.tsx(lines 83-88) has the check:if (!accountID) return null;WorkspaceWorkflowsApprovalsOverLimitApproverPage.tsxmissing this checkApp/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsOverLimitApproverPage.tsx
Line 72 in f912da1
companyCards/assignCard/AssigneeStep.tsxmissing this checkApp/src/pages/workspace/companyCards/assignCard/AssigneeStep.tsx
Line 165 in f912da1
expensifyCard/issueNew/AssigneeStep.tsxmissing this checkApp/src/pages/workspace/expensifyCard/issueNew/AssigneeStep.tsx
Line 130 in f912da1
What changes do you think we should make in order to solve the problem?
Add the missing validation check to filter out secondary login emails that don't have valid accountIDs.
App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsOverLimitApproverPage.tsx
Line 72 in f912da1
update to:
App/src/pages/workspace/companyCards/assignCard/AssigneeStep.tsx
Line 165 in f912da1
update to:
App/src/pages/workspace/expensifyCard/issueNew/AssigneeStep.tsx
Line 130 in f912da1
update to:
What alternative solutions did you explore?
N/A
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
52 remaining items
melvin-bot commentedon Mar 27, 2026
This issue has not been updated in over 15 days. @lakchote, @bfitzexpensify, @situchan, @annaweber830 eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
situchan commentedon Mar 30, 2026
Automation failed here. PR deployed to production on Mar 6.
@bfitzexpensify can you please sort payment? Thanks
annaweber830 commentedon Apr 16, 2026
@lakchote, @bfitzexpensify PR deployed to production on Mar 6.
annaweber830 commentedon Apr 20, 2026
@lakchote, @bfitzexpensify, @situchan PR deployed to production on Mar 6.
bfitzexpensify commentedon Apr 21, 2026
Payment summary:
@situchan due $250 via NewDot manual request
Dm'd @annaweber830 for Upwork link
bfitzexpensify commentedon Apr 23, 2026
Payments complete
laurenreidexpensify commentedon Apr 27, 2026
$250 approved for @situchan