You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-02-03] [$250] Web - Contact Methods - Existing account email gets stuck on Add Contact Method without error #79672
Version Number: 9.3.2-1 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/folder/13176687/test-cases/41236654 Email or phone of affected tester (no customers):testing210790+65t@gmail.com Issue reported by: Applause Internal Team Bug source: Regression TC Execution Device used: Windows 11 App Component: Notifications
Action Performed:
Navigate to Account Settings
Open Profile
Click on Contact Method
Click on New Contact Method
Enter an email that already belongs to an existing user account
Click on Add
Expected Result:
The user is redirected to the Contact Methods page and an error is displayed indicating that emails associated with existing accounts cannot be added as secondary contact methods
Actual Result:
After clicking on Add, the page shows a loading state and remains on the Add Contact Method screen. No error message is displayed and the user is not informed that the entered email already belongs to an existing account. The user is unable to proceed or understand why the action failed.
Please re-state the problem that we are trying to solve in this issue.
When adding a contact method with an email that already belongs to an existing account, the page shows a loading spinner and gets stuck without displaying any error message.
What is the root cause of that problem?
The failureData in addNewContactMethod wipes out the error information from the server.
Here's what happens:
User enters an email belonging to an existing account
API call is made, server returns error with onyxData containing the error message in LOGIN_LIST[contactMethod].errorFields.addedLogin
Server's onyxData is applied first (this is correct)
Then failureData is applied, which does this:
// src/libs/actions/User.ts:420-426{onyxMethod: Onyx.METHOD.MERGE,key: ONYXKEYS.LOGIN_LIST,value: {[contactMethod]: null,// Erases EVERYTHING including the error},},
Setting the entry to null erases the error info the server just sent. The page checks LOGIN_LIST[contactMethod].errorFields.addedLogin for errors, but that's now gone.
What changes do you think we should make in order to solve the problem?
Remove the LOGIN_LIST entry from failureData. The server already sends proper error data in its onyxData response - we just need to stop erasing it.
This way when the server returns an error for "email already exists", the error message stays in LOGIN_LIST[contactMethod].errorFields.addedLogin and gets displayed to the user.
What alternative solutions did you explore? (Optional)
Could also update failureData to preserve error fields (like deleteContactMethod does), but that's more complex. Since the server already sends the right error data, simply not erasing it is the cleanest fix.
Please re-state the problem that we are trying to solve in this issue.
Contact Methods - Existing account email gets stuck on Add Contact Method without showing any error
What is the root cause of that problem?
The failure handler clears the new login entry in the login list. The API error is attached to that login entry, so it gets wiped and the UI cannot show it.
changed the title [-]Web - Contact Methods - Existing account email gets stuck on Add Contact Method without error[/-][+][$250] Web - Contact Methods - Existing account email gets stuck on Add Contact Method without error[/+]on Jan 21, 2026
changed the title [-][$250] Web - Contact Methods - Existing account email gets stuck on Add Contact Method without error[/-][+][Due for payment 2026-02-03] [$250] Web - Contact Methods - Existing account email gets stuck on Add Contact Method without error[/+]on Jan 27, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.9-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ikevin127@mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A - Result of the original design
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Jan 15, 2026
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.MobileMage commentedon Jan 15, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When adding a contact method with an email that already belongs to an existing account, the page shows a loading spinner and gets stuck without displaying any error message.
What is the root cause of that problem?
The
failureDatainaddNewContactMethodwipes out the error information from the server.Here's what happens:
LOGIN_LIST[contactMethod].errorFields.addedLoginfailureDatais applied, which does this:Setting the entry to
nullerases the error info the server just sent. The page checksLOGIN_LIST[contactMethod].errorFields.addedLoginfor errors, but that's now gone.What changes do you think we should make in order to solve the problem?
Remove the
LOGIN_LISTentry fromfailureData. The server already sends proper error data in its onyxData response - we just need to stop erasing it.This way when the server returns an error for "email already exists", the error message stays in
LOGIN_LIST[contactMethod].errorFields.addedLoginand gets displayed to the user.What alternative solutions did you explore? (Optional)
Could also update
failureDatato preserve error fields (likedeleteContactMethoddoes), but that's more complex. Since the server already sends the right error data, simply not erasing it is the cleanest fix.yatin-italy commentedon Jan 15, 2026
Proposal
Restate the problem this issue is trying to solve.
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
failureData.failureData.ShridharGoel commentedon Jan 15, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
Contact Methods - Existing account email gets stuck on Add Contact Method without showing any error
What is the root cause of that problem?
The failure handler clears the new login entry in the login list. The API error is attached to that login entry, so it gets wiped and the UI cannot show it.
App/src/libs/actions/User.ts
Lines 401 to 426 in 0860dcf
What changes do you think we should make in order to solve the problem?
Update
errorFields.addedLoginin the failureData of the pending contact action.Updated code:
truph01 commentedon Jan 16, 2026
This might be a regression introduced by #77429.
melvin-bot commentedon Jan 21, 2026
@mallenexpensify Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Jan 21, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022013780454331793363
[-]Web - Contact Methods - Existing account email gets stuck on Add Contact Method without error[/-][+][$250] Web - Contact Methods - Existing account email gets stuck on Add Contact Method without error[/+]12 remaining items
[-][$250] Web - Contact Methods - Existing account email gets stuck on Add Contact Method without error[/-][+][Due for payment 2026-02-03] [$250] Web - Contact Methods - Existing account email gets stuck on Add Contact Method without error[/+]melvin-bot commentedon Jan 27, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 27, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.9-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-02-03. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 27, 2026
@ikevin127 @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
ikevin127 commentedon Feb 2, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A - Result of the original design
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/596691
Regression Test Proposal
Do we agree 👍 or 👎.
Zapier Logs
Run ID: 00040eee-9ff3-adc9-28be-1bc410a79034mallenexpensify commentedon Feb 4, 2026
Payment Summary
Contributor: @MobileMage paid $250 via Upwork
Contributor+: @ikevin127 due $250 via NewDot
^ Test case created
Thx!
garrettmknight commentedon Feb 10, 2026
$250 approved for @ikevin127