Skip to content

[Due for payment 2026-01-27] Expense - Expense report RHP does not close and opens not here page after rejecting expense #79706

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.3-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #77657
Email or phone of affected tester (no customers): ndjiosjdoisjodsjso@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Submission frequency is set to Instantly.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create an expense.
  4. Open the expense report.
  5. Click More > Reject.
  6. Enter reason and save it.

Expected Result:

Expense report RHP will close.

Actual Result:

Expense report RHP does not close and opens not here page after rejecting expense.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @dylanexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 15, 2026
  2. melvin-bot commented on Jan 15, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #77657

  3. melvin-bot commented on Jan 15, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Jan 15, 2026

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Jan 15, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Jan 15, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #77657 - "Super wide RHP" by @collectioneur (High confidence)
    Related Issues: #77598 (same symptom, was previously fixed in #77738)

    Recommendation: REVERT

    PR #77657 reintroduced a navigation bug that was previously fixed in PR #77738. When rejecting an expense from an Expense Report RHP opened via the Inbox tab (route e/:reportID), the RHP closes completely and shows a "not here" page instead of properly navigating back to the parent report.

    Labels: Keeping DeployBlockerCash (this is a Frontend bug in the App repository). No label changes needed as both labels are correctly applied.

    📋 Detailed Analysis

    Evidence

    PR #77657 modified the rejection flow in several files:

    • src/pages/iou/RejectReasonPage.tsx - Changed to use Navigation.dismissToSuperWideRHP()
    • src/libs/ReportUtils.ts - Replaced the navigateBackOnDeleteTransaction function, removing special handling for expense report navigation
    • Added new route EXPENSE_REPORT_RHP (e/:reportID) for displaying expense reports in Inbox

    The same navigation issue was previously reported in #77598 and fixed in PR #77738 (merged Dec 17, 2025), but PR #77657 (merged Jan 15, 2026) overwrote that fix.

    Verification

    Affected files from PR #77657:

    • src/pages/iou/RejectReasonPage.tsx - Lines 34-40 now call Navigation.dismissToSuperWideRHP()
    • src/libs/ReportUtils.ts - The navigateBackOnDeleteTransaction function at lines 6260-6275 no longer has the special logic that PR fix: navigation issue when deleting expense #77738 added

    Root Cause

    The Navigation.dismissToSuperWideRHP() function:

    1. On wide layouts, calls dismissToModalStack(SUPER_WIDE_RIGHT_MODALS)
    2. This searches for the last Super Wide RHP modal in the navigation stack
    3. If found, it pops back to that modal
    4. However, in the reject flow from the Inbox Expense Report, the navigation state structure causes the function to not find the parent modal correctly
    5. When lastFoundModalStackIndex === -1, it falls back to dismissModal() which dismisses the entire modal stack
    6. This leaves the user on a "not here" page

    The previous fix in PR #77738 had explicit handling for SCREENS.SEARCH.MONEY_REQUEST_REPORT (which is now SCREENS.RIGHT_MODAL.EXPENSE_REPORT) that properly navigated back using the backTo parameter. PR #77657 removed this logic in favor of a generic dismissToSuperWideRHP() call that does not work correctly in all scenarios.

  7. WojtekBoman commented on Jan 15, 2026

    @WojtekBoman
    Contributor

    I'll prepare a PR fixing it!

  8. IuliiaHerets commented on Jan 16, 2026

    @IuliiaHerets

    @mountiny issue is not reproduced anymore on Web and iOS, build 9.3.3-6

    1768584470090.ScreenRecording_01-16-2026_12-26-17_1.mp4
    1768584054037.Recording__1280.mp4
  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 20, 2026
  10. changed the title [-]Expense - Expense report RHP does not close and opens not here page after rejecting expense[/-] [+][Due for payment 2026-01-27] Expense - Expense report RHP does not close and opens not here page after rejecting expense[/+] on Jan 20, 2026
  11. melvin-bot commented on Jan 20, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Jan 20, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.4-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-01-27. 🎊

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on Jan 20, 2026

    @melvin-bot

    @ZhenjaHorbach @dylanexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions