Skip to content

[Due for payment 2026-01-27] Expense - Wide RHP reopens same page after clicking back button on magic code RHP #79708

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.3-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #77657
Email or phone of affected tester (no customers): sjnodijsodijsoijsio@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Account is unverified.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create an expense.
  4. Click Submit and Approver on the preview.
  5. Open the expense report.
  6. Click Pay > Mark as paid.
  7. Click RHP back button.
  8. Click back button on expense report RHP.

Expected Result:

Expense report will close after closing magic code page and clicking back button on expense report RHP.

Actual Result:

Expense report reopens after closing magic code page and clicking back button on expense report RHP.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7050303_1768498764643.4.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @heyjennahay

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 15, 2026
  2. melvin-bot commented on Jan 15, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #77657

  3. melvin-bot commented on Jan 15, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Jan 15, 2026

    @melvin-bot

    Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Jan 15, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Jan 15, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #77657 - "Super wide RHP" by @collectioneur (High confidence)
    Related Issues: None

    Recommendation: REVERT

    PR #77657 should be reverted. This is a significant navigation regression affecting the core expense report workflow on staging. The PR introduces complex navigation changes for Super Wide RHP that need additional refinement before being production-ready.

    Labels: Keeping DeployBlockerCash (App deploy blocked), removing DeployBlocker (not a backend issue)

    📋 Detailed Analysis

    Evidence

    PR #77657 introduced the Super Wide RHP feature which completely redesigned how expense reports are displayed:

    • Added new route EXPENSE_REPORT_RHP (e/:reportID) for displaying expense reports in Super Wide RHP
    • Added new verify account page EXPENSE_REPORT_VERIFY_ACCOUNT for this flow
    • Modified navigation methods with dismissToSuperWideRHP() and navigateBackToLastSuperWideRHPScreen()
    • Changed 62 files affecting navigation, report headers, and modal behavior

    The bug was reported as staging-only and reproducible in version 9.3.3-0, which aligns with PR #77657 being merged on 2026-01-15 and included in the current staging deploy.

    Verification

    Files affected by the bug:

    • src/pages/home/report/ExpenseReportVerifyAccountPage.tsx (new file in PR Super wide RHP  #77657)
    • src/libs/Navigation/Navigation.ts (modified navigation methods)
    • src/ROUTES.ts (added EXPENSE_REPORT_RHP and EXPENSE_REPORT_VERIFY_ACCOUNT routes)

    Confirmed the PR modifies these files:

    $ gh pr view 77657 --json files --jq '.files[].path' | grep -E "ExpenseReportVerify|Navigation.ts|ROUTES.ts"
    src/pages/home/report/ExpenseReportVerifyAccountPage.tsx
    src/libs/Navigation/Navigation.ts
    src/ROUTES.ts

    Timeline alignment:

    Root Cause

    The bug occurs in the navigation flow after account verification:

    1. User opens expense report via new e/:reportID route (Super Wide RHP)
    2. User clicks "Mark as paid" → triggers EXPENSE_REPORT_VERIFY_ACCOUNT page (regular RHP on top)
    3. After entering magic code, ExpenseReportVerifyAccountPage.tsx line 11 calls:
      <VerifyAccountPageBase navigateBackTo={ROUTES.EXPENSE_REPORT_RHP.getRoute({reportID})} />
    4. This navigates TO the expense report route instead of dismissing the verify modal
    5. The navigation history becomes corrupted, causing the expense report to reopen when clicking back

    The issue is that ExpenseReportVerifyAccountPage uses the same pattern as ReportVerifyAccountPage (passing navigateBackTo with a report route), but the navigation behavior differs for Super Wide RHP contexts. The verify account page should either dismiss without navigation or use Super Wide RHP-specific navigation methods like dismissToSuperWideRHP().

  7. ZhenjaHorbach commented on Jan 15, 2026

    @ZhenjaHorbach
    Contributor

    @mountiny
    It's our

  8. francoisl commented on Jan 15, 2026

    @francoisl
    Contributor

    Demoting as non-critical issue

  9. 4 remaining items

  10. mountiny commented on Jan 16, 2026

    @mountiny
    Contributor

    Fixed based on the comment in the pr

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 20, 2026
  12. changed the title [-]Expense - Wide RHP reopens same page after clicking back button on magic code RHP[/-] [+][Due for payment 2026-01-27] Expense - Wide RHP reopens same page after clicking back button on magic code RHP[/+] on Jan 20, 2026
  13. melvin-bot commented on Jan 20, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Jan 20, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.4-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-01-27. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Jan 20, 2026

    @melvin-bot

    @ZhenjaHorbach @heyjennahay The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions