Skip to content

[$250] Report loads infinitely after merging expenses from different report for the second time #79717

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.3-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #77657
Email or phone of affected tester (no customers): sindjiosjsodijsodijs@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

1 .Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create two reports with one expense in each report.
4. Open any report.
5. Click More > Merge.
6. Select expense from the other report > Continue.
7. Select the second option for each details > Next.
8. Click Merge expenses.
9. Go back to workspace chat.
10. Create another report with expense.
11. Open the report from Step 10.
12. Click More > Merge.
13. Select expense from the other report > Continue.
14. Select the second option for each details > Next.
15. Click Merge expenses.

Expected Result:

Report will open without issue after merging expenses.

Actual Result:

Report loads infinitely after merging expenses from different report for the second time.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @situchan
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022029615176988386191
  • Upwork Job ID: 2029615176988386191
  • Last Price Increase: 2026-03-05

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 15, 2026
  2. melvin-bot commented on Jan 15, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #77657

  3. melvin-bot commented on Jan 15, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Jan 15, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Jan 15, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Jan 15, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #77657 - "Super wide RHP" by @collectioneur (High confidence)
    Related Issues: None

    Recommendation: REVERT

    The bug occurs because PR #77657 changed how merge expense navigation works, introducing a new dismissToSuperWideRHP() navigation pattern that doesnt properly handle the scenario when merging expenses multiple times in succession. When merging expenses for the second time, the navigation tries to dismiss back to a Super Wide RHP modal that may no longer be in the navigation stack in the expected state, causing the report to load infinitely.

    Labels: This is a Frontend bug - the issue is caused by changes to the App navigation logic in PR #77657. Keeping DeployBlockerCash label as-is.

    Detailed Analysis

    Evidence

    PR #77657 introduced a major refactoring of how expense reports are displayed in the app, moving from a central screen to a Super Wide RHP (Right Hand Panel) pattern. The key change affecting merge functionality is in src/pages/TransactionMerge/ConfirmationPage.tsx:

    Before PR #77657: Merge would use standard modal dismissal patterns
    After PR #77657: Line 106 uses Navigation.dismissToSuperWideRHP() which tries to navigate back to a Super Wide RHP modal

    The issue manifests on the SECOND merge operation because:

    1. First merge: Report opens in Super Wide RHP, merge completes, dismissToSuperWideRHP works as expected
    2. Second merge: Navigation stack is in a different state after the first merge, dismissToSuperWideRHP cannot find the expected Super Wide RHP screen in the stack, causing infinite loading

    Verification

    The affected file confirmed by PR diff:

    • src/pages/TransactionMerge/ConfirmationPage.tsx - Modified to use dismissToSuperWideRHP() at line 106
    • src/components/AddUnreportedExpenseFooter.tsx - Changed from dismissModal() to dismissToSuperWideRHP()
    • src/libs/Navigation/Navigation.ts - Added new dismissToSuperWideRHP() function that has specific logic for handling Super Wide RHP dismissal

    The bug reproduction steps from the issue directly match the navigation changes in this PR.

    Root Cause

    The dismissToSuperWideRHP() function in Navigation.ts (lines 824-832) attempts to dismiss back to a Super Wide RHP modal by calling dismissToModalStack(SUPER_WIDE_RIGHT_MODALS). However, after the first merge operation completes, the navigation state changes - the report that was previously open in a Super Wide RHP may have been closed or the modal stack may be in an unexpected state. When attempting the second merge, the function cannot properly resolve where to navigate, resulting in an infinite loading state.

    The core issue is that the PR changed fundamental navigation patterns for expense reports without fully accounting for edge cases like repeated merge operations where the navigation stack state becomes unpredictable.

  7. 60 remaining items

  8. melvin-bot commented on Mar 12, 2026

    @melvin-bot

    @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  9. mvtglobally commented on Mar 15, 2026

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  10. melvin-bot commented on Mar 16, 2026

    @melvin-bot

    @situchan Still overdue 6 days?! Let's take care of this!

  11. situchan commented on Mar 17, 2026

    @situchan
    Contributor

    Not overdue

  12. melvin-bot commented on Mar 20, 2026

    @melvin-bot

    @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

  13. melvin-bot commented on Mar 20, 2026

    @melvin-bot

    @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

  14. situchan commented on Mar 24, 2026

    @situchan
    Contributor

    @jponikarchuk are you still able to reproduce?

  15. mallenexpensify commented on Mar 24, 2026

    @mallenexpensify
    Contributor

    @situchan the QA team doesn't monitor issues so tagging isn't best. I requested a retest. If it's not reproducible, let's close (and close Melvin's draft PR too)

  16. m-natarajan commented on Mar 24, 2026

    @m-natarajan

    Issue no longer reproducible on build 9.3.43-1. Retested on Windows11 - Chrome.

    Merged.mp4
  17. moved this from MEDIUM or LOW to Done in [#whatsnext] #migrateon Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions