You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Report loads infinitely after merging expenses from different report for the second time #79717
Version Number: 9.3.3-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#77657 Email or phone of affected tester (no customers):sindjiosjsodijsodijs@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.1 / Chrome App Component: Money Requests
Action Performed:
1 .Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create two reports with one expense in each report.
4. Open any report.
5. Click More > Merge.
6. Select expense from the other report > Continue.
7. Select the second option for each details > Next.
8. Click Merge expenses.
9. Go back to workspace chat.
10. Create another report with expense.
11. Open the report from Step 10.
12. Click More > Merge.
13. Select expense from the other report > Continue.
14. Select the second option for each details > Next.
15. Click Merge expenses.
Expected Result:
Report will open without issue after merging expenses.
Actual Result:
Report loads infinitely after merging expenses from different report for the second time.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #77657 - "Super wide RHP" by @collectioneur (High confidence) Related Issues: None
Recommendation: REVERT
The bug occurs because PR #77657 changed how merge expense navigation works, introducing a new dismissToSuperWideRHP() navigation pattern that doesnt properly handle the scenario when merging expenses multiple times in succession. When merging expenses for the second time, the navigation tries to dismiss back to a Super Wide RHP modal that may no longer be in the navigation stack in the expected state, causing the report to load infinitely.
Labels: This is a Frontend bug - the issue is caused by changes to the App navigation logic in PR #77657. Keeping DeployBlockerCash label as-is.
Detailed Analysis
Evidence
PR #77657 introduced a major refactoring of how expense reports are displayed in the app, moving from a central screen to a Super Wide RHP (Right Hand Panel) pattern. The key change affecting merge functionality is in src/pages/TransactionMerge/ConfirmationPage.tsx:
Before PR #77657: Merge would use standard modal dismissal patterns After PR #77657: Line 106 uses Navigation.dismissToSuperWideRHP() which tries to navigate back to a Super Wide RHP modal
The issue manifests on the SECOND merge operation because:
First merge: Report opens in Super Wide RHP, merge completes, dismissToSuperWideRHP works as expected
Second merge: Navigation stack is in a different state after the first merge, dismissToSuperWideRHP cannot find the expected Super Wide RHP screen in the stack, causing infinite loading
Verification
The affected file confirmed by PR diff:
src/pages/TransactionMerge/ConfirmationPage.tsx - Modified to use dismissToSuperWideRHP() at line 106
src/components/AddUnreportedExpenseFooter.tsx - Changed from dismissModal() to dismissToSuperWideRHP()
src/libs/Navigation/Navigation.ts - Added new dismissToSuperWideRHP() function that has specific logic for handling Super Wide RHP dismissal
The bug reproduction steps from the issue directly match the navigation changes in this PR.
Root Cause
The dismissToSuperWideRHP() function in Navigation.ts (lines 824-832) attempts to dismiss back to a Super Wide RHP modal by calling dismissToModalStack(SUPER_WIDE_RIGHT_MODALS). However, after the first merge operation completes, the navigation state changes - the report that was previously open in a Super Wide RHP may have been closed or the modal stack may be in an unexpected state. When attempting the second merge, the function cannot properly resolve where to navigate, resulting in an infinite loading state.
The core issue is that the PR changed fundamental navigation patterns for expense reports without fully accounting for edge cases like repeated merge operations where the navigation stack state becomes unpredictable.
@situchan the QA team doesn't monitor issues so tagging isn't best. I requested a retest. If it's not reproducible, let's close (and close Melvin's draft PR too)
Activity
melvin-bot commentedon Jan 15, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #77657
melvin-bot commentedon Jan 15, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Jan 15, 2026
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jan 15, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Jan 15, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #77657 - "Super wide RHP" by @collectioneur (High confidence)
Related Issues: None
Recommendation: REVERT
The bug occurs because PR #77657 changed how merge expense navigation works, introducing a new
dismissToSuperWideRHP()navigation pattern that doesnt properly handle the scenario when merging expenses multiple times in succession. When merging expenses for the second time, the navigation tries to dismiss back to a Super Wide RHP modal that may no longer be in the navigation stack in the expected state, causing the report to load infinitely.Labels: This is a Frontend bug - the issue is caused by changes to the App navigation logic in PR #77657. Keeping
DeployBlockerCashlabel as-is.Detailed Analysis
Evidence
PR #77657 introduced a major refactoring of how expense reports are displayed in the app, moving from a central screen to a Super Wide RHP (Right Hand Panel) pattern. The key change affecting merge functionality is in
src/pages/TransactionMerge/ConfirmationPage.tsx:Before PR #77657: Merge would use standard modal dismissal patterns
After PR #77657: Line 106 uses
Navigation.dismissToSuperWideRHP()which tries to navigate back to a Super Wide RHP modalThe issue manifests on the SECOND merge operation because:
Verification
The affected file confirmed by PR diff:
src/pages/TransactionMerge/ConfirmationPage.tsx- Modified to usedismissToSuperWideRHP()at line 106src/components/AddUnreportedExpenseFooter.tsx- Changed fromdismissModal()todismissToSuperWideRHP()src/libs/Navigation/Navigation.ts- Added newdismissToSuperWideRHP()function that has specific logic for handling Super Wide RHP dismissalThe bug reproduction steps from the issue directly match the navigation changes in this PR.
Root Cause
The
dismissToSuperWideRHP()function in Navigation.ts (lines 824-832) attempts to dismiss back to a Super Wide RHP modal by callingdismissToModalStack(SUPER_WIDE_RIGHT_MODALS). However, after the first merge operation completes, the navigation state changes - the report that was previously open in a Super Wide RHP may have been closed or the modal stack may be in an unexpected state. When attempting the second merge, the function cannot properly resolve where to navigate, resulting in an infinite loading state.The core issue is that the PR changed fundamental navigation patterns for expense reports without fully accounting for edge cases like repeated merge operations where the navigation stack state becomes unpredictable.
60 remaining items
melvin-bot commentedon Mar 12, 2026
@situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
mvtglobally commentedon Mar 15, 2026
Issue not reproducible during KI retests. (First week)
melvin-bot commentedon Mar 16, 2026
@situchan Still overdue 6 days?! Let's take care of this!
situchan commentedon Mar 17, 2026
Not overdue
melvin-bot commentedon Mar 20, 2026
@situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Mar 20, 2026
@situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!
situchan commentedon Mar 24, 2026
@jponikarchuk are you still able to reproduce?
mallenexpensify commentedon Mar 24, 2026
@situchan the QA team doesn't monitor issues so tagging isn't best. I requested a retest. If it's not reproducible, let's close (and close Melvin's draft PR too)
m-natarajan commentedon Mar 24, 2026
Issue no longer reproducible on build 9.3.43-1. Retested on Windows11 - Chrome.
Merged.mp4