Skip to content

[Due for payment 2026-01-27] Expense report wide RHP closes and it reopens in central pane after clicking header subtitle #79734

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.3-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #77657
Email or phone of affected tester (no customers): jsnodsjdosjsoij@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create two expenses.
  4. Open the expense report.
  5. Open any expense row.
  6. Click on the report link in report header subtitle.

Expected Result:

App will return to expense report wide RHP.

Actual Result:

Expense report wide RHP closes and it reopens in central pane.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7050441_1768505671886.12.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @joekaufmanexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jan 16, 2026
  2. melvin-bot commented on Jan 16, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #77657

  3. melvin-bot commented on Jan 16, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Jan 16, 2026

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Jan 16, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Jan 16, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #77657 - "Super wide RHP" by @collectioneur (High confidence)
    Related Issues: Original feature issue #71821

    Recommendation: REVERT

    This PR introduces a major navigation refactor for expense reports. The bug is a regression in the navigation logic that was specifically tested in the PR (Test 6), indicating the logic needs revision before redeployment.

    Labels: Keeping DeployBlockerCash (App deploy blocked). Removing DeployBlocker (this is a frontend-only bug, no backend changes needed).

    📋 Detailed Analysis

    Evidence

    PR #77657 was merged on 2026-01-15 at 11:59:59Z and introduced a new "Super Wide RHP" feature for displaying expense reports. The bug was reported on 2026-01-16 and is staging-only, confirming it was introduced in this deploy. Melvin-bot correctly identified this PR as the cause.

    The PR explicitly tested this scenario in Test 6: "Click the link below the wide RHP title that leads back to the parent report. Verify that the wide RHP correctly returns back to the parent super wide RHP."

    Verification

    The bug occurs in navigation logic modified by the PR:

    • Affected file: src/components/ParentNavigationSubtitle.tsx (48 lines added/12 deleted in PR)
    • Related files: Navigation system files (Navigation.ts, RightModalNavigator.tsx, etc.)

    The PR modifies 64 files across the navigation system, introducing new routes and navigation patterns for super wide RHP.

    Root Cause

    In src/components/ParentNavigationSubtitle.tsx, the onPress handler has logic to handle navigation from a wide RHP (expense detail) back to a super wide RHP (expense report).

    The bug occurs at lines 153-158: When checking if we should navigate to the parent report within the RHP, the code checks if lastRoute?.name === SCREENS.RIGHT_MODAL.SEARCH_MONEY_REQUEST_REPORT. However, lastRoute refers to .at(-1) which is the CURRENT route (SEARCH_REPORT - the expense detail), not the previous route in the stack.

    Actual navigation stack when bug occurs:

    [..., SEARCH_MONEY_REQUEST_REPORT (expense report), SEARCH_REPORT (expense detail)]
                                                         ^ lastRoute points here
    

    The condition at line 155 evaluates to false because lastRoute is SEARCH_REPORT, not SEARCH_MONEY_REQUEST_REPORT. The more specific check at lines 164-173 also doesn't match because it checks for EXPENSE_REPORT, not SEARCH_REPORT.

    As a result, the code falls through to the default navigation (lines 176-179) which uses ROUTES.REPORT_WITH_ID.getRoute(), causing the report to open in the central pane instead of going back to the super wide RHP that was already open.

    Expected behavior: The code should check the previous route (.at(-2)) to detect that SEARCH_MONEY_REQUEST_REPORT is already open for this report and simply go back instead of navigating to a new route.

  7. IuliiaHerets commented on Jan 16, 2026

    @IuliiaHerets

    @mountiny Issue is not reproduced on Web and iOS, build 9.3.3-6

    1768583773823.ScreenRecording_01-16-2026_12-15-14_1.mp4
    1768583511824.498.mp4
  8. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 20, 2026
  9. changed the title [-]Expense report wide RHP closes and it reopens in central pane after clicking header subtitle[/-] [+][Due for payment 2026-01-27] Expense report wide RHP closes and it reopens in central pane after clicking header subtitle[/+] on Jan 20, 2026
  10. melvin-bot commented on Jan 20, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Jan 20, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.4-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-01-27. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Jan 20, 2026

    @melvin-bot

    @ZhenjaHorbach @joekaufmanexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions