You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-01-28] [Payment due 2026-01-27] Distance - Unable to select category when distance default category is deleted #79814
Version Number: 9.3.4-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#79652 Email or phone of affected tester (no customers):odnijosidjoisjdosjsdi@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.1 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Delete Car category (distance default category) in default workspace.
Go to staging.new.expensify.com
Go to self DM or workspace chat.
Click + > Track distance > Manual.
Enter amount > Next.
On confirm page, click Category.
Select any category.
Expected Result:
Selected category will show up on confirm page.
Actual Result:
Selected category does not show up on confirm page. Category cannot be selected.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #79652 - "Distance expense category removed on 2nd policy switch" by @DylanDylann (High confidence) Related Issues: #79598 (original issue that PR #79652 was fixing)
Recommendation: REVERT
PR #79652 introduced a regression while attempting to fix a different bug. The PR added isFocused to the useEffect dependency array in IOURequestStepConfirmation.tsx, which causes the category to be reset when navigating back from the category selection page.
Labels: Keeping DeployBlockerCash (App deploy is blocked)
📋 Detailed Analysis
Evidence
PR #79652 was merged on 2026-01-16 and is included in staging version 9.3.4-0. The issue is reproducible on staging but NOT production, confirming this PR is the cause.
The PR modified src/pages/iou/request/step/IOURequestStepConfirmation.tsx by:
Adding useIsFocused hook
Adding isFocused to the useEffect dependency array (line 418)
Verification
The affected file is src/pages/iou/request/step/IOURequestStepConfirmation.tsx, which PR #79652 directly modified.
The bug report states:
Precondition: Delete "Car" category (the default category for distance expenses)
Steps: Track distance > Manual > Select category > Category does not appear
Only occurs when the default category is deleted
Root Cause
When "Car" is deleted, defaultCategory becomes an empty string. The problematic useEffect (lines 409-418) runs whenever the page becomes focused:
User selects a category (e.g., "Food") and navigates back
Confirmation page becomes focused, triggering the useEffect
Due to timing/race conditions, item?.category may not be set yet
The useEffect calls setMoneyRequestCategory(item.transactionID, defaultCategory, policy)
Since defaultCategory is empty (Car was deleted), this clears the user's selected category
The category selection is lost
The original PR #79652 was trying to fix a different bug (category removed on 2nd policy switch), but the addition of isFocused to the dependency array causes the useEffect to run at inappropriate times, specifically when returning from category selection.
changed the title [-]Distance - Unable to select category when Car category is deleted[/-][+]Distance - Unable to select category when distance default category is deleted[/+]on Jan 17, 2026
changed the title [-][Payment due 2026-01-27] Distance - Unable to select category when distance default category is deleted[/-][+][Due for payment 2026-01-28] [Payment due 2026-01-27] Distance - Unable to select category when distance default category is deleted[/+]on Jan 21, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Pujan92@kadiealexander The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Jan 17, 2026
@Julesssss recently merged #79652, but they are OOO right now, so I'll auto-assign someone else.
melvin-bot commentedon Jan 17, 2026
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 17, 2026
Triggered auto assignment to @mountiny (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 17, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 17, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Jan 17, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #79652 - "Distance expense category removed on 2nd policy switch" by @DylanDylann (High confidence)
Related Issues: #79598 (original issue that PR #79652 was fixing)
Recommendation: REVERT
PR #79652 introduced a regression while attempting to fix a different bug. The PR added
isFocusedto the useEffect dependency array in IOURequestStepConfirmation.tsx, which causes the category to be reset when navigating back from the category selection page.Labels: Keeping
DeployBlockerCash(App deploy is blocked)📋 Detailed Analysis
Evidence
PR #79652 was merged on 2026-01-16 and is included in staging version 9.3.4-0. The issue is reproducible on staging but NOT production, confirming this PR is the cause.
The PR modified
src/pages/iou/request/step/IOURequestStepConfirmation.tsxby:useIsFocusedhookisFocusedto the useEffect dependency array (line 418)Verification
The affected file is
src/pages/iou/request/step/IOURequestStepConfirmation.tsx, which PR #79652 directly modified.The bug report states:
Root Cause
When "Car" is deleted,
defaultCategorybecomes an empty string. The problematic useEffect (lines 409-418) runs whenever the page becomes focused:The bug flow:
item?.categorymay not be set yetsetMoneyRequestCategory(item.transactionID, defaultCategory, policy)defaultCategoryis empty (Car was deleted), this clears the user's selected categoryThe original PR #79652 was trying to fix a different bug (category removed on 2nd policy switch), but the addition of
isFocusedto the dependency array causes the useEffect to run at inappropriate times, specifically when returning from category selection.[-]Distance - Unable to select category when Car category is deleted[/-][+]Distance - Unable to select category when distance default category is deleted[/+]23 remaining items
Julesssss commentedon Jan 21, 2026
Ah thanks! I saw a deploy blocker and raised the revert PR, didn't see this second one!
[-][Payment due 2026-01-27] Distance - Unable to select category when distance default category is deleted[/-][+][Due for payment 2026-01-28] [Payment due 2026-01-27] Distance - Unable to select category when distance default category is deleted[/+]melvin-bot commentedon Jan 21, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-01-28. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 21, 2026
@Pujan92 @kadiealexander The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Jan 22, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
kadiealexander commentedon Jan 27, 2026
^ Deploy blocker above is not a regression
kadiealexander commentedon Jan 27, 2026
@Pujan92 please complete the checklist!
Pujan92 commentedon Jan 28, 2026
I think we don't need a checklist here as it's DB and the original author has raised a fix for this.
Regression Test Proposal
Precondition:
kadiealexander commentedon Jan 29, 2026
Payment Summary
twisterdotcom commentedon Jan 29, 2026
@Pujan92 has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-bbff-a01a-5fc9-405c40bdcda4