You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense report still shows Concierge message on LHN when it is hidden in the expense report #79817
Version Number: 9.3.4-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#78519 Email or phone of affected tester (no customers):jsodijnsodijsosio@gmail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Mac 26.1 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Create two expenses without category.
Wait for Concierge message to show up on LHN.
Go to workspace settings > More features.
Disable Categories.
Go back to Inbox.
Open the transaction thread from LHN.
Expected Result:
Expense report will not show Concierge message on LHN because it is hidden in the expense report.
Actual Result:
Expense report still shows Concierge message on LHN when it is hidden in the expense report.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #78519 - "fix: hide categorize whisper message when categories are disabled" by @etCoderDysto (High confidence) Related Issues: #75276, #77838
Recommendation: ROLL FORWARD
The fix is straightforward and less risky than reverting. PR #78519 partially fixed the issue by updating the report view to hide the Concierge categorize whisper message when categories are disabled. However, it missed updating the LHN (Left Hand Navigation) logic. The function shouldReportActionBeVisibleAsLastAction needs to be updated to accept and pass the policy parameter to shouldReportActionBeVisible.
Labels: Keeping DeployBlockerCash - this is a frontend bug requiring an App PR fix.
📋 Detailed Analysis
Evidence
PR #78519 was merged on 2026-01-16 at 11:53:26Z and is included in the StagingDeployCash checklist for version 9.3.4-0. The bug report confirms the issue appears in staging version 9.3.4-0 and involves the exact feature area modified by this PR (Concierge categorize whisper messages when categories are disabled).
The reproduction steps in the bug report perfectly match the QA steps from PR #78519, confirming this PR introduced the regression.
src/libs/ReportActionsUtils.ts - Added policy parameter to shouldReportActionBeVisible() and logic to hide Concierge categorize messages when !policy.areCategoriesEnabled
src/pages/home/report/ReportActionsView.tsx - Passes policy to shouldReportActionBeVisible()
src/libs/OptionsListUtils/index.ts - Passes policy to shouldReportActionBeVisible()
However, the PR did NOT update shouldReportActionBeVisibleAsLastAction() in ReportActionsUtils.ts (line 1126-1142), which is used by the LHN to determine what message to show. This function calls shouldReportActionBeVisible() at line 1138 but does not pass the policy parameter, so the new hiding logic is bypassed for LHN display.
@Beamanator The blocker was "How do you want to categorize" message was displayed on LHN while "How do you want to categorize" whisper message was not being displayed in chat as we hide it when category feature is disabled. But now both the whisper message and the LHN message are displayed. The same happens on production too.
Activity
melvin-bot commentedon Jan 17, 2026
@inimaga recently merged #78519, but they are OOO right now, so I'll auto-assign someone else.
melvin-bot commentedon Jan 17, 2026
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 17, 2026
Triggered auto assignment to @mollfpr (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 17, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 17, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Jan 17, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #78519 - "fix: hide categorize whisper message when categories are disabled" by @etCoderDysto (High confidence)
Related Issues: #75276, #77838
Recommendation: ROLL FORWARD
The fix is straightforward and less risky than reverting. PR #78519 partially fixed the issue by updating the report view to hide the Concierge categorize whisper message when categories are disabled. However, it missed updating the LHN (Left Hand Navigation) logic. The function
shouldReportActionBeVisibleAsLastActionneeds to be updated to accept and pass the policy parameter toshouldReportActionBeVisible.Labels: Keeping
DeployBlockerCash- this is a frontend bug requiring an App PR fix.📋 Detailed Analysis
Evidence
PR #78519 was merged on 2026-01-16 at 11:53:26Z and is included in the StagingDeployCash checklist for version 9.3.4-0. The bug report confirms the issue appears in staging version 9.3.4-0 and involves the exact feature area modified by this PR (Concierge categorize whisper messages when categories are disabled).
The reproduction steps in the bug report perfectly match the QA steps from PR #78519, confirming this PR introduced the regression.
Verification
PR #78519 modified the following files:
src/libs/ReportActionsUtils.ts- Added policy parameter toshouldReportActionBeVisible()and logic to hide Concierge categorize messages when!policy.areCategoriesEnabledsrc/pages/home/report/ReportActionsView.tsx- Passes policy toshouldReportActionBeVisible()src/libs/OptionsListUtils/index.ts- Passes policy toshouldReportActionBeVisible()However, the PR did NOT update
shouldReportActionBeVisibleAsLastAction()in ReportActionsUtils.ts (line 1126-1142), which is used by the LHN to determine what message to show. This function callsshouldReportActionBeVisible()at line 1138 but does not pass the policy parameter, so the new hiding logic is bypassed for LHN display.Root Cause
The incomplete fix in PR #78519 results in:
shouldReportActionBeVisibleAsLastAction()doesn't pass the policy parameterThe function at line 1138 of
src/libs/ReportActionsUtils.tscalls:But should call:
This function is used in:
src/components/LHNOptionsList/LHNOptionsList.tsx(line 250) to filter actions for LHN displaymollfpr commentedon Jan 19, 2026
@etCoderDysto @akinwale Could you take a look on this? Thanks!
8 remaining items
etCoderDysto commentedon Jan 19, 2026
@Beamanator The blocker was "How do you want to categorize" message was displayed on LHN while "How do you want to categorize" whisper message was not being displayed in chat as we hide it when category feature is disabled. But now both the whisper message and the LHN message are displayed. The same happens on production too.
After Reverting The PR
Before Reverting The PR
Beamanator commentedon Jan 19, 2026
Aah ok so this is actually NAB now 👍 👍 thanks @etCoderDysto !
etCoderDysto commentedon Jan 19, 2026
Yes,
You are welcome 🙏
garrettmknight commentedon Jan 27, 2026
What's the next step here?
Beamanator commentedon Jan 27, 2026
I believeeeeeee we left this as "there's a NAB bug" so we should probs open it up externally @mollfpr
mollfpr commentedon Jan 27, 2026
We can close this, it's back to the original issue now #75276. 🙏