Skip to content

Expense report still shows Concierge message on LHN when it is hidden in the expense report #79817

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.4-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #78519
Email or phone of affected tester (no customers): jsodijnsodijsosio@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create two expenses without category.
  4. Wait for Concierge message to show up on LHN.
  5. Go to workspace settings > More features.
  6. Disable Categories.
  7. Go back to Inbox.
  8. Open the transaction thread from LHN.

Expected Result:

Expense report will not show Concierge message on LHN because it is hidden in the expense report.

Actual Result:

Expense report still shows Concierge message on LHN when it is hidden in the expense report.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7051518_1768614955900.3.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 17, 2026
  2. melvin-bot commented on Jan 17, 2026

    @melvin-bot

    @inimaga recently merged #78519, but they are OOO right now, so I'll auto-assign someone else.

  3. melvin-bot commented on Jan 17, 2026

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Jan 17, 2026

    @melvin-bot

    Triggered auto assignment to @mollfpr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Jan 17, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. github-actions commented on Jan 17, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. OSBotify commented on Jan 17, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #78519 - "fix: hide categorize whisper message when categories are disabled" by @etCoderDysto (High confidence)
    Related Issues: #75276, #77838

    Recommendation: ROLL FORWARD

    The fix is straightforward and less risky than reverting. PR #78519 partially fixed the issue by updating the report view to hide the Concierge categorize whisper message when categories are disabled. However, it missed updating the LHN (Left Hand Navigation) logic. The function shouldReportActionBeVisibleAsLastAction needs to be updated to accept and pass the policy parameter to shouldReportActionBeVisible.

    Labels: Keeping DeployBlockerCash - this is a frontend bug requiring an App PR fix.

    📋 Detailed Analysis

    Evidence

    PR #78519 was merged on 2026-01-16 at 11:53:26Z and is included in the StagingDeployCash checklist for version 9.3.4-0. The bug report confirms the issue appears in staging version 9.3.4-0 and involves the exact feature area modified by this PR (Concierge categorize whisper messages when categories are disabled).

    The reproduction steps in the bug report perfectly match the QA steps from PR #78519, confirming this PR introduced the regression.

    Verification

    PR #78519 modified the following files:

    1. src/libs/ReportActionsUtils.ts - Added policy parameter to shouldReportActionBeVisible() and logic to hide Concierge categorize messages when !policy.areCategoriesEnabled
    2. src/pages/home/report/ReportActionsView.tsx - Passes policy to shouldReportActionBeVisible()
    3. src/libs/OptionsListUtils/index.ts - Passes policy to shouldReportActionBeVisible()

    However, the PR did NOT update shouldReportActionBeVisibleAsLastAction() in ReportActionsUtils.ts (line 1126-1142), which is used by the LHN to determine what message to show. This function calls shouldReportActionBeVisible() at line 1138 but does not pass the policy parameter, so the new hiding logic is bypassed for LHN display.

    Root Cause

    The incomplete fix in PR #78519 results in:

    • ✅ Report view correctly hides the Concierge categorize whisper message when categories are disabled
    • ❌ LHN still shows the message because shouldReportActionBeVisibleAsLastAction() doesn't pass the policy parameter

    The function at line 1138 of src/libs/ReportActionsUtils.ts calls:

    shouldReportActionBeVisible(reportAction, reportAction.reportActionID, canUserPerformWriteAction)

    But should call:

    shouldReportActionBeVisible(reportAction, reportAction.reportActionID, canUserPerformWriteAction, policy)

    This function is used in:

    • src/components/LHNOptionsList/LHNOptionsList.tsx (line 250) to filter actions for LHN display
    • Other locations that determine the last visible action of a report
  8. mollfpr commented on Jan 19, 2026

    @mollfpr
    Contributor

    @etCoderDysto @akinwale Could you take a look on this? Thanks!

  9. 8 remaining items

  10. etCoderDysto commented on Jan 19, 2026

    @etCoderDysto
    Contributor

    @mollfpr @etCoderDysto looks like the revert didn't fix it? 🤷

    @Beamanator The blocker was "How do you want to categorize" message was displayed on LHN while "How do you want to categorize" whisper message was not being displayed in chat as we hide it when category feature is disabled. But now both the whisper message and the LHN message are displayed. The same happens on production too.

    After Reverting The PR

    Image

    Before Reverting The PR

    Image
  11. Beamanator commented on Jan 19, 2026

    @Beamanator
    Contributor

    Aah ok so this is actually NAB now 👍 👍 thanks @etCoderDysto !

  12. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 19, 2026
  13. etCoderDysto commented on Jan 19, 2026

    @etCoderDysto
    Contributor

    Aah ok so this is actually NAB now 👍 👍 thanks @etCoderDysto !

    Yes,

    You are welcome 🙏

  14. garrettmknight commented on Jan 27, 2026

    @garrettmknight
    Contributor

    What's the next step here?

  15. Beamanator commented on Jan 27, 2026

    @Beamanator
    Contributor

    I believeeeeeee we left this as "there's a NAB bug" so we should probs open it up externally @mollfpr

  16. mollfpr commented on Jan 27, 2026

    @mollfpr
    Contributor

    We can close this, it's back to the original issue now #75276. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions