You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Withdrawn - Withdrawn exposed filter is not displayed for the first time applying #79820
Version Number: 9.3.4-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/folder/13176922/test-cases/44231135 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Bug source: Regression TC Execution Device used: iPhone 15 iOS 26.1 App Component: Search
Action Performed:
Sign in to ND with a new gmail account
On onboarding select "Manage my team's expenses" - 1-10 - QBO
create an expense in the workspace chat
Navigate to the Reports/ Expenses
Open advanced filters, tap Withdrawn - Last month - Save - View results
Expected Result:
Filter pill with the value "Withdrawn: Last month" appears in the filters bar
Actual Result:
Withdrawn exposed filter appears in the filter bar briefly, then disappears, when applying for the first time
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #78091 - "[CFI] Add group-by columns (V2)" by @mohammadjafarinejad (High confidence) Related Issues: None identified
Recommendation: REVERT
PR #78091 introduces new group-by functionality and modifies the Search component with the useMultipleSnapshots hook. While the PR does not directly modify SearchFiltersBar.tsx, it changes how search data is fetched and rendered, which appears to have introduced a timing/synchronization issue affecting filter pill display.
Labels: Keeping DeployBlockerCash - this is a frontend bug requiring an App PR fix.
Detailed Analysis
Evidence
Bug affects the "Withdrawn" filter pill disappearing briefly when first applied on iOS app (v9.3.4-0)
Reproducible on staging but NOT production, indicating the cause is in the current staging deploy (v9.3.4-0)
Adds new useMultipleSnapshots hook for group-by functionality
Changes how search results are processed and rendered
These changes likely altered the timing of when Onyx state updates relative to component renders
Why This Affects Withdrawn Filter Specifically
The withdrawn filter (like posted, date, etc.) depends on checking multiple form fields (On/After/Before). This makes it more susceptible to timing issues where the form state hasn not fully populated yet.
Classification: Frontend bug Causing PR: #78091 - "[CFI] Add group-by columns (V2)" by @mohammadjafarinejad (High confidence) Related Issues: None identified
Recommendation: REVERT
PR #78091 introduces URL normalization logic that triggers navigation when the queryJSON differs from the URL. This creates a race condition where the Onyx form state (searchAdvancedFiltersForm) becomes temporarily out of sync with the URL-derived filter values, causing the withdrawn filter pill to briefly disappear and then reappear.
Labels: Keeping DeployBlockerCash - this is a frontend bug requiring an App PR revert or fix.
📋 Detailed Analysis
Evidence
Bug affects the "Withdrawn" filter pill disappearing briefly when first applied on iOS app (v9.3.4-0)
Reproducible on staging but NOT production, confirming the cause is in the current staging deploy
This checks the Onyx form state instead of the URL-derived values from filterFormValues.
Why Withdrawn Filter Specifically
The withdrawn filter is more susceptible because it checks multiple form fields (On/After/Before), making it more likely to encounter the timing issue where none of these fields are populated yet during the transition.
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Couldn't figure out the PR. It was there since a long time.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not needed
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Sign in with a new Gmail account
On onboarding select Manage my team's expenses → 1-10 → QBO
Create an expense in the workspace chat
Navigate to Search → Expenses
Open advanced filters, tap Withdrawn → Last month → Save → View results
Verify the filter pill "Withdrawn: Last month" appears in the filter bar and stays visible (does not flash and disappear)
Activity
melvin-bot commentedon Jan 17, 2026
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 17, 2026
Triggered auto assignment to @cead22 (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 17, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 17, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Jan 17, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #78091 - "[CFI] Add group-by columns (V2)" by @mohammadjafarinejad (High confidence)
Related Issues: None identified
Recommendation: REVERT
PR #78091 introduces new group-by functionality and modifies the Search component with the
useMultipleSnapshotshook. While the PR does not directly modify SearchFiltersBar.tsx, it changes how search data is fetched and rendered, which appears to have introduced a timing/synchronization issue affecting filter pill display.Labels: Keeping DeployBlockerCash - this is a frontend bug requiring an App PR fix.
Detailed Analysis
Evidence
Root Cause Analysis
Looking at
src/components/Search/SearchPageHeader/SearchFiltersBar.tsx(lines 543-546):The logic for displaying the withdrawn filter pill depends on
searchAdvancedFiltersForm(Onyx form state). When filters are first applied:filterFormValueshook derives values from queryJSONsearchAdvancedFiltersForm(the Onyx form state) may not be immediately synchronizedshouldDisplayWithdrawnFilterreturns false even though the filter is activeVerification
src/components/Search/index.tsxuseMultipleSnapshotshook for group-by functionalityWhy This Affects Withdrawn Filter Specifically
The withdrawn filter (like posted, date, etc.) depends on checking multiple form fields (On/After/Before). This makes it more susceptible to timing issues where the form state hasn not fully populated yet.
twisterdotcom commentedon Jan 19, 2026
Also cc @luacmartins from columns fame.
OSBotify commentedon Jan 19, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #78091 - "[CFI] Add group-by columns (V2)" by @mohammadjafarinejad (High confidence)
Related Issues: None identified
Recommendation: REVERT
PR #78091 introduces URL normalization logic that triggers navigation when the queryJSON differs from the URL. This creates a race condition where the Onyx form state (
searchAdvancedFiltersForm) becomes temporarily out of sync with the URL-derived filter values, causing the withdrawn filter pill to briefly disappear and then reappear.Labels: Keeping
DeployBlockerCash- this is a frontend bug requiring an App PR revert or fix.📋 Detailed Analysis
Evidence
Verification
PR #78091 modifies core Search infrastructure:
src/pages/Search/SearchPage.tsx- Adds new useEffect for URL normalization (lines 226-236 in the diff)src/components/Search/index.tsx- IntroducesuseMultipleSnapshotshook and changes data flowsrc/hooks/useMultipleSnapshots.ts- New hook for fetching group-by transaction snapshotsThe new URL normalization effect:
This effect triggers navigation when Peggy parser normalizes the query (e.g., adding default sortBy/sortOrder).
Root Cause
The bug occurs due to a timing issue between two data sources in
SearchFiltersBar.tsx:searchAdvancedFiltersForm- Onyx form state (used to determine if withdrawn filter should display)filterFormValues- Derived from queryJSON viauseFilterFormValueshookThe race condition:
filterFormValues(from queryJSON) immediately reflects the filtershouldDisplayWithdrawnFilterevaluates to truesearchAdvancedFiltersForm(Onyx) hasn not synced yetshouldDisplayWithdrawnFiltertemporarily becomes false → pill disappearsCode path (SearchFiltersBar.tsx line 548):
This checks the Onyx form state instead of the URL-derived values from
filterFormValues.Why Withdrawn Filter Specifically
The withdrawn filter is more susceptible because it checks multiple form fields (On/After/Before), making it more likely to encounter the timing issue where none of these fields are populated yet during the transition.
73 remaining items
melvin-bot commentedon Mar 24, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)mallenexpensify commentedon Mar 24, 2026
Payment Summary
Contributor: @mohammadjafarinejad paid $250 via Upwork
Contributor+: @parasharrajat due $250 via NewDot
@mohammadjafarinejad can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022036550020147765911
melvin-bot commentedon Mar 27, 2026
@mohammadjafarinejad Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Mar 27, 2026
@mohammadjafarinejad Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
parasharrajat commentedon Mar 28, 2026
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Couldn't figure out the PR. It was there since a long time.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not needed
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
parasharrajat commentedon Mar 28, 2026
@mallenexpensify Can we close this?
cc: @mohammadjafarinejad Did you accept the job?
mohammadjafarinejad commentedon Mar 29, 2026
@mallenexpensify Accepted the offer, thanks!
luacmartins commentedon Mar 30, 2026
Seems like we're good to close.
mallenexpensify commentedon Apr 2, 2026
@mohammadjafarinejad paid, summary updated above. Thx.
parasharrajat commentedon Apr 20, 2026
Payment requested as per #79820 (comment)
garrettmknight commentedon Apr 23, 2026
$250 approved for @parasharrajat