Skip to content

[Due for payment 2026-03-06] Remove Onyx.connect() for the key: ONYXKEYS.NVP_RECENT_WAYPOINTS in src/libs/actions/IOU/MoneyRequest.ts #80267

Closed

Description

@tgolen

This is part of deprecating Onyx.connect. Parent Issue

Details

Be sure to refactor methods using test driven development:

  1. Create a unit test for methods before refactoring
  2. Refactor the methods
  3. Ensure the unit test still runs after refactoring
  4. Reinforce the unit testing with a functional test and a QA test
  5. Once you are done, decrease the number of allowable ESLint warnings here to equal the number of Onyx.connect references remaining in the code
Issue OwnerCurrent Issue Owner: @laurenreidexpensify

Activity

  1. melvin-bot commented on Jan 22, 2026

    @melvin-bot

    Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.

  2. Guccio163 commented on Feb 16, 2026

    @Guccio163
    Contributor

    Hi @tgolen, I'm in the process of creating PRs, yet to add test steps and recordings; After these two PRs (and simultaneous one from Duplicate.ts) there will be one more PR with migrating getRecentWaypoints from handleMoneyRequestStepScanParticipants (from MoneyRequest.ts file so in this issue) and we'll get rid of getRecentWaypoints from IOU/index.ts 🔜

  3. melvin-bot commented on Feb 19, 2026

    @melvin-bot

    Triggered auto assignment to @mollfpr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  4. 15 remaining items

  5. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @laurenreidexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  6. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@laurenreidexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  7. parasharrajat commented on Mar 7, 2026

    @parasharrajat
    Member

    I will collect the List of Prs for this today.

  8. melvin-bot commented on Mar 9, 2026

    @melvin-bot

    @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  9. melvin-bot commented on Mar 9, 2026

    @melvin-bot

    @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  10. tgolen commented on Mar 10, 2026

    @tgolen
    ContributorAuthor

    Thanks @parasharrajat. @laurenreidexpensify please pay $750 for this issue.

  11. laurenreidexpensify commented on Mar 11, 2026

    @laurenreidexpensify
    Contributor

    Payment Summary

  12. parasharrajat commented on Mar 19, 2026

    @parasharrajat
    Member

    Payment requested as per #80267 (comment)

  13. twisterdotcom commented on Mar 23, 2026

    @twisterdotcom
    Contributor

    Confirming Payment Summary. @parasharrajat paid via New Expensify

  14. added
    Skip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.
    on Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringImprovementItem broken or needs improvement.Skip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions