Skip to content

[Due for payment 2026-03-25] [Due for payment 2026-03-11] Split context providers to return State and Actions separately #80271

Closed

Description

@mountiny

Coming from here

Background:

Currently, our contexts return a single Context.Provider whose value prop is an object composed of both state and associated callback functions. In most cases, the context is paired with a dedicated hook that provides a convenient and type-safe way for components to consume it. Any change to the context value triggers a re-render of all subscribed components.

Problem

Components that consume only actions from a context provider are still subject to re-renders on context updates, even when they do not directly depend on the provider’s state. It causes higher number of re-renders all across the app.

Solution

Let’s separate State and Actions within the context providers. By exposing two independent providers—one for state and one for actions—we allow components to subscribe only to what they actually need:

  • Components that depend on state will re-render only when state changes.
  • Components that use only actions will remain stable and will not re-render in response to state updates.

This separation reduces unnecessary re-renders, improves performance, and makes the intent of each consumer more explicit. It also encourages a clearer mental model by distinguishing between data and behavior at the context level.

Example PR that has improved the performance of the SearchRouter: #79753

Additional note

This also presents an opportunity to do a small cleanup of our context usage. One area for improvement is standardizing how contexts are exposed to consumers by introducing dedicated hooks for each context. Currently, some contexts provide a custom hook (e.g. useExpensifyCardContext), while others are accessed directly via useContext in components (e.g. useContext(KYCWallContext)).

There is also a minor inconsistency in naming conventions, where some providers end with ContextProvider and others with Provider.

While none of this is critical, addressing it as part of this change would improve overall consistency and readability across the codebase.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. 46 remaining items

  2. melvin-bot commented on Mar 18, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  3. melvin-bot commented on Mar 18, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.39-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-25. 🎊

    For reference, here are some details about the assignees on this issue:

    • @staszekscp does not require payment (Contractor)
    • @mkhutornyi requires payment through NewDot Manual Requests
  4. melvin-bot commented on Mar 25, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  5. mallenexpensify commented on Mar 26, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @mkhutornyi due $250 via NewDot

    Do we want a test case for this? Close if not. Tag me if so

  6. mallenexpensify commented on Apr 1, 2026

    @mallenexpensify
    Contributor

    @mountiny 👀 above for payment amount for @mkhutornyi .

  7. mountiny commented on Apr 9, 2026

    @mountiny
    ContributorAuthor

    Overall I think these PRs been large but quite straightforward so I would go with $125 for each PR if that is ok @mkhutornyi to $1250 total

  8. mkhutornyi commented on Apr 9, 2026

    @mkhutornyi
    Contributor

    How about $1375 considering #81986 (1.3k lines of code) as standard rate?

  9. mountiny commented on Apr 10, 2026

    @mountiny
    ContributorAuthor

    Sounds good! @mkhutornyi

  10. mallenexpensify commented on Apr 13, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @mkhutornyi due $1375 via NewDot

    I think we're good here, comment/reopen if now

  11. trjExpensify commented on May 6, 2026

    @trjExpensify
    Contributor

    approved $1,375 for @mkhutornyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionTaskWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions