Skip to content

[Due for payment 2026-11-20] [$1000] Consolidate DecisionModals into a global component #80285

Closed
4 of 4 issues completed

Description

@roryabraham

Following up on #68799 with another common modal type.

Problem

When every component mounts its own DecisionModal in the component tree, it creates component bloat, memory overhead from multiple modal instances, and repetitive boilerplate code that makes the application harder to maintain.

Solution

Lift a single DecisionModal instance up in the component tree so that it can be shared across the app. Child components can use context to show and hide the shared DecisionModal with whatever props they want to pass to it. Internally, the state of the DecisionModal is a stack (allowing for multi-step confirmations, one of our UI requirements), and that state is managed through React Context.

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 22, 2026
  2. melvin-bot commented on Jan 22, 2026

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. roryabraham commented on Jan 23, 2026

    @roryabraham
    ContributorAuthor

    Going to try taking the quicker/cheaper path here and do this refactoring in one go, rather than in many incremental PRs as we have done for ConfirmModal, relying on Applause for pre-merge regression testing. I understand it makes the single PR riskier, but:

    • we haven't really seen issues rolling this change out
    • it seemed to work fine with my local smoke tests
    • if this works out it's much faster and cheaper
  4. roryabraham commented on Jan 26, 2026

    @roryabraham
    ContributorAuthor

    QA ongoing - one issue reported but it seems like expected behavior

  5. 75 remaining items

  6. ZhenjaHorbach commented on Nov 18, 2026

    @ZhenjaHorbach
    Contributor

    All done then @ZhenjaHorbach? Just awaiting payment?

    Yep
    And by the way
    Since it's an old project with old prices, and since this issue included 4 main PRs and 2 additional ones, and testing each PR took quite a lot of time
    Can we set 1000$ here, please?

  7. roryabraham commented on Nov 18, 2026

    @roryabraham
    ContributorAuthor

    $1000 sounds reasonable for the scope of this issue 👍🏼

  8. changed the title [-][Due for payment 2026-11-20] [$175] Consolidate DecisionModals into a global component[/-] [+][Due for payment 2026-11-20] [$1000] Consolidate DecisionModals into a global component[/+] on Nov 18, 2026
  9. melvin-bot commented on Nov 18, 2026

    @melvin-bot

    ⚠️ This issue has had its price increased by 4x or more. Please review the issue and ensure the price is correct.

  10. melvin-bot commented on Nov 18, 2026

    @melvin-bot

    Upwork job price has been updated to $1000

  11. expensify-chore-bot commented on Nov 18, 2026

    @expensify-chore-bot

    Current assignee @mallenexpensify is eligible for the Awaiting Payment assigner, not assigning anyone new.

  12. expensify-chore-bot commented on Nov 19, 2026

    @expensify-chore-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  13. mallenexpensify commented on Nov 21, 2026

    @mallenexpensify
    Contributor

    Claude posting on behalf of Matt:

    Ready. Job price: $1000 (roryabraham set it in the title, 2026-11-18).

    • ZhenjaHorbach (Contributor): 100%, via NewDot

    ZhenjaHorbach asked for $1000 in a free-form comment, not the C+ template. roryabraham agreed and set the title.

    ZhenjaHorbach says no checklist is needed.

    Next: pay. No Caps+Y.

    Evidence
    • PR 106391: by MelvinBot, merged 2026-11-10, production 2026-11-12, approved by ZhenjaHorbach and roryabraham. No revert.
    • PR 106469: by ZhenjaHorbach, merged 2026-11-11, production 2026-11-13, approved by roryabraham. No revert.
    • 106595 came up in QA of 106391. The report says it reproduces on production. ZhenjaHorbach says it is not from the migration.
    • ZhenjaHorbach was assigned 2026-01-22. Without the title price, the job price is $250.
    • Test videos: C+ 5/5 on 106391.

    PAYPREP v1

  14. mallenexpensify commented on Nov 21, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @ZhenjaHorbach due $1000 via NewDot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions