You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-11-20] [$1000] Consolidate DecisionModals into a global component #80285
Following up on #68799 with another common modal type.
Problem
When every component mounts its own DecisionModal in the component tree, it creates component bloat, memory overhead from multiple modal instances, and repetitive boilerplate code that makes the application harder to maintain.
Solution
Lift a single DecisionModal instance up in the component tree so that it can be shared across the app. Child components can use context to show and hide the shared DecisionModal with whatever props they want to pass to it. Internally, the state of the DecisionModal is a stack (allowing for multi-step confirmations, one of our UI requirements), and that state is managed through React Context.
Going to try taking the quicker/cheaper path here and do this refactoring in one go, rather than in many incremental PRs as we have done for ConfirmModal, relying on Applause for pre-merge regression testing. I understand it makes the single PR riskier, but:
we haven't really seen issues rolling this change out
Yep
And by the way
Since it's an old project with old prices, and since this issue included 4 main PRs and 2 additional ones, and testing each PR took quite a lot of time
Can we set 1000$ here, please?
changed the title [-][Due for payment 2026-11-20] [$175] Consolidate DecisionModals into a global component[/-][+][Due for payment 2026-11-20] [$1000] Consolidate DecisionModals into a global component[/+]on Nov 18, 2026
Activity
melvin-bot commentedon Jan 22, 2026
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.roryabraham commentedon Jan 23, 2026
Going to try taking the quicker/cheaper path here and do this refactoring in one go, rather than in many incremental PRs as we have done for
ConfirmModal, relying on Applause for pre-merge regression testing. I understand it makes the single PR riskier, but:roryabraham commentedon Jan 26, 2026
QA ongoing - one issue reported but it seems like expected behavior
75 remaining items
ZhenjaHorbach commentedon Nov 18, 2026
Yep
And by the way
Since it's an old project with old prices, and since this issue included 4 main PRs and 2 additional ones, and testing each PR took quite a lot of time
Can we set 1000$ here, please?
roryabraham commentedon Nov 18, 2026
$1000 sounds reasonable for the scope of this issue 👍🏼
[-][Due for payment 2026-11-20] [$175] Consolidate DecisionModals into a global component[/-][+][Due for payment 2026-11-20] [$1000] Consolidate DecisionModals into a global component[/+]melvin-bot commentedon Nov 18, 2026
melvin-bot commentedon Nov 18, 2026
Upwork job price has been updated to $1000
expensify-chore-bot commentedon Nov 18, 2026
Current assignee @mallenexpensify is eligible for the Awaiting Payment assigner, not assigning anyone new.
expensify-chore-bot commentedon Nov 19, 2026
Payment Summary
Resolving PRs:
Migrate saved-search decisions to the global modal #106391
[No QA] Deprecate components/DecisionModal #106469
Reviewer: @ZhenjaHorbach owed $1000 via NewDot
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Nov 21, 2026
Claude posting on behalf of Matt:
Ready. Job price: $1000 (roryabraham set it in the title, 2026-11-18).
ZhenjaHorbach asked for $1000 in a free-form comment, not the C+ template. roryabraham agreed and set the title.
ZhenjaHorbach says no checklist is needed.
Next: pay. No Caps+Y.
Evidence
PAYPREP v1mallenexpensify commentedon Nov 21, 2026
Payment Summary
Contributor+: @ZhenjaHorbach due $1000 via NewDot