You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense - Expense preview persists and opens not here page after deleting moved IOU expense #80305
Version Number: 9.3.7-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#78634 Email or phone of affected tester (no customers):sjidonjodjsodsjoi@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.1 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Have at least one workspace.
Go to staging.new.expensify.com
Open 1:1 DM with any user.
Submit an expense to the user.
Open the report.
Click More > Change workspace.
Select a workspace.
Click More > Delete.
Delete the expense.
Go to the workspace chat where the IOU expense was moved to in Step 6.
Click on the expense preview.
Expected Result:
Expense preview should be removed from workspace chat after moving IOU expense to workspace and deleting the expense.
Actual Result:
Expense preview is not removed from workspace chat after moving IOU expense to workspace and deleting the expense.
Not here page opens after opening the expense preview.
On Android and iOS, the expense preview is not responsive.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #78634 - "new Onyx Derived Value VISIBLE_REPORT_ACTIONS" by @BartekObudzinski (High confidence) Related Issues: None identified
Recommendation: REVERT
This PR introduced a performance optimization by pre-computing report action visibility in a derived Onyx value. However, the implementation does not properly handle dynamic visibility state changes for REPORT_PREVIEW actions, specifically the shouldShow property that gets set to false when an expense is deleted.
The bug occurs because:
The derived value caches visibility at computation time
When an expense is moved and deleted, the REPORT_PREVIEW action's shouldShow property changes to false
The derived value does not recompute for this property change, causing stale visibility data
The expense preview persists in the workspace chat despite being deleted
The issue reports that after moving an IOU expense to a workspace and deleting it (steps 1-8), the expense preview persists in the workspace chat (steps 9-10) and opens a "Not here" page. This is reproducible on staging but not production, confirming it's from a recent staging PR.
PR #78634 was merged on 2026-01-22 and is included in the current staging deploy checklist (issue #80277). The PR introduced VISIBLE_REPORT_ACTIONS derived value to pre-compute visibility for performance optimization.
The backend sets shouldShow: false on the REPORT_PREVIEW action
The derived value was already computed with shouldShow: true
The change to shouldShow updates the report action in Onyx
The derived value recomputes based on the report action change
BUT the shouldReportActionBeVisible function is called, which checks shouldShow
However, the caching logic in the derived value may not properly invalidate for this specific property change on REPORT_PREVIEW actions
The issue is in the incremental update logic in visibleReportActions.ts - it processes updated actions but the shouldShow property change on a REPORT_PREVIEW might not be properly reflected in the visibility calculation.
Activity
melvin-bot commentedon Jan 23, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #78634
melvin-bot commentedon Jan 23, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Jan 23, 2026
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jan 23, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Jan 23, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #78634 - "new Onyx Derived Value VISIBLE_REPORT_ACTIONS" by @BartekObudzinski (High confidence)
Related Issues: None identified
Recommendation: REVERT
This PR introduced a performance optimization by pre-computing report action visibility in a derived Onyx value. However, the implementation does not properly handle dynamic visibility state changes for REPORT_PREVIEW actions, specifically the
shouldShowproperty that gets set tofalsewhen an expense is deleted.The bug occurs because:
shouldShowproperty changes tofalseLabels: Keeping
DeployBlockerCash(App deploy blocked). RemovingDeployBlocker(backend not involved).Detailed Analysis
Evidence
The issue reports that after moving an IOU expense to a workspace and deleting it (steps 1-8), the expense preview persists in the workspace chat (steps 9-10) and opens a "Not here" page. This is reproducible on staging but not production, confirming it's from a recent staging PR.
PR #78634 was merged on 2026-01-22 and is included in the current staging deploy checklist (issue #80277). The PR introduced
VISIBLE_REPORT_ACTIONSderived value to pre-compute visibility for performance optimization.Verification
PR #78634 modified key files:
src/libs/actions/OnyxDerived/configs/visibleReportActions.ts(new file) - implements the derived valuesrc/pages/home/report/ReportActionsView.tsx- uses the derived value for filteringsrc/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx- uses the derived valuesrc/libs/ReportActionsUtils.ts- exports visibility helper functionsThe derived value dependencies are:
However, the
shouldShowproperty on report actions is not part of these dependencies and changes to it do not trigger recomputation.Root Cause
In
ReportActionsUtils.ts, theisVisiblePreviewOrMoneyRequestfunction checks:When an expense is deleted after being moved:
shouldShow: falseon the REPORT_PREVIEW actionshouldShow: trueshouldShowupdates the report action in OnyxshouldReportActionBeVisiblefunction is called, which checksshouldShowThe issue is in the incremental update logic in
visibleReportActions.ts- it processes updated actions but theshouldShowproperty change on a REPORT_PREVIEW might not be properly reflected in the visibility calculation.chuckdries commentedon Jan 23, 2026
Fixed by #80318
Beamanator commentedon Jan 23, 2026
Ooh sick @chuckdries did you test and confirm that revert fixed it? 🙏
chuckdries commentedon Jan 23, 2026
Yep! Although I'm gonna hold off on testing any of the others until applause finishes the retest request