Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.3.7.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-3292/folder/13176670/55373587/1143584220?q=merge&issue_type=jira
Email or phone of affected tester (no customers): ibellicotest+2250@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app)
App Component: Other
Action Performed:
Prerequisite: Account has at least one workspace.
- Open the Expensify app.
- Open any workspace chat.
- Create two manual expenses in two different reports.
- Open the report of any of the just created expenses.
- Tap on "More" > "Merge"
- Select the second expense.
- Keep all the details from the seconds expense and confirm the merging action.
- Once redirected to chat again, tap on the arrow on the top left corner to return to "Inbox"
- Note that you land on chat again.
- Tap on the back button again.
- Note that now you correctly land on "Inbox"
Expected Result:
When being redirected to chat after merging expenses, back button should redirect to "Inbox".
Actual Result:
When being redirected to chat after merging expenses, back button navigates to chat again.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
Screenshots/Videos
Bug7056061_1769127394547.Merge_Back.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~022015901507255016520
- Upwork Job ID: 2015901507255016520
- Last Price Increase: 2026-03-24
Activity
melvin-bot commentedon Jan 23, 2026
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.shankys commentedon Jan 23, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user merges two expenses and is redirected back to a report/chat, the first back press returns to the same chat again instead of Inbox on Android (narrow layout / small screen/mobile). This makes the back stack feel like it has a duplicate chat entry.
What is the root cause of that problem?
The merge flow uses
Navigation.dismissModalWithReport()after the merge when it needs to open a different report. InConfirmationPage, this runs whenreportID !== targetTransaction.reportIDand the code callsNavigation.dismissModalWithReport({reportID: reportIDToDismiss}).See:
App/src/pages/TransactionMerge/ConfirmationPage.tsx
Lines 95 to 108 in 6e6f87c
On narrow layout (mobile/small‑screen),
dismissModalWithReportdoes not dismiss the modal first; it directly callsnavigate(reportRoute, {forceReplace: true})while the right‑hand modal (RHP) is still the focused screen.That replaces the focused modal route rather than the underlying report route, leaving two report/chat entries in history and requiring two back presses.
See:
App/src/libs/Navigation/Navigation.ts
Lines 730 to 733 in 6e6f87c
What changes do you think we should make in order to solve the problem?
Make the merge flow dismiss the modal first and then replace the underlying report route once the modal is fully closed. This keeps only one report/chat entry in history.
Concretely in
App/src/pages/TransactionMerge/ConfirmationPage.tsx
Lines 95 to 108 in 6e6f87c
elseblock), add a narrow‑layout guard so that narrow layout usesdismissModal+navigate(..., {forceReplace: true})and wide layout keepsdismissModalWithReport:This keeps the change localized to the merge flow, which avoids altering global navigation behavior in other features.
The modal close callback fires when the RightModalNavigator unmounts (it emits
MODAL_EVENTS.CLOSED), which ensures the replacement runs after the modal is dismissed.See:
App/src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx
Line 169 in 6e6f87c
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
truph01 commentedon Jan 23, 2026
Regression from #78966
[-]Chat - After merging expenses, navigating back, leads to chat again.[/-][+][$250] Chat - After merging expenses, navigating back, leads to chat again.[/+]melvin-bot commentedon Jan 26, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022015901507255016520
melvin-bot commentedon Jan 26, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Krishna2323 (
External)dylanexpensify commentedon Jan 26, 2026
@marufsharifi please review
26 remaining items
melvin-bot commentedon Mar 9, 2026
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
melvin-bot commentedon Mar 9, 2026
This issue has not been updated in over 14 days. @dylanexpensify, @Krishna2323 eroding to Weekly issue.
mvtglobally commentedon Mar 15, 2026
Issue not reproducible during KI retests. (Second week)
melvin-bot commentedon Mar 16, 2026
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
melvin-bot commentedon Mar 24, 2026
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
laurenreidexpensify commentedon Mar 26, 2026
Sorry closed by mistake! Although @dylanexpensify can this one be closed?
dylanexpensify commentedon Mar 26, 2026
Seems not reproducible, so let's close!