Skip to content

[$250] Expense - Time expense with 0.00 amount can be submitted for p2p expense #80344

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.6-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #79197
Email or phone of affected tester (no customers): applausetester+sdodjssods@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Log in with Expensifail account.
  • Time tracking is enabled on OD.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Click + > Create expense > Time.
  4. Create a time expense.
  5. Open the time expense.
  6. Click Reports > Remove from report.
  7. Go to self DM.
  8. Open the unreported time expense.
  9. Click on the report header > Submit it to someone.
  10. Select a user.
  11. On confirm page, click Rate.
  12. Enter 0 and save it.
  13. Click Create expense.

Expected Result:

User should not be allowed to submit 0.00 time expense for p2p expense, according to #79197

Actual Result:

User can submit 0.00 time expense for p2p expense

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7055457_1769076924822.15.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022018977453271452040
  • Upwork Job ID: 2018977453271452040
  • Last Price Increase: 2026-02-04
Issue OwnerCurrent Issue Owner: @jjcoffee

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 23, 2026
  2. melvin-bot commented on Jan 23, 2026

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. etCoderDysto commented on Jan 23, 2026

    @etCoderDysto
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Time expense with 0.00 amount can be submitted for p2p expense

    What is the root cause of that problem?

    We are not passing isP2P prop to MoneyRequestAmountForm here

    <MoneyRequestAmountForm
    isEditing
    amount={transaction?.comment?.units?.rate}

    Then isP2P will be false here and isAmountInvalid will return true then the logic to show invalid amount error will be skipped

    if (!currentAmount.length || (!isTaxAmountForm && isAmountInvalid(currentAmount, iouType, isP2P, isBetaEnabled(CONST.BETAS.ZERO_EXPENSES)))) {
    setFormError(translate('iou.error.invalidAmount'));
    return;

    What changes do you think we should make in order to solve the problem?

    We should pass isP2P prop

    const isP2P = isParticipantP2P(transaction?.participants?.at(0));
    
     <MoneyRequestAmountForm 
         isEditing 
         amount={transaction?.comment?.units?.rate} 
         isP2P={isP2P}
    
    

    Similar issues happens on IOURequestStepAmount
    For IOURequestStepAmount, we are trying to use chat report to get the first participant when we are trying to determine if the chat is P2P. When a user is submitting to a new user chat report will be undefined and isP2P will be false. We should fallback to using using transaction when report is undefined

    isP2P={isParticipantP2P(getMoneyRequestParticipantsFromReport(chatReportForP2PCheck, currentUserPersonalDetails.accountID).at(0) ?? transaction?.participants?.at(0))}
    

    We should check other places where similar issue happens and fix them.

    isP2P={isParticipantP2P(getMoneyRequestParticipantsFromReport(chatReportForP2PCheck, currentUserPersonalDetails.accountID).at(0))}

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. melvin-bot commented on Feb 3, 2026

    @melvin-bot

    @JmillsExpensify 10 days overdue. Is anyone even seeing these? Hello?

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 4, 2026
  6. changed the title [-]Expense - Time expense with 0.00 amount can be submitted for p2p expense[/-] [+][$250] Expense - Time expense with 0.00 amount can be submitted for p2p expense[/+] on Feb 4, 2026
  7. melvin-bot commented on Feb 4, 2026

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 4, 2026
  9. melvin-bot commented on Feb 4, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

  10. JmillsExpensify commented on Feb 4, 2026

    @JmillsExpensify
    Contributor

    Actually let's not worry about this. Just going to close.

  11. etCoderDysto commented on Feb 4, 2026

    @etCoderDysto
    Contributor

    @JmillsExpensify the issue is also reproducible for manual, and distance expenses, features which are not under beta.

    Screen.Recording.2026-02-04.at.12.29.25.in.the.afternoon.mp4
  12. JmillsExpensify commented on Feb 11, 2026

    @JmillsExpensify
    Contributor

    That's by design.

  13. JmillsExpensify commented on Feb 11, 2026

    @JmillsExpensify
    Contributor

    Still doesn't change my opinion on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions