Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.3.6-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #79197
Email or phone of affected tester (no customers): applausetester+sdodjssods@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Money Requests
Action Performed:
Precondition:
- Log in with Expensifail account.
- Time tracking is enabled on OD.
- Go to staging.new.expensify.com
- Go to workspace chat.
- Click + > Create expense > Time.
- Create a time expense.
- Open the time expense.
- Click Reports > Remove from report.
- Go to self DM.
- Open the unreported time expense.
- Click on the report header > Submit it to someone.
- Select a user.
- On confirm page, click Rate.
- Enter 0 and save it.
- Click Create expense.
Expected Result:
User should not be allowed to submit 0.00 time expense for p2p expense, according to #79197
Actual Result:
User can submit 0.00 time expense for p2p expense
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
Screenshots/Videos
Bug7055457_1769076924822.15.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~022018977453271452040
- Upwork Job ID: 2018977453271452040
- Last Price Increase: 2026-02-04
Activity
melvin-bot commentedon Jan 23, 2026
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.etCoderDysto commentedon Jan 23, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
Time expense with 0.00 amount can be submitted for p2p expense
What is the root cause of that problem?
We are not passing isP2P prop to
MoneyRequestAmountFormhereApp/src/pages/iou/request/step/IOURequestStepTimeRate.tsx
Lines 82 to 84 in 6e6f87c
Then
isP2Pwill be false here andisAmountInvalidwill return true then the logic to show invalid amount error will be skippedApp/src/pages/iou/MoneyRequestAmountForm.tsx
Lines 172 to 174 in 6e6f87c
What changes do you think we should make in order to solve the problem?
We should pass
isP2PpropSimilar issues happens on
IOURequestStepAmountFor IOURequestStepAmount, we are trying to use chat report to get the first participant when we are trying to determine if the chat is P2P. When a user is submitting to a new user chat report will be undefined and isP2P will be false. We should fallback to using using transaction when report is undefined
We should check other places where similar issue happens and fix them.
App/src/pages/iou/request/step/IOURequestStepAmount.tsx
Line 443 in 6e6f87c
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Feb 3, 2026
@JmillsExpensify 10 days overdue. Is anyone even seeing these? Hello?
[-]Expense - Time expense with 0.00 amount can be submitted for p2p expense[/-][+][$250] Expense - Time expense with 0.00 amount can be submitted for p2p expense[/+]melvin-bot commentedon Feb 4, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022018977453271452040
melvin-bot commentedon Feb 4, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (
External)JmillsExpensify commentedon Feb 4, 2026
Actually let's not worry about this. Just going to close.
etCoderDysto commentedon Feb 4, 2026
@JmillsExpensify the issue is also reproducible for manual, and distance expenses, features which are not under beta.
Screen.Recording.2026-02-04.at.12.29.25.in.the.afternoon.mp4
JmillsExpensify commentedon Feb 11, 2026
That's by design.
JmillsExpensify commentedon Feb 11, 2026
Still doesn't change my opinion on this issue.