Skip to content

[Time Tracking][Bug] Selected workspace not marked with green checkmark for Time expense #80413

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.3.8-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory around #79780
Email or phone of affected tester (no customers): applausetester+ck12326@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 11/Chrome, iPhone 16/iOS 18.7.1, Pixel 8a/Android 16
App Component: Money Requests

Action Performed:

Precondition : Have multiple workspaces (atleast 2 workspaces) with expense chat created & Per Diem & Time tracking enabled ((You might need to open the chat first at least once).

  1. Navigate to staging,new.expensify.com & log in with Expensifail account
  2. Click on the global "+" button.
  3. Click "Create expense".
  4. Verify there should be a "Time" tab with a list of workspaces to choose from.
  5. Choose any workspace
  6. Click RHP back button
  7. Observe selected workspace is not marked with green checkmark
  8. Repeat steps 2-7 with Per Diem expense & observe green checkmark displayed for selected workspace

Expected Result:

On step 7 - Selected workspace should be marked with green checkmark for Time expense as it appears for selected workspace for Per Diem expense

Actual Result:

On step 7 - Selected workspace not marked with green checkmark for Time expense

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7056826_1769215127289.666.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jan 24, 2026
  2. melvin-bot commented on Jan 24, 2026

    @melvin-bot

    @grgia recently merged #79780, but they are OOO right now, so I'll auto-assign someone else.

  3. melvin-bot commented on Jan 24, 2026

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Jan 24, 2026

    @melvin-bot

    Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Jan 24, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. github-actions commented on Jan 24, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. OSBotify commented on Jan 24, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #79780 - "Allow creating time expenses from global menu" by @mhawryluk (High confidence)
    Related Issues: None

    Recommendation: REVERT

    The PR introduces a new Time expense creation flow from the global menu, but has an inconsistency in how it persists the workspace selection compared to Per Diem expenses. When a user selects a workspace for Time expenses and clicks the back button, the green checkmark does not appear, indicating the selection was not properly saved to the transaction. This is a user experience issue that makes it appear the selection was lost.

    Labels: No label changes needed. This is a frontend bug in the App repository that requires an App PR to fix, so DeployBlockerCash should remain, and DeployBlocker should be removed.

    📋 Detailed Analysis

    Evidence

    The bug was discovered during exploratory testing of PR #79780, which added Time expense creation from the global menu. The issue only affects Time expenses when created from the global menu with multiple workspaces - the selected workspace is not visually marked with a green checkmark when navigating back to the workspace selection screen.

    Per Diem expenses, which use a similar workspace selection flow, work correctly and show the checkmark.

    Verification

    I examined the files modified in PR #79780:

    • src/pages/iou/request/step/IOURequestStepTimeWorkspace.tsx (new file)
    • src/pages/iou/request/step/IOURequestStepPerDiemWorkspace.tsx (modified)
    • src/pages/iou/request/step/BaseRequestStepWorkspace.tsx (new file)

    The PR creates these workspace selection screens for both Time and Per Diem expenses.

    Root Cause

    The checkmark display logic in BaseRequestStepWorkspace.tsx (line 68) checks if transaction.participants[0].policyID matches the selected workspace:

    isSelected: selectedWorkspace?.policyID === policy.id

    IOURequestStepPerDiemWorkspace (works correctly):

    // Lines 33-41: Directly sets participants with setMoneyRequestParticipants
    setMoneyRequestParticipants(transactionID, [{
        selected: true,
        accountID: 0,
        isPolicyExpenseChat: true,
        reportID: policyExpenseReportID,
        policyID: policy?.id,  // ← This gets saved to transaction
    }]);

    IOURequestStepTimeWorkspace (has the bug):

    // Lines 37-38: Uses different functions that may not update participants immediately
    setTransactionReport(transactionID, {reportID: policyExpenseChat.reportID}, isTransactionDraft);
    setMoneyRequestParticipantsFromReport(transactionID, policyExpenseChat, accountID);

    The Time workspace selection uses setMoneyRequestParticipantsFromReport() which may not immediately populate transaction.participants with the policyID, causing the checkmark logic to fail. The Per Diem flow uses setMoneyRequestParticipants() with an explicit object containing the policyID, which works correctly.

  8. 8 remaining items

  9. grgia commented on Jan 26, 2026

    @grgia
    Contributor

    Demoting as a blocker

  10. changed the title [-]Selected workspace not marked with green checkmark for Time expense[/-] [+][Time Tracking][Bug] Selected workspace not marked with green checkmark for Time expense[/+] on Jan 26, 2026
  11. grgia commented on Jan 26, 2026

    @grgia
    Contributor

    On step 7 - Selected workspace should be marked with green checkmark for Time expense as it appears for selected workspace for Per Diem expense

    Screen.Recording.2026-01-26.at.10.13.52.AM.mov

    This is the behavior that this is referring to ^ @mhawryluk

  12. added and removed on Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions