You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Time Tracking][Bug] Selected workspace not marked with green checkmark for Time expense #80413
Version Number: v9.3.8-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory around #79780 Email or phone of affected tester (no customers):applausetester+ck12326@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Windows 11/Chrome, iPhone 16/iOS 18.7.1, Pixel 8a/Android 16 App Component: Money Requests
Action Performed:
Precondition : Have multiple workspaces (atleast 2 workspaces) with expense chat created & Per Diem & Time tracking enabled ((You might need to open the chat first at least once).
Navigate to staging,new.expensify.com & log in with Expensifail account
Click on the global "+" button.
Click "Create expense".
Verify there should be a "Time" tab with a list of workspaces to choose from.
Choose any workspace
Click RHP back button
Observe selected workspace is not marked with green checkmark
Repeat steps 2-7 with Per Diem expense & observe green checkmark displayed for selected workspace
Expected Result:
On step 7 - Selected workspace should be marked with green checkmark for Time expense as it appears for selected workspace for Per Diem expense
Actual Result:
On step 7 - Selected workspace not marked with green checkmark for Time expense
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #79780 - "Allow creating time expenses from global menu" by @mhawryluk (High confidence) Related Issues: None
Recommendation: REVERT
The PR introduces a new Time expense creation flow from the global menu, but has an inconsistency in how it persists the workspace selection compared to Per Diem expenses. When a user selects a workspace for Time expenses and clicks the back button, the green checkmark does not appear, indicating the selection was not properly saved to the transaction. This is a user experience issue that makes it appear the selection was lost.
Labels: No label changes needed. This is a frontend bug in the App repository that requires an App PR to fix, so DeployBlockerCash should remain, and DeployBlocker should be removed.
📋 Detailed Analysis
Evidence
The bug was discovered during exploratory testing of PR #79780, which added Time expense creation from the global menu. The issue only affects Time expenses when created from the global menu with multiple workspaces - the selected workspace is not visually marked with a green checkmark when navigating back to the workspace selection screen.
Per Diem expenses, which use a similar workspace selection flow, work correctly and show the checkmark.
// Lines 33-41: Directly sets participants with setMoneyRequestParticipantssetMoneyRequestParticipants(transactionID,[{selected: true,accountID: 0,isPolicyExpenseChat: true,reportID: policyExpenseReportID,policyID: policy?.id,// ← This gets saved to transaction}]);
IOURequestStepTimeWorkspace (has the bug):
// Lines 37-38: Uses different functions that may not update participants immediatelysetTransactionReport(transactionID,{reportID: policyExpenseChat.reportID},isTransactionDraft);setMoneyRequestParticipantsFromReport(transactionID,policyExpenseChat,accountID);
The Time workspace selection uses setMoneyRequestParticipantsFromReport() which may not immediately populate transaction.participants with the policyID, causing the checkmark logic to fail. The Per Diem flow uses setMoneyRequestParticipants() with an explicit object containing the policyID, which works correctly.
changed the title [-]Selected workspace not marked with green checkmark for Time expense[/-][+][Time Tracking][Bug] Selected workspace not marked with green checkmark for Time expense[/+]on Jan 26, 2026
Activity
melvin-bot commentedon Jan 24, 2026
@grgia recently merged #79780, but they are OOO right now, so I'll auto-assign someone else.
melvin-bot commentedon Jan 24, 2026
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 24, 2026
Triggered auto assignment to @aldo-expensify (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 24, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 24, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Jan 24, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #79780 - "Allow creating time expenses from global menu" by @mhawryluk (High confidence)
Related Issues: None
Recommendation: REVERT
The PR introduces a new Time expense creation flow from the global menu, but has an inconsistency in how it persists the workspace selection compared to Per Diem expenses. When a user selects a workspace for Time expenses and clicks the back button, the green checkmark does not appear, indicating the selection was not properly saved to the transaction. This is a user experience issue that makes it appear the selection was lost.
Labels: No label changes needed. This is a frontend bug in the App repository that requires an App PR to fix, so
DeployBlockerCashshould remain, andDeployBlockershould be removed.📋 Detailed Analysis
Evidence
The bug was discovered during exploratory testing of PR #79780, which added Time expense creation from the global menu. The issue only affects Time expenses when created from the global menu with multiple workspaces - the selected workspace is not visually marked with a green checkmark when navigating back to the workspace selection screen.
Per Diem expenses, which use a similar workspace selection flow, work correctly and show the checkmark.
Verification
I examined the files modified in PR #79780:
src/pages/iou/request/step/IOURequestStepTimeWorkspace.tsx(new file)src/pages/iou/request/step/IOURequestStepPerDiemWorkspace.tsx(modified)src/pages/iou/request/step/BaseRequestStepWorkspace.tsx(new file)The PR creates these workspace selection screens for both Time and Per Diem expenses.
Root Cause
The checkmark display logic in
BaseRequestStepWorkspace.tsx(line 68) checks iftransaction.participants[0].policyIDmatches the selected workspace:IOURequestStepPerDiemWorkspace (works correctly):
IOURequestStepTimeWorkspace (has the bug):
The Time workspace selection uses
setMoneyRequestParticipantsFromReport()which may not immediately populatetransaction.participantswith thepolicyID, causing the checkmark logic to fail. The Per Diem flow usessetMoneyRequestParticipants()with an explicit object containing thepolicyID, which works correctly.8 remaining items
grgia commentedon Jan 26, 2026
Demoting as a blocker
[-]Selected workspace not marked with green checkmark for Time expense[/-][+][Time Tracking][Bug] Selected workspace not marked with green checkmark for Time expense[/+]grgia commentedon Jan 26, 2026
Screen.Recording.2026-01-26.at.10.13.52.AM.mov
This is the behavior that this is referring to ^ @mhawryluk