You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for Payment 2026-04-09][$250] Group Split - No RBR on split review after a smartscan fails #80419
Version Number: v9.3.8-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/test-runs/TR-3390/folder/13176944/41237731/1146028429 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Bug source: Regression TC Execution Device used: Windows 10/Chrome App Component: Chat Report View
Action Performed:
Sign in to the ND app
Create a group chat with two other existing accounts, and send a message in the chat
Split a scan expense in the group chat, uploading an image that will fail the scan
When the scan is finished, observe the split preview in the group chat
Expected Result:
Verify that a RBR red dot is added to the split preview in the group DM
changed the title [-]Group Split - No RBR on split review after a smartscan fails[/-][+][$250] Group Split - No RBR on split review after a smartscan fails[/+]on Jan 24, 2026
Restate the problem this issue is trying to solve.
When a smart scan fails for a split expense in a group chat, the split preview does not show the Red Brick Road error indicator. The preview renders, but the red dot is missing even though the split transaction contains a receipt error.
What is the root cause of that problem?
The earliest wrong assumption is that the transaction preview should prefer the parent transaction over the split transaction. In src/components/ReportActionItem/TransactionPreview/index.tsx, the code assumes originalTransaction is the correct source of truth. This is wrong because smart scan errors are stored on the split transaction itself. Passing the parent transaction causes the error check to run on a transaction without errors, which directly suppresses the Red Brick Road indicator.
What changes do you think we should make in order to solve the problem?
Update the transaction passed to TransactionPreviewContent so it always reflects the split transaction.
TransactionPreviewContent already supports split bills correctly. It checks errors on the child transaction and internally resolves the parent transaction when needed.
What alternative solutions did you explore? (Optional)
None. TransactionPreviewContent is designed to receive the split transaction. Passing the parent transaction bypasses the intended error handling logic.
But areRequiredFieldsEmpty check skipped the amount missing check when the zero expense beta is enabled. It's incorrect since the zero expense is only available in the workspace
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Thx @abdulrahuman5196 , when ya fill out the checkilst, please follow this step too (saves me a tiny bit o ftime) <!-- AFTER FILLING THIS OUT, be sure to remove the <details> tags!!!!! -->
Activity
[-]Group Split - No RBR on split review after a smartscan fails[/-][+][$250] Group Split - No RBR on split review after a smartscan fails[/+]melvin-bot commentedon Jan 24, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022015012108776614909
melvin-bot commentedon Jan 24, 2026
Triggered auto assignment to @RachCHopkins (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 24, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (
External)yatin-italy commentedon Jan 24, 2026
Proposal
Restate the problem this issue is trying to solve.
When a smart scan fails for a split expense in a group chat, the split preview does not show the Red Brick Road error indicator. The preview renders, but the red dot is missing even though the split transaction contains a receipt error.
What is the root cause of that problem?
The earliest wrong assumption is that the transaction preview should prefer the parent transaction over the split transaction. In
src/components/ReportActionItem/TransactionPreview/index.tsx, the code assumesoriginalTransactionis the correct source of truth. This is wrong because smart scan errors are stored on the split transaction itself. Passing the parent transaction causes the error check to run on a transaction without errors, which directly suppresses the Red Brick Road indicator.What changes do you think we should make in order to solve the problem?
Update the transaction passed to
TransactionPreviewContentso it always reflects the split transaction.File:
src/components/ReportActionItem/TransactionPreview/index.tsxCurrent code:
Updated code:
TransactionPreviewContentalready supports split bills correctly. It checks errors on the child transaction and internally resolves the parent transaction when needed.What alternative solutions did you explore? (Optional)
None.
TransactionPreviewContentis designed to receive the split transaction. Passing the parent transaction bypasses the intended error handling logic.nkdengineer commentedon Jan 25, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
No RBR after smart scan fail
What is the root cause of that problem?
After a scan split in the group chat failed, the backend only updates the receipt's state to failed. We already have
hasFieldErrorscheckApp/src/libs/TransactionPreviewUtils.ts
Line 392 in 728784e
App/src/libs/TransactionUtils/index.ts
Lines 1462 to 1464 in 728784e
But
areRequiredFieldsEmptycheck skipped the amount missing check when the zero expense beta is enabled. It's incorrect since the zero expense is only available in the workspaceApp/src/libs/TransactionUtils/index.ts
Lines 607 to 614 in 728784e
App/src/libs/TransactionUtils/index.ts
Lines 579 to 585 in 728784e
What changes do you think we should make in order to solve the problem?
We should only skip the amount missing check if the expense is from the expense report
App/src/libs/TransactionUtils/index.ts
Lines 607 to 614 in 728784e
And we also need to do the same in
isAmountMissingfunction by introducingisFromExpenseReportparameterApp/src/libs/TransactionUtils/index.ts
Lines 579 to 585 in 728784e
OPTIONAL: We should also update the RBR message to display missing amount/review requiredinstead when the merchant isn't required.
App/src/libs/TransactionPreviewUtils.ts
Lines 258 to 262 in 728784e
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Jan 28, 2026
@abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick!
33 remaining items
melvin-bot commentedon Apr 16, 2026
@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
mallenexpensify commentedon Apr 17, 2026
@abdulrahuman5196 plz complete the BZ checklist and tag me in a post once you have. Thx
abdulrahuman5196 commentedon Apr 17, 2026
Checking now
abdulrahuman5196 commentedon Apr 17, 2026
BugZero Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: [BETA] Allow zero-amount expenses - ROUND 5 #79197
Link to the comment on the Issue: https://github.com/Expensify/App/pull/79197/changes#r3103036807
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/625795
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-83a6-a872-143b-08f0ad65bbb4abdulrahuman5196 commentedon Apr 17, 2026
@mallenexpensify Completed the checklist
mallenexpensify commentedon Apr 20, 2026
Thx @abdulrahuman5196 , when ya fill out the checkilst, please follow this step too (saves me a tiny bit o ftime)
<!-- AFTER FILLING THIS OUT, be sure to remove the <details> tags!!!!! -->twisterdotcom commentedon Apr 22, 2026
@nkdengineer has submitted payment for this report on ND here.
SO: https://stackoverflowteams.com/c/expensify/questions/7582
Zapier Logs
Run ID: 00040eee-4ddf-a3d7-86fc-e79a9230a144laurenreidexpensify commentedon Apr 27, 2026
$250 approved for @abdulrahuman5196