You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-04-14] [$250] Profile - The default emoji doesn't appear at the profile "Status" settings #80427
⚠️@daledah Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.
Restate the problem this issue is trying to solve.
For new accounts, the default status emoji 💬 does not appear in the Profile Status emoji dropdown. The user cannot see or select the default emoji because the picker starts with no emoji set.
What is the root cause of that problem?
The code assumes that either a draft emoji or a current user emoji always exists. When both values are empty for a new account, the computed default emoji becomes an empty string. This empty value is then passed to the emoji picker, so the picker has no active emoji and does not show the default.
What changes do you think we should make in order to solve the problem?
Update the default emoji calculation to always fall back to the initial emoji.
Modify the assignment in src/pages/settings/Profile/CustomStatus/StatusPage.tsx.
⚠️@yatin-italy Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.
Please re-state the problem that we are trying to solve in this issue.
When a new account opens the Status page, the default emoji (💬) is missing from the emoji dropdown, even though it should appear as the default selection.
What is the root cause of that problem?
The root cause is in the StatusPage.tsx component where the defaultEmoji calculation does not include a fallback to the initialEmoji when both the draft emoji and current user emoji are empty:
draftEmojiCode is undefined (no draft status exists)
currentUserEmojiCode is an empty string '' (no status has been set)
The expression draftEmojiCode || currentUserEmojiCode evaluates to an empty string ''
This empty string is passed as defaultValue to the EmojiPickerButtonDropdown component
The emoji picker displays an empty/placeholder state instead of showing the default emoji
The initialEmoji constant exists and is used in the save logic (line 132), but it's not included in the defaultEmoji calculation for display purposes.
What changes do you think we should make in order to solve the problem?
1. Add initialEmoji as a fallback in the defaultEmoji calculation
Update the defaultEmoji calculation to include initialEmoji as the final fallback, ensuring the default emoji appears in the dropdown for new accounts:
By including initialEmoji in the defaultEmoji calculation, the displayed default emoji now matches what would be saved if the user doesn't explicitly select an emoji, creating a consistent user experience.
What alternative solutions did you explore? (Optional)
Alternative 1: Only show default emoji when there's truly no status
Only show the default emoji when both emoji and text are empty:
Alternative 3: Handle default emoji in the EmojiPickerButtonDropdown component
Add logic in the EmojiPickerButtonDropdown component to show a default emoji when the value is empty.
The chosen solution is the simplest and most direct: add initialEmoji as a fallback in the defaultEmoji calculation. This ensures the default emoji appears in the dropdown for new accounts while preserving all existing behavior for accounts with saved or draft statuses.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.53-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@situchan / @truph01 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
The offending PR is #34780 — "fix logic clear status and save status" (by dukenv0307, merged 2024-01-29).
What it changed: In EmojiPickerButtonDropdown.tsx, it replaced {props.value} with {props.value || <Icon ...>} inside a <Text> component. This put a View-based <Icon> as a child of <Text>, which Android's React Native doesn't support — <Text> can only contain strings or other <Text> nodes on Android.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Jan 24, 2026
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 24, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (
External)github-actions commentedon Jan 24, 2026
yatin-italy commentedon Jan 25, 2026
Proposal
Restate the problem this issue is trying to solve.
For new accounts, the default status emoji 💬 does not appear in the Profile Status emoji dropdown. The user cannot see or select the default emoji because the picker starts with no emoji set.
What is the root cause of that problem?
The code assumes that either a draft emoji or a current user emoji always exists. When both values are empty for a new account, the computed default emoji becomes an empty string. This empty value is then passed to the emoji picker, so the picker has no active emoji and does not show the default.
What changes do you think we should make in order to solve the problem?
src/pages/settings/Profile/CustomStatus/StatusPage.tsx.File:
src/pages/settings/Profile/CustomStatus/StatusPage.tsxWhat alternative solutions did you explore? (Optional)
github-actions commentedon Jan 25, 2026
abbasifaizan70 commentedon Jan 26, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a new account opens the Status page, the default emoji (💬) is missing from the emoji dropdown, even though it should appear as the default selection.
What is the root cause of that problem?
The root cause is in the
StatusPage.tsxcomponent where thedefaultEmojicalculation does not include a fallback to theinitialEmojiwhen both the draft emoji and current user emoji are empty:App/src/pages/settings/Profile/CustomStatus/StatusPage.tsx
Lines 69 to 73 in 87e6d66
The issue is that for new accounts:
draftEmojiCodeisundefined(no draft status exists)currentUserEmojiCodeis an empty string''(no status has been set)draftEmojiCode || currentUserEmojiCodeevaluates to an empty string''defaultValueto theEmojiPickerButtonDropdowncomponentThe
initialEmojiconstant exists and is used in the save logic (line 132), but it's not included in thedefaultEmojicalculation for display purposes.What changes do you think we should make in order to solve the problem?
1. Add
initialEmojias a fallback in thedefaultEmojicalculationUpdate the
defaultEmojicalculation to includeinitialEmojias the final fallback, ensuring the default emoji appears in the dropdown for new accounts:App/src/pages/settings/Profile/CustomStatus/StatusPage.tsx
Lines 69 to 73 in 87e6d66
After:
Why this fix works:
The updated fallback logic now follows this priority:
draftEmojiCodeif a draft status exists (preserves user's in-progress selection)currentUserEmojiCodeif the user has an existing saved emoji (preserves user's saved status)initialEmoji(💬) for new accounts with no status (shows the default emoji)How it integrates with existing save logic:
The save logic at line 132 already uses
initialEmojias a fallback:By including
initialEmojiin thedefaultEmojicalculation, the displayed default emoji now matches what would be saved if the user doesn't explicitly select an emoji, creating a consistent user experience.What alternative solutions did you explore? (Optional)
Alternative 1: Only show default emoji when there's truly no status
Only show the default emoji when both emoji and text are empty:
Alternative 2: Initialize draft status with default emoji
Set the draft status to include the default emoji when no status exists:
Alternative 3: Handle default emoji in the EmojiPickerButtonDropdown component
Add logic in the
EmojiPickerButtonDropdowncomponent to show a default emoji when the value is empty.The chosen solution is the simplest and most direct: add
initialEmojias a fallback in thedefaultEmojicalculation. This ensures the default emoji appears in the dropdown for new accounts while preserving all existing behavior for accounts with saved or draft statuses.82 remaining items
melvin-bot commentedon Apr 7, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 7, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.53-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-04-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 7, 2026
@situchan / @truph01 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Apr 7, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)mallenexpensify commentedon Apr 16, 2026
Payment Summary
Contributor: @truph01 due $250 via NewDot
Contributor+: @situchan due $250 via NewDot
@situchan plz complete the BZ checklist and tag me in a post once you have. Thx
situchan commentedon Apr 16, 2026
@MelvinBot find offending PR which caused this regression based on #80427 (comment)
Especially put
IconinsideTextApp/src/components/EmojiPicker/EmojiPickerButtonDropdown.tsx
Lines 81 to 94 in f0acb8b
MelvinBot commentedon Apr 16, 2026
The offending PR is #34780 — "fix logic clear status and save status" (by
dukenv0307, merged 2024-01-29).What it changed: In
EmojiPickerButtonDropdown.tsx, it replaced{props.value}with{props.value || <Icon ...>}inside a<Text>component. This put aView-based<Icon>as a child of<Text>, which Android's React Native doesn't support —<Text>can only contain strings or other<Text>nodes on Android.Evidence
Before PR #34780 (commit
c9663a58):After PR #34780 (commit
05a4c19a):Next Steps: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.situchan commentedon Apr 16, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/34780/changes#r3094471057
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/625225
Regression Test Proposal
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-3e38-aaa3-5180-25ad611c9cc4laurenreidexpensify commentedon Apr 27, 2026
$250 approved for @situchan
garrettmknight commentedon May 22, 2026
$250 approved for @truph01