You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
"Itemized receipt required" appears on distance expense when map receipt cannot be replaced #80568
Version Number: 9.3.9-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#73939 Email or phone of affected tester (no customers):soindjonsidjiosjods@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.1 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Rules are enabled.
Go to staging.new.expensify.com
Go to workspace settings > Categories.
Click Advertising.
Click "Require receipts over" and select "Always require receipts".
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #73939 - "Add itemized receipt requirement settings for workspace and category rules" by @abzokhattab (High confidence) Related Issues: None
Recommendation: REVERT
PR #73939 should be reverted because it introduces a violation that incorrectly applies to distance expenses, which have map receipts that cannot be replaced by users.
Labels: Removing DeployBlocker label (backend is not affected). Keeping DeployBlockerCash (App deploy is blocked).
Detailed Analysis
Evidence
PR #73939 introduced the itemized receipt requirement feature, adding new violation logic to flag expenses that exceed a threshold and require itemized receipts. However, the implementation did not account for distance expenses, which have auto-generated map receipts that users cannot replace.
From the reproduction steps:
Set category rule: "Always require itemized receipts"
Create a map distance expense
Assign it to that category
The violation appears even though users cannot replace the map receipt
Verification
The bug is in /home/runner/work/App/App/src/libs/Violations/ViolationsUtils.ts at line 434:
This logic checks if the transaction is eligible for the itemized receipt violation. However, it does not exclude distance requests. On line 397, isDistanceRequest is already calculated but not used in this check.
Distance transactions always have a map receipt that cannot be replaced, so they should never be subject to itemized receipt requirements.
Root Cause
The itemized receipt violation logic added in PR #73939 applies to all transaction types without excluding distance expenses. Distance expenses have map receipts with receipt.state = "OPEN", which means hasReceipt() returns true. However, even though they have a receipt, users cannot upload an itemized receipt to replace the map.
The fix would be to add && !isDistanceRequest to the eligibility check on line 434, similar to how other violation types exclude distance requests (e.g., hasMissingSmartscanFields on line 1486 of TransactionUtils).
Thanks @abzokhattab! I think this may be backend though - I probably need to filter out distance receipts from getting the violation? (If so, I think it's not an App deploy blocker)
weird I'm not able to reproduce this locally, even following the steps in the issue. However, I've created a PR that should (?) fix it. Let me know if you notice anything front end, though, @abzokhattab
I reproduced it with a new account @dangrous, yeah it does look to be a backend issue if we are disabling it for the normal receipt on the backend lets do the same for the itemised ones
yeah i think we autogenerate a receipt in the backend for distance requests, which is why it doesn't get flagged as receipt required. However, it has no line items, so it gets hit with itemized receipt required. My PR should fix it, but I'll remove the blocker label here if there's no front end change needed!
I don't think this edge case is enough to make us revert the FE PR
Activity
melvin-bot commentedon Jan 27, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #73939
melvin-bot commentedon Jan 27, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Jan 27, 2026
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jan 27, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Jan 27, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #73939 - "Add itemized receipt requirement settings for workspace and category rules" by @abzokhattab (High confidence)
Related Issues: None
Recommendation: REVERT
PR #73939 should be reverted because it introduces a violation that incorrectly applies to distance expenses, which have map receipts that cannot be replaced by users.
Labels: Removing
DeployBlockerlabel (backend is not affected). KeepingDeployBlockerCash(App deploy is blocked).Detailed Analysis
Evidence
PR #73939 introduced the itemized receipt requirement feature, adding new violation logic to flag expenses that exceed a threshold and require itemized receipts. However, the implementation did not account for distance expenses, which have auto-generated map receipts that users cannot replace.
From the reproduction steps:
Verification
The bug is in
/home/runner/work/App/App/src/libs/Violations/ViolationsUtils.tsat line 434:This logic checks if the transaction is eligible for the itemized receipt violation. However, it does not exclude distance requests. On line 397,
isDistanceRequestis already calculated but not used in this check.Distance transactions always have a map receipt that cannot be replaced, so they should never be subject to itemized receipt requirements.
Root Cause
The itemized receipt violation logic added in PR #73939 applies to all transaction types without excluding distance expenses. Distance expenses have map receipts with
receipt.state = "OPEN", which meanshasReceipt()returns true. However, even though they have a receipt, users cannot upload an itemized receipt to replace the map.The fix would be to add
&& !isDistanceRequestto the eligibility check on line 434, similar to how other violation types exclude distance requests (e.g.,hasMissingSmartscanFieldson line 1486 of TransactionUtils).abzokhattab commentedon Jan 27, 2026
I am struggling to reproduce the issue is there any step i am missing @mitarachim
Screen.Recording.2026-01-27.at.04.42.07.mov
mitarachim commentedon Jan 27, 2026
Hello @abzokhattab i still able to reproduce issue with follow original steps
Screen.Recording.2026-01-27.at.10.49.11.AM.mov
abzokhattab commentedon Jan 27, 2026
On it today
dangrous commentedon Jan 27, 2026
Thanks @abzokhattab! I think this may be backend though - I probably need to filter out distance receipts from getting the violation? (If so, I think it's not an App deploy blocker)
dangrous commentedon Jan 27, 2026
weird I'm not able to reproduce this locally, even following the steps in the issue. However, I've created a PR that should (?) fix it. Let me know if you notice anything front end, though, @abzokhattab
abzokhattab commentedon Jan 27, 2026
I reproduced it with a new account @dangrous, yeah it does look to be a backend issue if we are disabling it for the normal receipt on the backend lets do the same for the itemised ones
Screen.Recording.2026-01-27.at.16.30.32.mov
dangrous commentedon Jan 27, 2026
yeah i think we autogenerate a receipt in the backend for distance requests, which is why it doesn't get flagged as receipt required. However, it has no line items, so it gets hit with itemized receipt required. My PR should fix it, but I'll remove the blocker label here if there's no front end change needed!
I don't think this edge case is enough to make us revert the FE PR
dangrous commentedon Jan 28, 2026
This is on prod, will request a re-test
m-natarajan commentedon Jan 28, 2026
This issue is not reproducible on Windows 11 / Chrome, Xiaomi Poco F5 / Android 13,iPhone 12 mini / iOS 26.2 in v9.3.10-3
1000175576.mp4
Repro80568iOS.mp4
bandicam.2026-01-29.00-12-17-571.mp4
dangrous commentedon Jan 28, 2026
perfect! i will close this; i dont think payment is required.