You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Per diem - Destination list is not scrolled to the top when opened from confirm page #80664
Version Number: 9.3.10-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#80335 Email or phone of affected tester (no customers):sodijnsodijsodijsoi@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.1 / Chrome App Component: Money Requests
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #80335 - "Make DestinationPicker use new SelectionListWitSections" by @zfurtak (High confidence) Related Issues: #65658
Recommendation: REVERT
The PR introduced a new prop disableMaintainingScrollPosition to the DestinationPicker component which prevents the list from maintaining scroll position. This causes the destination list to not scroll to the top when reopened from the confirm page, which is the reported bug.
Labels: No changes needed - DeployBlockerCash is correctly applied (frontend bug blocking App deploy)
Melvin-bot automatically assigned the PR author to this deploy blocker
Verification
The PR modified src/components/DestinationPicker.tsx and added the following key change on line 88:
disableMaintainingScrollPosition
This prop is passed to the SelectionListWithSections component and controls the scroll behavior. When set to true, it disables the scroll position maintenance feature, which prevents the list from scrolling to the expected position when reopened.
Root Cause
The disableMaintainingScrollPosition prop was added to prevent the list from automatically adjusting scroll position during data updates. However, this also prevents the list from scrolling to the top when the component is remounted or reopened from another page (like the confirm page).
When a user navigates from the confirm page back to the destination picker, the component key changes (key={selectedDestination} on line 79), which should cause a remount. However, the disableMaintainingScrollPosition prop interferes with the expected scroll-to-top behavior that should occur on mount/remount.
The fix would require either:
Removing the disableMaintainingScrollPosition prop from DestinationPicker
Adding logic to reset scroll position when the component is opened from another page
Using a different approach to handle the scroll position
Activity
melvin-bot commentedon Jan 27, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #80335
melvin-bot commentedon Jan 27, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 27, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Jan 27, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #80335 - "Make
DestinationPickeruse newSelectionListWitSections" by @zfurtak (High confidence)Related Issues: #65658
Recommendation: REVERT
The PR introduced a new prop
disableMaintainingScrollPositionto the DestinationPicker component which prevents the list from maintaining scroll position. This causes the destination list to not scroll to the top when reopened from the confirm page, which is the reported bug.Labels: No changes needed -
DeployBlockerCashis correctly applied (frontend bug blocking App deploy)📋 Detailed Analysis
Evidence
DestinationPickeruse newSelectionListWitSections#80335 in the bug reportDestinationPickeruse newSelectionListWitSections#80335 is deployedDestinationPickeruse newSelectionListWitSections#80335 is not yet deployedVerification
The PR modified
src/components/DestinationPicker.tsxand added the following key change on line 88:disableMaintainingScrollPositionThis prop is passed to the SelectionListWithSections component and controls the scroll behavior. When set to
true, it disables the scroll position maintenance feature, which prevents the list from scrolling to the expected position when reopened.Root Cause
The
disableMaintainingScrollPositionprop was added to prevent the list from automatically adjusting scroll position during data updates. However, this also prevents the list from scrolling to the top when the component is remounted or reopened from another page (like the confirm page).When a user navigates from the confirm page back to the destination picker, the component key changes (
key={selectedDestination}on line 79), which should cause a remount. However, thedisableMaintainingScrollPositionprop interferes with the expected scroll-to-top behavior that should occur on mount/remount.The fix would require either:
disableMaintainingScrollPositionprop from DestinationPickerzfurtak commentedon Jan 28, 2026
Yeah, this is most probably my PR, I'm looking into it right now 👍
grgia commentedon Jan 28, 2026
@zfurtak are you able to push a fix today? Or do we need to revert to have more time
zfurtak commentedon Jan 28, 2026
I think it will be ready today, I'll do my best 😊
zfurtak commentedon Jan 28, 2026
PR open!
zfurtak commentedon Jan 28, 2026
Approved and ready to be merged :)
m-natarajan commentedon Jan 28, 2026
Passed, Chrome / v9.3.10-6
Screen.Recording.2026-01-29.at.00.27.03.mp4