You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] [Insights] Reports - Keyword filter is applied with "limit:" after clearing limit filter and click View results #80675
Version Number: 9.3.10-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#80262 Email or phone of affected tester (no customers):osdijosijdodninjso@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.1 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Create a workspace.
Go to Reports > Top categories.
Open Filters.
Open Limit filter.
Clear the field and save it.
Click View results.
Open Filters.
Expected Result:
No extra filter will be applied after clearing limit filter and clicking View results.
Actual Result:
Keyword filter is applied with "limit:" after clearing limit filter and clicking View results.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #80262 - "feat: [Insights] [Release 1] Top Categories - Add a limit filter to search" by @TaduJR (High confidence) Related Issues: None
Recommendation: ROLL FORWARD
The fix is simple and low-risk - just adding a check for empty strings. A revert would remove the entire limit filter feature which is more disruptive than a quick fix.
Labels: No label changes needed - keeping DeployBlockerCash since this is a frontend bug in the App repository.
Detailed Analysis
Evidence
PR #80262 added the limit filter functionality to the search feature. The bug appears when clearing the limit field - instead of removing the filter, it adds limit: (with empty value) to the query string, which then gets interpreted as a keyword filter.
The issue: When a user clears the limit field in the UI, it becomes an empty string "". The check limitValue !== undefined evaluates to true for empty strings, so it adds limit: to the query. This gets parsed as a keyword filter with value "limit:".
Why this is a Frontend bug:
The form field type is string (confirmed in SearchAdvancedFiltersForm.ts line 679)
The bug is in the App codebase query building logic
No backend API changes are needed - the fix is purely client-side validation
Root Cause
The buildQueryStringFromFilterFormValues function in SearchQueryUtils.ts does not validate that the limit value is non-empty before adding it to the query string. It only checks for undefined, but form fields return empty strings when cleared, not undefined.
The fix should check if the limit value is a non-empty string and a valid positive integer:
changed the title [-]Reports - Keyword filter is applied with "limit:" after clearing limit filter and click View results[/-][+][Insights] Reports - Keyword filter is applied with "limit:" after clearing limit filter and click View results[/+]on Jan 28, 2026
changed the title [-][Insights] Reports - Keyword filter is applied with "limit:" after clearing limit filter and click View results[/-][+][$250] [Insights] Reports - Keyword filter is applied with "limit:" after clearing limit filter and click View results[/+]on Jan 28, 2026
Activity
melvin-bot commentedon Jan 27, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #80262
melvin-bot commentedon Jan 27, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 27, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
ShridharGoel commentedon Jan 27, 2026
@TaduJR Can you have a look?
OSBotify commentedon Jan 27, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #80262 - "feat: [Insights] [Release 1] Top Categories - Add a limit filter to search" by @TaduJR (High confidence)
Related Issues: None
Recommendation: ROLL FORWARD
The fix is simple and low-risk - just adding a check for empty strings. A revert would remove the entire limit filter feature which is more disruptive than a quick fix.
Labels: No label changes needed - keeping
DeployBlockerCashsince this is a frontend bug in the App repository.Detailed Analysis
Evidence
PR #80262 added the limit filter functionality to the search feature. The bug appears when clearing the limit field - instead of removing the filter, it adds
limit:(with empty value) to the query string, which then gets interpreted as a keyword filter.Verification
Affected file:
/home/runner/work/App/App/src/libs/SearchQueryUtils.ts(lines 747-750)Root cause code:
The issue: When a user clears the limit field in the UI, it becomes an empty string
"". The checklimitValue !== undefinedevaluates totruefor empty strings, so it addslimit:to the query. This gets parsed as a keyword filter with value "limit:".Why this is a Frontend bug:
string(confirmed inSearchAdvancedFiltersForm.tsline 679)Root Cause
The
buildQueryStringFromFilterFormValuesfunction inSearchQueryUtils.tsdoes not validate that the limit value is non-empty before adding it to the query string. It only checks forundefined, but form fields return empty strings when cleared, notundefined.The fix should check if the limit value is a non-empty string and a valid positive integer:
puneetlath commentedon Jan 28, 2026
I don't think it's big enough to be a blocker, but we should fix @TaduJR.
[-]Reports - Keyword filter is applied with "limit:" after clearing limit filter and click View results[/-][+][Insights] Reports - Keyword filter is applied with "limit:" after clearing limit filter and click View results[/+]1 remaining item
melvin-bot commentedon Jan 28, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022016310634435774836
[-][Insights] Reports - Keyword filter is applied with "limit:" after clearing limit filter and click View results[/-][+][$250] [Insights] Reports - Keyword filter is applied with "limit:" after clearing limit filter and click View results[/+]melvin-bot commentedon Jan 28, 2026
Current assignee @ShridharGoel is eligible for the External assigner, not assigning anyone new.
TaduJR commentedon Jan 29, 2026
PR is ready.
trjExpensify commentedon Feb 5, 2026
On prod. Settling up with Tadu and Shridhar at the end, closing!