Skip to content

Reports - Folder icon is not shown in the category row #80689

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.3.10-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #80333
Email or phone of affected tester (no customers): applausetester+bg@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: macOS/chrome
App Component: Other

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create an expense with category
  4. Navigate to the Reports page > Group by category

Expected Result:

Each category row displays the folder icon

Actual Result:

No folder icon shown

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

bug.mov

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Jan 27, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #80333

  2. melvin-bot commented on Jan 27, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  3. github-actions commented on Jan 27, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. OSBotify commented on Jan 27, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #80333 - "feat: [Insights] [Release 1] Top Categories - Add group-by:category" by @TaduJR (High confidence)
    Related Issues: None

    Recommendation: REVERT

    The causing PR is clear and can be cleanly reverted. This is a new feature that was just merged and has not shipped to production yet.

    Labels: Keeping DeployBlockerCash (App deploy is blocked). Removed DeployBlocker label as this is a frontend bug requiring an App PR fix.

    📋 Detailed Analysis

    Evidence

    PR #80333 added the groupBy:category functionality to the Search feature, which includes a new component CategoryListItemHeader.tsx that renders the category rows. The issue reporter explicitly states that the folder icon is missing from category rows on the Reports page, which was caught during QA of PR #80333.

    Verification

    I examined the files modified by PR #80333 and confirmed:

    Root Cause

    The CategoryListItemHeader component is missing the folder icon that should appear next to category names.

    Comparison with similar components:

    1. MemberListItemHeader (lines 121-130, 145-156): Shows Avatar component on both small and large screens
    2. CardListItemHeader (lines 133-138, 153-164): Shows ReportActionAvatars component on both small and large screens
    3. CategoryListItemHeader (lines 113-121, 123): Missing icon component - only shows text via TextWithTooltip

    Expected implementation:
    Based on how category icons are used elsewhere in the codebase (e.g., /home/runner/work/App/App/src/components/TransactionItemRow/DataCells/CategoryCell.tsx), the component should use:

    • The Folder icon from useMemoizedLazyExpensifyIcons(['Folder'])
    • Display it via Icon component or TextWithIconCell component
    • Show it alongside the category name on both large and small screens

    Test plan confirmation:
    The PR's own test plan (Test 2, step 5) states: "Verify each category row displays the folder icon, category name, expense count, and total amount" - but the folder icon was never implemented in the code.

  5. TaduJR commented on Jan 27, 2026

    @TaduJR
    Contributor

    I think this is expected from the figma mock

  6. TaduJR commented on Jan 27, 2026

    @TaduJR
    Contributor
  7. neil-marcellini commented on Jan 27, 2026

    @neil-marcellini
    Contributor

    Yes this is not a bug.

    Reported "bug"
    Image

    "Design doc mock"
    Image

  8. neil-marcellini commented on Jan 27, 2026

    @neil-marcellini
    Contributor

    @TaduJR looks like you missed updating the test steps with the proper expectation after Shawns request. Reminder for next time.

  9. shawnborton commented on Jan 28, 2026

    @shawnborton
    Contributor

    Correct, not a bug. Thanks team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions